DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index
@ 2020-09-11  9:37 Sachin Saxena (OSS)
  2020-09-11 13:05 ` Ferruh Yigit
  2020-09-14 14:21 ` [dpdk-dev] [PATCH v2] " Sachin Saxena (OSS)
  0 siblings, 2 replies; 4+ messages in thread
From: Sachin Saxena (OSS) @ 2020-09-11  9:37 UTC (permalink / raw)
  To: dev, ferruh.yigit

From: Sachin Saxena <sachin.saxena@oss.nxp.com>

Dpaa2 pmd has no need to bound host interface
for which we require if_index field.
Setting it to 0 as unused.

Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 0e9f836e5..c91543131 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -241,7 +241,7 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 
 	PMD_INIT_FUNC_TRACE();
 
-	dev_info->if_index = priv->hw_id;
+	dev_info->if_index = 0;
 
 	dev_info->max_mac_addrs = priv->max_mac_filters;
 	dev_info->max_rx_pktlen = DPAA2_MAX_RX_PKT_LEN;
-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index
  2020-09-11  9:37 [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index Sachin Saxena (OSS)
@ 2020-09-11 13:05 ` Ferruh Yigit
  2020-09-14 14:21 ` [dpdk-dev] [PATCH v2] " Sachin Saxena (OSS)
  1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-09-11 13:05 UTC (permalink / raw)
  To: Sachin Saxena (OSS), dev

On 9/11/2020 10:37 AM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
> 
> Dpaa2 pmd has no need to bound host interface
> for which we require if_index field.
> Setting it to 0 as unused.
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> ---
>  drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 0e9f836e5..c91543131 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -241,7 +241,7 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>  
>  	PMD_INIT_FUNC_TRACE();
>  
> -	dev_info->if_index = priv->hw_id;
> +	dev_info->if_index = 0;
>  

Same here, I think assignment can be dropped completely.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] net/dpaa2: fix misuse of if_index
  2020-09-11  9:37 [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index Sachin Saxena (OSS)
  2020-09-11 13:05 ` Ferruh Yigit
@ 2020-09-14 14:21 ` Sachin Saxena (OSS)
  2020-09-14 17:10   ` Ferruh Yigit
  1 sibling, 1 reply; 4+ messages in thread
From: Sachin Saxena (OSS) @ 2020-09-14 14:21 UTC (permalink / raw)
  To: dev, ferruh.yigit

From: Sachin Saxena <sachin.saxena@oss.nxp.com>

Dpaa2 pmd has no need to bound host interface
for which we require if_index field.
Setting it to 0 as unused.

Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 0e9f836e5..02daa4d25 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -241,8 +241,6 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 
 	PMD_INIT_FUNC_TRACE();
 
-	dev_info->if_index = priv->hw_id;
-
 	dev_info->max_mac_addrs = priv->max_mac_filters;
 	dev_info->max_rx_pktlen = DPAA2_MAX_RX_PKT_LEN;
 	dev_info->min_rx_bufsize = DPAA2_MIN_RX_BUF_SIZE;
-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/dpaa2: fix misuse of if_index
  2020-09-14 14:21 ` [dpdk-dev] [PATCH v2] " Sachin Saxena (OSS)
@ 2020-09-14 17:10   ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-09-14 17:10 UTC (permalink / raw)
  To: Sachin Saxena (OSS), dev

On 9/14/2020 3:21 PM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
> 
> Dpaa2 pmd has no need to bound host interface
> for which we require if_index field.
> Setting it to 0 as unused.
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>

Fixes: 3e5a335d3f88 ("net/dpaa2: add basic operations")
Cc: stable@dpdk.org

Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-14 17:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11  9:37 [dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index Sachin Saxena (OSS)
2020-09-11 13:05 ` Ferruh Yigit
2020-09-14 14:21 ` [dpdk-dev] [PATCH v2] " Sachin Saxena (OSS)
2020-09-14 17:10   ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git