* [dpdk-dev] [PATCH] net/enic: check return code
@ 2020-10-14 20:25 John Daley
2020-10-14 21:31 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: John Daley @ 2020-10-14 20:25 UTC (permalink / raw)
To: ferruh.yigit, arybchenko; +Cc: dev, John Daley
Coverity issue: 363046
Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_fm_flow.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c
index 96ec360a85..9cea94269c 100644
--- a/drivers/net/enic/enic_fm_flow.c
+++ b/drivers/net/enic/enic_fm_flow.c
@@ -2232,7 +2232,11 @@ enic_action_handle_get(struct enic_flowman *fm, struct fm_action *action_in,
error_with_action_handle:
args[0] = FM_ACTION_FREE;
args[1] = ah->handle;
- flowman_cmd(fm, args, 2);
+ ret = flowman_cmd(fm, args, 2);
+ if (ret != 0)
+ rte_flow_error_set(error, -ret,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, "enic: devcmd(action-free)");
error_with_ah:
free(ah);
return ret;
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: check return code
2020-10-14 20:25 [dpdk-dev] [PATCH] net/enic: check return code John Daley
@ 2020-10-14 21:31 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-10-14 21:31 UTC (permalink / raw)
To: John Daley, arybchenko; +Cc: dev
On 10/14/2020 9:25 PM, John Daley wrote:
> Coverity issue: 363046
> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
>
> Signed-off-by: John Daley <johndale@cisco.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-14 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 20:25 [dpdk-dev] [PATCH] net/enic: check return code John Daley
2020-10-14 21:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).