From: nipun.gupta@nxp.com
To: dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
arybchenko@solarflare.com, hemant.agrawal@nxp.com,
sachin.saxena@nxp.com, rohit.raj@nxp.com, jerinjacobk@gmail.com,
stephen@networkplumber.org, asafp@nvidia.com,
Nipun Gupta <nipun.gupta@nxp.com>
Subject: [dpdk-dev] [PATCH 2/3 v4] net/dpaa: support Rx offload for error packet drop
Date: Thu, 15 Oct 2020 18:53:42 +0530 [thread overview]
Message-ID: <20201015132343.4050-2-nipun.gupta@nxp.com> (raw)
In-Reply-To: <20201015132343.4050-1-nipun.gupta@nxp.com>
From: Nipun Gupta <nipun.gupta@nxp.com>
This patch supports Rx offload configuration to drop error
packets in the hardware
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
drivers/bus/dpaa/base/fman/fman_hw.c | 7 ++++++-
drivers/net/dpaa/dpaa_ethdev.c | 23 +++++++++++++++++++----
2 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c
index 4ab49f785..40e4e0000 100644
--- a/drivers/bus/dpaa/base/fman/fman_hw.c
+++ b/drivers/bus/dpaa/base/fman/fman_hw.c
@@ -597,7 +597,12 @@ void
fman_if_discard_rx_errors(struct fman_if *fm_if)
{
struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if);
- unsigned int *fmbm_rfsdm, *fmbm_rfsem;
+ unsigned int *fmbm_rcfg, *fmbm_rfsdm, *fmbm_rfsem;
+ unsigned int val;
+
+ fmbm_rcfg = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rcfg;
+ val = in_be32(fmbm_rcfg);
+ out_be32(fmbm_rcfg, val & ~BMI_PORT_CFG_FDOVR);
fmbm_rfsem = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rfsem;
out_be32(fmbm_rfsem, 0);
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index af47c196a..b9cfc4fb3 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -52,7 +52,8 @@
/* Supported Rx offloads */
static uint64_t dev_rx_offloads_sup =
DEV_RX_OFFLOAD_JUMBO_FRAME |
- DEV_RX_OFFLOAD_SCATTER;
+ DEV_RX_OFFLOAD_SCATTER |
+ DEV_RX_OFFLOAD_ERR_PKT_DROP;
/* Rx offloads which cannot be disabled */
static uint64_t dev_rx_offloads_nodis =
@@ -62,6 +63,10 @@ static uint64_t dev_rx_offloads_nodis =
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_RSS_HASH;
+/* Supported Rx Error packet drop offload */
+static uint64_t dev_rx_err_drop_offloads_sup =
+ RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_ALL;
+
/* Supported Tx offloads */
static uint64_t dev_tx_offloads_sup =
DEV_TX_OFFLOAD_MT_LOCKFREE |
@@ -262,6 +267,18 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)
dev->data->scattered_rx = 1;
}
+ if (eth_conf->err_pkt_drop_conf.all) {
+ DPAA_PMD_DEBUG("error packets will be dropped on hw");
+ fman_if_discard_rx_errors(fif);
+ } else {
+ struct dpaa_if *dpaa_intf = dev->data->dev_private;
+ struct qman_fq *rxq = &dpaa_intf->rx_queues[0];
+
+ DPAA_PMD_DEBUG("error packets will not be dropped on hw");
+ fman_if_receive_rx_errors(fif, FM_FD_RX_STATUS_ERR_MASK);
+ fman_if_set_err_fqid(fif, rxq->fqid);
+ }
+
if (!(default_q || fmc_q)) {
if (dpaa_fm_config(dev,
eth_conf->rx_adv_conf.rss_conf.rss_hf)) {
@@ -591,6 +608,7 @@ static int dpaa_eth_dev_info(struct rte_eth_dev *dev,
dev_rx_offloads_nodis;
dev_info->tx_offload_capa = dev_tx_offloads_sup |
dev_tx_offloads_nodis;
+ dev_info->rx_err_drop_offload_capa = dev_rx_err_drop_offloads_sup;
dev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;
dev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;
dev_info->default_rxportconf.nb_queues = 1;
@@ -2085,9 +2103,6 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
fman_intf->mac_addr.addr_bytes[5]);
if (!fman_intf->is_shared_mac) {
- /* Configure error packet handling */
- fman_if_receive_rx_errors(fman_intf,
- FM_FD_RX_STATUS_ERR_MASK);
/* Disable RX mode */
fman_if_disable_rx(fman_intf);
/* Disable promiscuous mode */
--
2.17.1
next prev parent reply other threads:[~2020-10-15 13:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 7:53 [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets Nipun Gupta
2020-08-31 12:58 ` Ferruh Yigit
2020-08-31 16:04 ` Nipun Gupta
2020-08-31 17:00 ` Stephen Hemminger
2020-09-01 8:09 ` Thomas Monjalon
2020-09-01 10:56 ` Nipun Gupta
2020-09-21 7:29 ` Ori Kam
2020-10-05 7:15 ` [dpdk-dev] [PATCH 1/3 v2] " nipun.gupta
2020-10-05 7:15 ` [dpdk-dev] [PATCH 2/3 v2] net/dpaa: support RX offload for error packet drop nipun.gupta
2020-10-05 7:15 ` [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-08 15:06 ` Asaf Penso
2020-10-08 15:45 ` Nipun Gupta
2020-10-05 15:34 ` [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx " Stephen Hemminger
2020-10-05 16:10 ` Jerin Jacob
2020-10-06 10:37 ` Nipun Gupta
2020-10-06 12:01 ` Jerin Jacob
2020-10-06 13:10 ` Nipun Gupta
2020-10-06 13:13 ` Jerin Jacob
2020-10-08 8:53 ` Nipun Gupta
2020-10-08 8:55 ` Jerin Jacob
2020-10-08 15:13 ` Asaf Penso
2020-10-09 13:13 ` [dpdk-dev] [PATCH 1/3 v3] " nipun.gupta
2020-10-09 13:13 ` [dpdk-dev] [PATCH 2/3 v3] net/dpaa: support RX offload for error packet drop nipun.gupta
2020-10-09 13:13 ` [dpdk-dev] [PATCH 3/3 v3] app/testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-11 7:22 ` Asaf Penso
2020-10-11 10:13 ` [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx " Jerin Jacob
2020-10-11 21:41 ` Thomas Monjalon
2020-10-12 5:40 ` Nipun Gupta
2020-10-13 7:22 ` Nipun Gupta
2020-10-12 8:01 ` Andrew Rybchenko
2020-10-12 11:30 ` Nipun Gupta
2020-10-12 12:22 ` Andrew Rybchenko
2020-10-12 12:53 ` Nipun Gupta
2020-10-13 7:21 ` Andrew Rybchenko
2020-10-13 7:36 ` Nipun Gupta
2020-10-13 7:51 ` Andrew Rybchenko
2020-10-13 8:12 ` Nipun Gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx " nipun.gupta
2020-10-15 13:23 ` nipun.gupta [this message]
2020-10-15 13:23 ` [dpdk-dev] [PATCH 3/3 v4] app/testpmd: support hardware " nipun.gupta
2020-10-29 17:22 ` Dharmik Thakkar
2020-10-31 18:16 ` Nipun Gupta
2020-10-19 3:30 ` [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx " Ajit Khaparde
2021-02-18 20:32 ` Ferruh Yigit
2021-02-18 20:37 ` Thomas Monjalon
2021-04-20 1:11 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015132343.4050-2-nipun.gupta@nxp.com \
--to=nipun.gupta@nxp.com \
--cc=arybchenko@solarflare.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinjacobk@gmail.com \
--cc=rohit.raj@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).