DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about
@ 2020-10-29 13:36 luca.boccassi
  2020-11-04 18:34 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: luca.boccassi @ 2020-10-29 13:36 UTC (permalink / raw)
  To: dev

From: Luca Boccassi <luca.boccassi@microsoft.com>

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
Would be really great to hook up some spell checkers to the CI, so
that I'm not the only one who gets nagged by automated tools :-)

 app/test-fib/main.c                               | 4 ++--
 drivers/net/hns3/hns3_ethdev.h                    | 2 +-
 drivers/net/i40e/i40e_ethdev_vf.c                 | 2 +-
 drivers/net/ixgbe/base/ixgbe_x540.c               | 2 +-
 drivers/net/netvsc/hn_rndis.c                     | 2 +-
 drivers/net/qede/base/ecore_sriov.c               | 2 +-
 drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/test-fib/main.c b/app/test-fib/main.c
index 9e6a4f2231..b0a97b0d7e 100644
--- a/app/test-fib/main.c
+++ b/app/test-fib/main.c
@@ -629,10 +629,10 @@ print_usage(void)
 		"[-s <shuffle randomly generated routes>]\n"
 		"[-a <check nexthops for all ipv4 address space"
 		"(only valid with -c)>]\n"
-		"[-b <fib algorithm>]\n\tavailible options for ipv4\n"
+		"[-b <fib algorithm>]\n\tavailable options for ipv4\n"
 		"\t\trib - RIB based FIB\n"
 		"\t\tdir - DIR24_8 based FIB\n"
-		"\tavailible options for ipv6:\n"
+		"\tavailable options for ipv6:\n"
 		"\t\trib - RIB based FIB\n"
 		"\t\ttrie - TRIE based FIB\n"
 		"defaults are: dir for ipv4 and trie for ipv6\n"
diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
index da8aead2f3..8392da8f15 100644
--- a/drivers/net/hns3/hns3_ethdev.h
+++ b/drivers/net/hns3/hns3_ethdev.h
@@ -166,7 +166,7 @@ enum hns3_media_type {
 
 struct hns3_mac {
 	uint8_t mac_addr[RTE_ETHER_ADDR_LEN];
-	bool default_addr_setted; /* whether default addr(mac_addr) is setted */
+	bool default_addr_setted; /* whether default addr(mac_addr) is set */
 	uint8_t media_type;
 	uint8_t phy_addr;
 	uint8_t link_duplex  : 1; /* ETH_LINK_[HALF/FULL]_DUPLEX */
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 53154c3ef3..1139312331 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -260,7 +260,7 @@ i40evf_read_pfmsg(struct rte_eth_dev *dev, struct i40evf_arq_msg_info *data)
 		case VIRTCHNL_EVENT_RESET_IMPENDING:
 			vf->vf_reset = true;
 			vf->pend_msg |= PFMSG_RESET_IMPENDING;
-			PMD_DRV_LOG(INFO, "vf is reseting");
+			PMD_DRV_LOG(INFO, "vf is resetting");
 			break;
 		case VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
 			vf->dev_closed = true;
diff --git a/drivers/net/ixgbe/base/ixgbe_x540.c b/drivers/net/ixgbe/base/ixgbe_x540.c
index 4cea16a817..8efde4645a 100644
--- a/drivers/net/ixgbe/base/ixgbe_x540.c
+++ b/drivers/net/ixgbe/base/ixgbe_x540.c
@@ -784,7 +784,7 @@ s32 ixgbe_acquire_swfw_sync_X540(struct ixgbe_hw *hw, u32 mask)
 	 * bits in the SW_FW_SYNC register.
 	 */
 	if (ixgbe_get_swfw_sync_semaphore(hw)) {
-		DEBUGOUT("Failed to get NVM sempahore and register semaphore while forcefully ignoring FW sempahore bit(s) and setting SW semaphore bit(s), returning IXGBE_ERR_SWFW_SYNC\n");
+		DEBUGOUT("Failed to get NVM semaphore and register semaphore while forcefully ignoring FW semaphore bit(s) and setting SW semaphore bit(s), returning IXGBE_ERR_SWFW_SYNC\n");
 		return IXGBE_ERR_SWFW_SYNC;
 	}
 	swfw_sync = IXGBE_READ_REG(hw, IXGBE_SWFW_SYNC_BY_MAC(hw));
diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c
index 66d1966f29..1ce260c89b 100644
--- a/drivers/net/netvsc/hn_rndis.c
+++ b/drivers/net/netvsc/hn_rndis.c
@@ -276,7 +276,7 @@ static int hn_nvs_send_rndis_ctrl(struct vmbus_channel *chan,
 	sg.len  = reqlen;
 
 	if (sg.ofs + reqlen >  PAGE_SIZE) {
-		PMD_DRV_LOG(ERR, "RNDIS request crosses page bounary");
+		PMD_DRV_LOG(ERR, "RNDIS request crosses page boundary");
 		return -EINVAL;
 	}
 
diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c
index dac4cbee86..ed8cc695fe 100644
--- a/drivers/net/qede/base/ecore_sriov.c
+++ b/drivers/net/qede/base/ecore_sriov.c
@@ -4077,7 +4077,7 @@ ecore_iov_execute_vf_flr_cleanup(struct ecore_hwfn *p_hwfn,
 		rc = ecore_iov_enable_vf_access(p_hwfn, p_ptt, p_vf);
 		if (rc) {
 			/* TODO - again, a mess... */
-			DP_ERR(p_hwfn, "Failed to re-enable VF[%d] acces\n",
+			DP_ERR(p_hwfn, "Failed to re-enable VF[%d] access\n",
 			       vfid);
 			return rc;
 		}
diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
index acddefa33d..79b8446f8e 100644
--- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
+++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
@@ -39,7 +39,7 @@ vhost_kernel_tap_set_offload(int fd, uint64_t features)
 
 	/* Check if our kernel supports TUNSETOFFLOAD */
 	if (ioctl(fd, TUNSETOFFLOAD, 0) != 0 && errno == EINVAL) {
-		PMD_DRV_LOG(ERR, "Kernel does't support TUNSETOFFLOAD\n");
+		PMD_DRV_LOG(ERR, "Kernel doesn't support TUNSETOFFLOAD\n");
 		return -ENOTSUP;
 	}
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about
  2020-10-29 13:36 [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about luca.boccassi
@ 2020-11-04 18:34 ` Thomas Monjalon
  2020-11-04 19:10   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-04 18:34 UTC (permalink / raw)
  To: luca.boccassi; +Cc: dev, ferruh.yigit, david.marchand, akhil.goyal

29/10/2020 14:36, luca.boccassi@gmail.com:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> Would be really great to hook up some spell checkers to the CI, so
> that I'm not the only one who gets nagged by automated tools :-)

There is a spell checker with checkpatch
and we are catching/fixing some of them while merging.

Applied, thank you for fixing more.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about
  2020-11-04 18:34 ` Thomas Monjalon
@ 2020-11-04 19:10   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-04 19:10 UTC (permalink / raw)
  To: luca.boccassi; +Cc: dev, ferruh.yigit, david.marchand, akhil.goyal

04/11/2020 19:34, Thomas Monjalon:
> 29/10/2020 14:36, luca.boccassi@gmail.com:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > 
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > Would be really great to hook up some spell checkers to the CI, so
> > that I'm not the only one who gets nagged by automated tools :-)
> 
> There is a spell checker with checkpatch
> and we are catching/fixing some of them while merging.
> 
> Applied, thank you for fixing more.

I did the boring work of finding each root cause:

    Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
    Fixes: 1265b5372d9d ("net/hns3: add some definitions for data structure and macro")
    Fixes: a85e378cc606 ("net/ixgbe/base: add debug traces")
    Fixes: 4861cde46116 ("i40e: new poll mode driver")
    Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
    Fixes: 86a2265e59d7 ("qede: add SRIOV support")
    Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set")
    Cc: stable@dpdk.org





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-04 19:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 13:36 [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about luca.boccassi
2020-11-04 18:34 ` Thomas Monjalon
2020-11-04 19:10   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).