DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] net/ixgbe: fix Rx errors statistics for UDP checksum
@ 2021-04-08  6:30 Haiyue Wang
  2021-04-08  9:02 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Haiyue Wang @ 2021-04-08  6:30 UTC (permalink / raw)
  To: dev
  Cc: pvalerio, david.marchand, qi.z.zhang, Haiyue Wang, stable,
	Jeff Guo, Harry van Haaren

Restrict the "remove l3_l4_xsum_errors from rx_errors" to 82599 only for
hardware errata.

Fixes: 256ff05a9cae ("ixgbe: fix Rx errors statistics for UDP checksum")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 4ee709b17..ff65145f5 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3344,6 +3344,13 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 			  hw_stats->fccrc +
 			  hw_stats->fclast;
 
+	/*
+	 * 82599 errata, UDP frames with a 0 checksum can be marked as checksum
+	 * errors.
+	 */
+	if (hw->mac.type != ixgbe_mac_82599EB)
+		stats->ierrors += hw_stats->xec;
+
 	/* Tx Errors */
 	stats->oerrors  = 0;
 	return 0;
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/ixgbe: fix Rx errors statistics for UDP checksum
  2021-04-08  6:30 [dpdk-dev] [PATCH v1] net/ixgbe: fix Rx errors statistics for UDP checksum Haiyue Wang
@ 2021-04-08  9:02 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2021-04-08  9:02 UTC (permalink / raw)
  To: Wang, Haiyue, dev
  Cc: pvalerio, david.marchand, stable, Guo, Jia, Van Haaren, Harry



> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, April 8, 2021 2:30 PM
> To: dev@dpdk.org
> Cc: pvalerio@redhat.com; david.marchand@redhat.com; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> stable@dpdk.org; Guo, Jia <jia.guo@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Subject: [PATCH v1] net/ixgbe: fix Rx errors statistics for UDP checksum
> 
> Restrict the "remove l3_l4_xsum_errors from rx_errors" to 82599 only for
> hardware errata.
> 
> Fixes: 256ff05a9cae ("ixgbe: fix Rx errors statistics for UDP checksum")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-08  9:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08  6:30 [dpdk-dev] [PATCH v1] net/ixgbe: fix Rx errors statistics for UDP checksum Haiyue Wang
2021-04-08  9:02 ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).