DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, bluca@debian.org,
	dmitry.kozliuk@gmail.com, olivier.matz@6wind.com,
	Gabriel Ganne <gabriel.ganne@6wind.com>,
	stable@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>,
	Luca Boccassi <luca.boccassi@gmail.com>,
	Keith Wiles <keith.wiles@intel.com>
Subject: [dpdk-dev] [PATCH v5] build: remove redundant libpcap link
Date: Fri,  9 Apr 2021 14:25:51 +0200	[thread overview]
Message-ID: <20210409122551.265939-1-thomas@monjalon.net> (raw)
In-Reply-To: <20210409083927.8345-1-gabriel.ganne@6wind.com>

From: Gabriel Ganne <gabriel.ganne@6wind.com>

The pcap PMD and the librte_port both declare their dependency to libpcap
with a line "ext_deps += pcap_dep".
Then meson automatically adds this dependency to the pkg-config file
in the "Requires.private" section for static builds.

The additional update of dpdk_extra_ldflags was adding the dependency
in the "Libs.private" section of the pkg-config, that is unnecessary.

Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson")
Fixes: 268fa581b1ff ("port: fix pcap support with meson")
Cc: stable@dpdk.org

Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
I have a doubt whether this option is really always useless.
In the case of an old pcap (<1.9) without pkg-config support,
and with the minimum meson supported (0.47.1),
are we sure the generated pkg-config file will include -lpcap?
 config/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config/meson.build b/config/meson.build
index 66a2edcc47..95777cf331 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -183,7 +183,6 @@ if not pcap_dep.found()
 if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)
 	dpdk_conf.set('RTE_PORT_PCAP', 1)
-	dpdk_extra_ldflags += '-lpcap'
 # for clang 32-bit compiles we need libatomic for 64-bit atomic ops

  reply	other threads:[~2021-04-09 12:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 14:07 [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson Gabriel Ganne
2021-03-22 14:07 ` [dpdk-dev] [PATCH v2 3/3] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
2021-04-09  8:39   ` [dpdk-dev] [PATCH v4] " Gabriel Ganne
2021-04-09 12:25     ` Thomas Monjalon [this message]
2021-04-14  9:41       ` [dpdk-dev] [PATCH v5] build: remove redundant libpcap link Thomas Monjalon
2021-04-14 21:02         ` Dmitry Kozlyuk
2021-04-14 21:10           ` Thomas Monjalon
2023-07-16 17:19             ` Stephen Hemminger
2023-07-16 17:21     ` [dpdk-dev] [PATCH v4] meson: remove unnecessary explicit link to libpcap Stephen Hemminger
2021-03-22 16:04 ` [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson Nick Connolly
2021-03-22 22:18   ` Dmitry Kozlyuk
2021-03-23 13:35     ` Nick Connolly
2021-03-23 21:21       ` Dmitry Kozlyuk
2021-03-23 22:17         ` Nick Connolly
2021-03-24  6:35           ` Gabriel Ganne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409122551.265939-1-thomas@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=gabriel.ganne@6wind.com \
    --cc=harry.van.haaren@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=luca.boccassi@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=thierry.herbelot@6wind.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).