From: Tal Shnaiderman <talshn@nvidia.com> To: dev@dpdk.org Cc: thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, david.marchand@redhat.com, lucp.at.work@gmail.com, stable@dpdk.org Subject: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values Date: Sat, 10 Apr 2021 22:54:33 +0300 Message-ID: <20210410195433.13416-1-talshn@nvidia.com> (raw) The macro definitions of the following pthread functions return incorrect values from the inner function return code. while pthread_barrier_init, pthread_barrier_destroy and pthread_cancel return 0 in a case of success and non zero (errno) value otherwise the shimming functions InitializeSynchronizationBarrier, DeleteSynchronizationBarrier and TerminateThread return FALSE (0) in a case of failure and TRUE(1) in a case of success. This issue was undetected as none of the functions return codes was checked until such check was added in commit 34cc55cce6b1 ("eal: fix race in control thread creation") exposing the issue by failing pthread_barrier_init and rte_eal_init on Windows as a result. The fix aligned the return value of the 3 function with the expected pthread API return values. Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Fixes: 34cc55cce6b1 ("eal: fix race in control thread creation") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> --- lib/librte_eal/windows/include/pthread.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h index 9aeab1fa70..1939b0121c 100644 --- a/lib/librte_eal/windows/include/pthread.h +++ b/lib/librte_eal/windows/include/pthread.h @@ -35,12 +35,12 @@ typedef CRITICAL_SECTION pthread_mutex_t; typedef SYNCHRONIZATION_BARRIER pthread_barrier_t; #define pthread_barrier_init(barrier, attr, count) \ - InitializeSynchronizationBarrier(barrier, count, -1) + !InitializeSynchronizationBarrier(barrier, count, -1) #define pthread_barrier_wait(barrier) EnterSynchronizationBarrier(barrier, \ SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY) #define pthread_barrier_destroy(barrier) \ - DeleteSynchronizationBarrier(barrier) -#define pthread_cancel(thread) TerminateThread((HANDLE) thread, 0) + !DeleteSynchronizationBarrier(barrier) +#define pthread_cancel(thread) !TerminateThread((HANDLE) thread, 0) /* pthread function overrides */ #define pthread_self() \ -- 2.16.1.windows.4
next reply other threads:[~2021-04-10 19:55 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-10 19:54 Tal Shnaiderman [this message] 2021-04-11 21:00 ` Dmitry Kozlyuk 2021-04-12 7:59 ` Tal Shnaiderman 2021-04-12 8:25 ` Thomas Monjalon 2021-04-12 10:03 ` Dmitry Kozlyuk 2021-04-12 10:07 ` David Marchand 2021-04-12 10:26 ` Tal Shnaiderman 2021-04-12 10:37 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman 2021-04-12 20:38 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210410195433.13416-1-talshn@nvidia.com \ --to=talshn@nvidia.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=dmitrym@microsoft.com \ --cc=lucp.at.work@gmail.com \ --cc=navasile@linux.microsoft.com \ --cc=pallavi.kadam@intel.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git