DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/mvsam: fix capabilities for crypto algorithms
@ 2021-07-01  6:58 danat
  2021-07-07 15:38 ` Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: danat @ 2021-07-01  6:58 UTC (permalink / raw)
  To: gakhil; +Cc: dev, danat, lironh, michaelsh, stable

From: Michael Shamis <michaelsh@marvell.com>

Increased AAD max size up to 64B and allowed AAD increment step
1B according to EIP197 token HW limitation.
In addition, some capabilities were found incorrect due to
running FIPS tests. The patch fix the capabilities.

Fixes: 8a61c83af2f ("crypto/mrvl: add mrvl crypto driver")
Fixes: 2c22aa4f8f6 ("crypto/mvsam: update hash digest sizes")
Fixes: a84226fc055 ("crypto/mvsam: support HMAC SHA224")
Cc: stable@dpdk.org

Signed-off-by: Michael Shamis <michaelsh@marvell.com>
Reviewed-by: Liron Himi <lironh@marvell.com>
Tested-by: Liron Himi <lironh@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index e4dfda7fa..3cb7e3b9c 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -112,7 +112,7 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 28,
+					.min = 12,
 					.max = 28,
 					.increment = 0
 				},
@@ -233,7 +233,7 @@ static const struct rte_cryptodev_capabilities
 				},
 				.digest_size = {
 					.min = 12,
-					.max = 48,
+					.max = 64,
 					.increment = 4
 				},
 			}, }
@@ -253,7 +253,7 @@ static const struct rte_cryptodev_capabilities
 				},
 				.digest_size = {
 					.min = 12,
-					.max = 48,
+					.max = 64,
 					.increment = 0
 				},
 			}, }
@@ -337,9 +337,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.aad_size = {
-					.min = 8,
-					.max = 12,
-					.increment = 4
+					.min = 0,
+					.max = 64,
+					.increment = 1
 				},
 				.iv_size = {
 					.min = 12,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/mvsam: fix capabilities for crypto algorithms
  2021-07-01  6:58 [dpdk-dev] [PATCH] crypto/mvsam: fix capabilities for crypto algorithms danat
@ 2021-07-07 15:38 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2021-07-07 15:38 UTC (permalink / raw)
  To: Dana Vardi; +Cc: dev, Dana Vardi, Liron Himi, Michael Shamis, stable

> Increased AAD max size up to 64B and allowed AAD increment step
> 1B according to EIP197 token HW limitation.
> In addition, some capabilities were found incorrect due to
> running FIPS tests. The patch fix the capabilities.
> 
> Fixes: 8a61c83af2f ("crypto/mrvl: add mrvl crypto driver")
> Fixes: 2c22aa4f8f6 ("crypto/mvsam: update hash digest sizes")
> Fixes: a84226fc055 ("crypto/mvsam: support HMAC SHA224")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Michael Shamis <michaelsh@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-07 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01  6:58 [dpdk-dev] [PATCH] crypto/mvsam: fix capabilities for crypto algorithms danat
2021-07-07 15:38 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).