* [dpdk-dev] [PATCH] ring: fix size of name array in ring structure
@ 2021-10-14 20:55 Honnappa Nagarahalli
2021-10-18 14:54 ` Honnappa Nagarahalli
2021-10-20 23:06 ` Ananyev, Konstantin
0 siblings, 2 replies; 5+ messages in thread
From: Honnappa Nagarahalli @ 2021-10-14 20:55 UTC (permalink / raw)
To: dev, honnappa.nagarahalli, andrew.rybchenko, konstantin.ananyev
Cc: nd, zoltan.kiss
Use correct define for the name array size. The change breaks ABI and
hence cannot be backported to stable branches.
Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
Cc: zoltan.kiss@schaman.hu
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
lib/ring/rte_ring_core.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h
index 31f7200fa9..46ad584f9c 100644
--- a/lib/ring/rte_ring_core.h
+++ b/lib/ring/rte_ring_core.h
@@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
* a problem.
*/
struct rte_ring {
- /*
- * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
- * compatibility requirements, it could be changed to RTE_RING_NAMESIZE
- * next time the ABI changes
- */
- char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
+ char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
/**< Name of the ring. */
int flags; /**< Flags supplied at creation. */
const struct rte_memzone *memzone;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure
2021-10-14 20:55 [dpdk-dev] [PATCH] ring: fix size of name array in ring structure Honnappa Nagarahalli
@ 2021-10-18 14:54 ` Honnappa Nagarahalli
2021-10-19 7:01 ` Tu, Lijuan
2021-10-20 23:06 ` Ananyev, Konstantin
1 sibling, 1 reply; 5+ messages in thread
From: Honnappa Nagarahalli @ 2021-10-18 14:54 UTC (permalink / raw)
To: Honnappa Nagarahalli, dev, andrew.rybchenko, konstantin.ananyev
Cc: nd, zoltan.kiss, Lijuan Tu, nd
This patch has a CI failure in DTS in test_scatter_mbuf_2048 for Fortville_Spirit NIC. I am not sure how this change is related to the failure. The log is as follows:
TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: 'packet receive error'
Has anyone seen this error? Is this a known issue?
Thanks,
Honnappa
> -----Original Message-----
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Sent: Thursday, October 14, 2021 3:56 PM
> To: dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; andrew.rybchenko@oktetlabs.ru;
> konstantin.ananyev@intel.com
> Cc: nd <nd@arm.com>; zoltan.kiss@schaman.hu
> Subject: [PATCH] ring: fix size of name array in ring structure
>
> Use correct define for the name array size. The change breaks ABI and hence
> cannot be backported to stable branches.
>
> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
> Cc: zoltan.kiss@schaman.hu
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/ring/rte_ring_core.h | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index
> 31f7200fa9..46ad584f9c 100644
> --- a/lib/ring/rte_ring_core.h
> +++ b/lib/ring/rte_ring_core.h
> @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
> * a problem.
> */
> struct rte_ring {
> - /*
> - * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
> - * compatibility requirements, it could be changed to
> RTE_RING_NAMESIZE
> - * next time the ABI changes
> - */
> - char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
> + char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
> /**< Name of the ring. */
> int flags; /**< Flags supplied at creation. */
> const struct rte_memzone *memzone;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure
2021-10-18 14:54 ` Honnappa Nagarahalli
@ 2021-10-19 7:01 ` Tu, Lijuan
0 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2021-10-19 7:01 UTC (permalink / raw)
To: Honnappa Nagarahalli, dev, andrew.rybchenko, Ananyev, Konstantin,
ci, Lincoln Lavoie, dpdklab
Cc: nd, zoltan.kiss, nd
I saw a lot of patches failed on test_scatter_mbuf_2048, the case could be passed in intel lab.
This is maintained by UNL guys.
+ unl.
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: 2021年10月18日 22:54
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; dev@dpdk.org;
> andrew.rybchenko@oktetlabs.ru; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: nd <nd@arm.com>; zoltan.kiss@schaman.hu; Tu, Lijuan
> <lijuan.tu@intel.com>; nd <nd@arm.com>
> Subject: RE: [PATCH] ring: fix size of name array in ring structure
>
> This patch has a CI failure in DTS in test_scatter_mbuf_2048 for Fortville_Spirit
> NIC. I am not sure how this change is related to the failure. The log is as follows:
>
> TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: 'packet receive
> error'
>
> Has anyone seen this error? Is this a known issue?
>
> Thanks,
> Honnappa
>
> > -----Original Message-----
> > From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Sent: Thursday, October 14, 2021 3:56 PM
> > To: dev@dpdk.org; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
> > andrew.rybchenko@oktetlabs.ru; konstantin.ananyev@intel.com
> > Cc: nd <nd@arm.com>; zoltan.kiss@schaman.hu
> > Subject: [PATCH] ring: fix size of name array in ring structure
> >
> > Use correct define for the name array size. The change breaks ABI and
> > hence cannot be backported to stable branches.
> >
> > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data
> > types")
> > Cc: zoltan.kiss@schaman.hu
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
> > lib/ring/rte_ring_core.h | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index
> > 31f7200fa9..46ad584f9c 100644
> > --- a/lib/ring/rte_ring_core.h
> > +++ b/lib/ring/rte_ring_core.h
> > @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
> > * a problem.
> > */
> > struct rte_ring {
> > - /*
> > - * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
> > - * compatibility requirements, it could be changed to
> > RTE_RING_NAMESIZE
> > - * next time the ABI changes
> > - */
> > - char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
> > + char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
> > /**< Name of the ring. */
> > int flags; /**< Flags supplied at creation. */
> > const struct rte_memzone *memzone;
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure
2021-10-14 20:55 [dpdk-dev] [PATCH] ring: fix size of name array in ring structure Honnappa Nagarahalli
2021-10-18 14:54 ` Honnappa Nagarahalli
@ 2021-10-20 23:06 ` Ananyev, Konstantin
2021-10-21 7:35 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: Ananyev, Konstantin @ 2021-10-20 23:06 UTC (permalink / raw)
To: Honnappa Nagarahalli, dev, andrew.rybchenko; +Cc: nd, zoltan.kiss
>
> Use correct define for the name array size. The change breaks ABI and
> hence cannot be backported to stable branches.
>
> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
> Cc: zoltan.kiss@schaman.hu
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/ring/rte_ring_core.h | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h
> index 31f7200fa9..46ad584f9c 100644
> --- a/lib/ring/rte_ring_core.h
> +++ b/lib/ring/rte_ring_core.h
> @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
> * a problem.
> */
> struct rte_ring {
> - /*
> - * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
> - * compatibility requirements, it could be changed to RTE_RING_NAMESIZE
> - * next time the ABI changes
> - */
> - char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
> + char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
> /**< Name of the ring. */
> int flags; /**< Flags supplied at creation. */
> const struct rte_memzone *memzone;
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure
2021-10-20 23:06 ` Ananyev, Konstantin
@ 2021-10-21 7:35 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-10-21 7:35 UTC (permalink / raw)
To: Ananyev, Konstantin, Honnappa Nagarahalli
Cc: dev, andrew.rybchenko, nd, zoltan.kiss
On Thu, Oct 21, 2021 at 1:07 AM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
> > Use correct define for the name array size. The change breaks ABI and
> > hence cannot be backported to stable branches.
> >
> > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-21 7:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14 20:55 [dpdk-dev] [PATCH] ring: fix size of name array in ring structure Honnappa Nagarahalli
2021-10-18 14:54 ` Honnappa Nagarahalli
2021-10-19 7:01 ` Tu, Lijuan
2021-10-20 23:06 ` Ananyev, Konstantin
2021-10-21 7:35 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).