DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pankaj Gupta <pagupta@vmware.com>
To: jbehrens@vmware.com
Cc: dev@dpdk.org, pagupta@vmware.com
Subject: [PATCH v6 1/9] net/vmxnet3: add version 5 support
Date: Tue, 24 May 2022 17:40:20 -0700	[thread overview]
Message-ID: <20220525004028.24938-2-pagupta@vmware.com> (raw)
In-Reply-To: <20220525004028.24938-1-pagupta@vmware.com>

Add VMXNET3 v5 support.

Tested, using testpmd, for different hardware versions on ESXi 7.0
Update 2.

Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
Reviewed-by: Jochen Behrens <jbehrens@vmware.com>
---
 doc/guides/rel_notes/release_21_08.rst | 2 ++
 drivers/net/vmxnet3/vmxnet3_ethdev.c   | 7 +++++--
 drivers/net/vmxnet3/vmxnet3_ethdev.h   | 2 ++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst
index ac1c081903..cc472d7a05 100644
--- a/doc/guides/rel_notes/release_21_08.rst
+++ b/doc/guides/rel_notes/release_21_08.rst
@@ -129,6 +129,8 @@ New Features
   Updated testpmd application to output log errors and warnings to stderr
   instead of stdout.
 
+* **Added vmxnet3 version 5 support.**
+
 
 API Changes
 -----------
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index d1ef1cad08..a7e1e5fef5 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -316,9 +316,12 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
 
 	/* Check h/w version compatibility with driver. */
 	ver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_VRRS);
-	PMD_INIT_LOG(DEBUG, "Hardware version : %d", ver);
 
-	if (ver & (1 << VMXNET3_REV_4)) {
+	if (ver & (1 << VMXNET3_REV_5)) {
+		VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS,
+				       1 << VMXNET3_REV_5);
+		hw->version = VMXNET3_REV_5 + 1;
+	} else if (ver & (1 << VMXNET3_REV_4)) {
 		VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS,
 				       1 << VMXNET3_REV_4);
 		hw->version = VMXNET3_REV_4 + 1;
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
index ef858ac951..7ec3b2e1f0 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
@@ -124,11 +124,13 @@ struct vmxnet3_hw {
 	UPT1_RxStats          snapshot_rx_stats[VMXNET3_MAX_RX_QUEUES];
 };
 
+#define VMXNET3_REV_5		4		/* Vmxnet3 Rev. 5 */
 #define VMXNET3_REV_4		3		/* Vmxnet3 Rev. 4 */
 #define VMXNET3_REV_3		2		/* Vmxnet3 Rev. 3 */
 #define VMXNET3_REV_2		1		/* Vmxnet3 Rev. 2 */
 #define VMXNET3_REV_1		0		/* Vmxnet3 Rev. 1 */
 
+#define VMXNET3_VERSION_GE_5(hw) ((hw)->version >= VMXNET3_REV_5 + 1)
 #define VMXNET3_VERSION_GE_4(hw) ((hw)->version >= VMXNET3_REV_4 + 1)
 #define VMXNET3_VERSION_GE_3(hw) ((hw)->version >= VMXNET3_REV_3 + 1)
 #define VMXNET3_VERSION_GE_2(hw) ((hw)->version >= VMXNET3_REV_2 + 1)
-- 
2.17.1


  reply	other threads:[~2022-05-25  0:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  0:40 [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Pankaj Gupta
2022-05-25  0:40 ` Pankaj Gupta [this message]
2022-05-25  0:40 ` [PATCH v6 2/9] net/vmxnet3: implement RETA query and RETA update Pankaj Gupta
2022-05-25  0:40 ` [PATCH v6 3/9] net/vmxnet3: add Rx queue usage count utility Pankaj Gupta
2022-05-25  0:40 ` [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order Pankaj Gupta
2022-05-25  0:40 ` [PATCH v6 5/9] net/vmxnet3: report HW version on FW version get Pankaj Gupta
2022-05-25  0:40 ` [PATCH v6 6/9] net/vmxnet3: add version 6 support Pankaj Gupta
2022-05-25  8:45   ` Andrew Rybchenko
2022-05-25 17:13     ` Pankaj Gupta
2022-05-31 12:54       ` Andrew Rybchenko
2022-05-25  0:40 ` [PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info Pankaj Gupta
2022-05-25  0:40 ` [PATCH v6 8/9] net/vmxnet3: set packet type for fragmented packet Pankaj Gupta
2022-05-25  0:40 ` [PATCH v6 9/9] net/vmxnet3: fix merge error in Rx data ring initialization Pankaj Gupta
2022-05-31 13:40 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-31 13:41   ` Andrew Rybchenko
  -- strict thread matches above, loose matches on Subject: below --
2022-05-03  4:22 [PATCH 0/8] vmxnet3 version V5 and V6 Pankaj Gupta
2022-05-19  8:04 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-19  8:04   ` [PATCH v6 1/9] net/vmxnet3: add version 5 support Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525004028.24938-2-pagupta@vmware.com \
    --to=pagupta@vmware.com \
    --cc=dev@dpdk.org \
    --cc=jbehrens@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).