Re: [PATCH v6 6/9] net/vmxnet3: add version 6 support

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

Hi, Pankaj,

On 5/25/22 03:40, Pankaj Gupta wrote:
> VMXNET3 version 6 supports some new features, including but not limited to:
> - Increased max MTU up to 9190
> - Increased max number of queues, both for Rx and Tx
> - Removes power-of-two limitations
> - Extended interrupt structures, required implementation for
>     additional number of queues
> 
> Tested, using testpmd, for different hardware versions on ESXi 7.0
> Update 2.
> 
> Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
> Reviewed-by: Jochen Behrens <jbehrens@vmware.com>
> ---
>   doc/guides/rel_notes/release_21_08.rst  |   8 +
>   drivers/net/vmxnet3/base/vmxnet3_defs.h |  73 ++++++--
>   drivers/net/vmxnet3/vmxnet3_ethdev.c    | 220 +++++++++++++++++-------
>   drivers/net/vmxnet3/vmxnet3_ethdev.h    |  10 +-
>   drivers/net/vmxnet3/vmxnet3_rxtx.c      |   2 +-
>   5 files changed, 234 insertions(+), 79 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst
> index 4027bd4390..810da2cc1f 100644
> --- a/doc/guides/rel_notes/release_21_08.rst
> +++ b/doc/guides/rel_notes/release_21_08.rst
> @@ -133,6 +133,14 @@ New Features
>   
>   * **Added RETA query and RETA update support for vmxnet3.**
>   
> +* **Added vmxnet3 version 6 supports with some new features.**
> +
> +  * Increased max MTU up to 9190
> +  * Increased max number of queues, both for Rx and Tx
> +  * Removes power-of-two limitations
> +  * Extended interrupt structures, required implementation for additional number
> +of queues
> +

I've realized that I don't understand the last bullet. Could
you clarify it, please, and I'll update it on applying.

Also, JFYI, you should update release notes for 22.07 release, not old 
release notes for 21.08. Don't worry about it now -
I'll move and rephrase it on applying.

Thanks,
Andrew.