DPDK patches and discussions
 help / color / mirror / Atom feed
From: Timothy McDaniel <timothy.mcdaniel@intel.com>
To: jerinj@marvell.com
Cc: dev@dpdk.org
Subject: [PATCH v2] event/dlb2: fix advertized capabilities
Date: Fri, 10 Jun 2022 13:36:31 -0500	[thread overview]
Message-ID: <20220610183631.3093650-1-timothy.mcdaniel@intel.com> (raw)
In-Reply-To: <20220606154044.1225683-1-timothy.mcdaniel@intel.com>

This commit corrects the advertized capabilities reported by the DLB2 PMD.

Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the
DLB2 hardware does not support such capability. This commit removes that
feature from the reported capabilities feature set.

Additionally, two capabilities that DLB2 does support were not being
reported in the capabilities feature set. This commit adds those.

    RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of
    setting up the link between multiple queues and a single port. If the
    flag is not set, the eventdev can only map a single queue to each
    port or map a single queue to many port

    RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of
    configuring the queue/port link at runtime. If the flag is not set,
    the eventdev queue/port link is only can be configured during
    initialization

Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated
to match the capabilities actually reported by the PMD.

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
===

Changes since V1;
1) reorder capabilities flags to match the order that they appear in
in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details
---
 doc/guides/eventdevs/features/dlb2.ini | 3 ++-
 drivers/event/dlb2/dlb2.c              | 9 +++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini
index 29747b1c26..48a2a18aff 100644
--- a/doc/guides/eventdevs/features/dlb2.ini
+++ b/doc/guides/eventdevs/features/dlb2.ini
@@ -4,12 +4,13 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Scheduling Features]
-queue_qos                  = Y
 event_qos                  = Y
 distributed_sched          = Y
 queue_all_types            = Y
 burst_mode                 = Y
 implicit_release_disable   = Y
+runtime_port_link          = Y
+multiple_queue_port        = Y
 maintenance_free           = Y
 
 [Eth Rx adapter Features]
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 3641ed2942..bc4e705e0b 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
 	.max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
 	.max_single_link_event_port_queue_pairs =
 		DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
-	.event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
-			  RTE_EVENT_DEV_CAP_EVENT_QOS |
-			  RTE_EVENT_DEV_CAP_BURST_MODE |
+	.event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
 			  RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
-			  RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
 			  RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
+			  RTE_EVENT_DEV_CAP_BURST_MODE |
+			  RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
+			  RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
+			  RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
 			  RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
 };
 
-- 
2.25.1


  parent reply	other threads:[~2022-06-10 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 15:40 [PATCH] " Timothy McDaniel
2022-06-09 17:05 ` Jerin Jacob
2022-06-09 18:02   ` McDaniel, Timothy
2022-06-10 18:36 ` Timothy McDaniel [this message]
2022-06-13  6:21   ` [PATCH v2] " Jerin Jacob
2022-06-13 18:19 ` [PATCH v3] " Timothy McDaniel
2022-06-14  9:26   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610183631.3093650-1-timothy.mcdaniel@intel.com \
    --to=timothy.mcdaniel@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).