Re: [PATCH v2] event/dlb2: fix advertized capabilities

[Jerin Jacob <jerinjacobk@gmail.com>]

On Sat, Jun 11, 2022 at 12:06 AM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> This commit corrects the advertized capabilities reported by the DLB2 PMD.
>
> Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the
> DLB2 hardware does not support such capability. This commit removes that
> feature from the reported capabilities feature set.
>
> Additionally, two capabilities that DLB2 does support were not being
> reported in the capabilities feature set. This commit adds those.
>
>     RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of
>     setting up the link between multiple queues and a single port. If the
>     flag is not set, the eventdev can only map a single queue to each
>     port or map a single queue to many port
>
>     RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of
>     configuring the queue/port link at runtime. If the flag is not set,
>     the eventdev queue/port link is only can be configured during
>     initialization
>
> Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated
> to match the capabilities actually reported by the PMD.
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>

Please fix
[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
Missing 'Fixes' tag:
        event/dlb2: fix advertized capabilities

Invalid patch(es) found - checked 1 patch

> ===
>
> Changes since V1;
> 1) reorder capabilities flags to match the order that they appear in
> in the default.ini file
> 2) update the dlb2.ini file with the new set of features supported by DLB2
> 3) expanded the commit message to provide additional details
> ---
>  doc/guides/eventdevs/features/dlb2.ini | 3 ++-
>  drivers/event/dlb2/dlb2.c              | 9 +++++----
>  2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini
> index 29747b1c26..48a2a18aff 100644
> --- a/doc/guides/eventdevs/features/dlb2.ini
> +++ b/doc/guides/eventdevs/features/dlb2.ini
> @@ -4,12 +4,13 @@
>  ; Refer to default.ini for the full list of available PMD features.
>  ;
>  [Scheduling Features]
> -queue_qos                  = Y
>  event_qos                  = Y
>  distributed_sched          = Y
>  queue_all_types            = Y
>  burst_mode                 = Y
>  implicit_release_disable   = Y
> +runtime_port_link          = Y
> +multiple_queue_port        = Y
>  maintenance_free           = Y
>
>  [Eth Rx adapter Features]
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 3641ed2942..bc4e705e0b 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
>         .max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
>         .max_single_link_event_port_queue_pairs =
>                 DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
> -       .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
> -                         RTE_EVENT_DEV_CAP_EVENT_QOS |
> -                         RTE_EVENT_DEV_CAP_BURST_MODE |
> +       .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
>                           RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
> -                         RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
>                           RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
> +                         RTE_EVENT_DEV_CAP_BURST_MODE |
> +                         RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> +                         RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
> +                         RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
>                           RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
>  };
>
> --
> 2.25.1
>