* [PATCH v2 1/4] event/dlb2: remove cos from port probing
[not found] <20221012143247.3239356-1-abdullah.sevincer@intel.com, shivani.doneria@intel.com>
@ 2022-10-12 23:50 ` Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 2/4] event/dlb2: add check valid producer coremask Abdullah Sevincer
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Abdullah Sevincer @ 2022-10-12 23:50 UTC (permalink / raw)
To: dev; +Cc: jerinj, Abdullah Sevincer
This commit removes cos (class of service)
from port probing criteria and applies enhancements
for selection of ports from best cos when default
cos (255) is used.
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
---
drivers/event/dlb2/dlb2.c | 5 +-
drivers/event/dlb2/dlb2_priv.h | 2 +-
drivers/event/dlb2/dlb2_user.h | 2 +-
drivers/event/dlb2/pf/base/dlb2_hw_types.h | 2 +-
drivers/event/dlb2/pf/base/dlb2_resource.c | 85 ++++++++++++++--------
5 files changed, 60 insertions(+), 36 deletions(-)
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 7fd89e940b..b52ce20a4e 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -180,11 +180,12 @@ dlb2_init_port_cos(struct dlb2_eventdev *dlb2, int *port_cos)
{
int q;
- for (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++)
+ for (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++) {
+ dlb2->ev_ports[q].cos_id = port_cos[q];
if (port_cos[q] != DLB2_COS_DEFAULT) {
- dlb2->ev_ports[q].cos_id = port_cos[q];
dlb2->cos_ports[port_cos[q]]++;
}
+ }
}
static void
diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h
index 9ef5bcb901..fca1720504 100644
--- a/drivers/event/dlb2/dlb2_priv.h
+++ b/drivers/event/dlb2/dlb2_priv.h
@@ -421,7 +421,7 @@ struct dlb2_config {
};
enum dlb2_cos {
- DLB2_COS_DEFAULT = -1,
+ DLB2_COS_DEFAULT = 255,
DLB2_COS_0 = 0,
DLB2_COS_1,
DLB2_COS_2,
diff --git a/drivers/event/dlb2/dlb2_user.h b/drivers/event/dlb2/dlb2_user.h
index 28c6aaaf43..8739e2a5ac 100644
--- a/drivers/event/dlb2/dlb2_user.h
+++ b/drivers/event/dlb2/dlb2_user.h
@@ -450,7 +450,7 @@ struct dlb2_create_dir_queue_args {
* - num_hist_list_entries: Number of history list entries. This must be
* greater than or equal cq_depth.
* - cos_id: class-of-service to allocate this port from. Must be between 0 and
- * 3, inclusive.
+ * 3, inclusive. Should be 255 if default.
* - cos_strict: If set, return an error if there are no available ports in the
* requested class-of-service. Else, allocate the port from a different
* class-of-service if the requested class has no available ports.
diff --git a/drivers/event/dlb2/pf/base/dlb2_hw_types.h b/drivers/event/dlb2/pf/base/dlb2_hw_types.h
index 87996ef621..be09363893 100644
--- a/drivers/event/dlb2/pf/base/dlb2_hw_types.h
+++ b/drivers/event/dlb2/pf/base/dlb2_hw_types.h
@@ -351,7 +351,7 @@ struct dlb2_hw {
int prod_core_list[RTE_MAX_LCORE];
u8 num_prod_cores;
int dir_pp_allocations[DLB2_MAX_NUM_DIR_PORTS_V2_5];
- int ldb_pp_allocations[DLB2_MAX_NUM_LDB_PORTS];
+ int ldb_pp_allocations[DLB2_MAX_NUM_LDB_PORTS + DLB2_NUM_COS_DOMAINS];
/* Virtualization */
int virt_mode;
diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c
index 280a8e51b1..3f36acb6a4 100644
--- a/drivers/event/dlb2/pf/base/dlb2_resource.c
+++ b/drivers/event/dlb2/pf/base/dlb2_resource.c
@@ -577,11 +577,14 @@ static int dlb2_attach_ldb_ports(struct dlb2_hw *hw,
/* Allocate num_ldb_ports from any class-of-service */
for (i = 0; i < args->num_ldb_ports; i++) {
for (j = 0; j < DLB2_NUM_COS_DOMAINS; j++) {
+ /* Allocate from best performing cos */
+ u32 cos_idx = j + DLB2_MAX_NUM_LDB_PORTS;
+ u32 cos_id = hw->ldb_pp_allocations[cos_idx];
ret = __dlb2_attach_ldb_ports(hw,
rsrcs,
domain,
1,
- j,
+ cos_id,
resp);
if (ret == 0)
break;
@@ -819,21 +822,29 @@ static int dlb2_pp_cycle_comp(const void *a, const void *b)
/* Probe producer ports from different CPU cores */
static void
-dlb2_get_pp_allocation(struct dlb2_hw *hw, int cpu, int port_type, int cos_id)
+dlb2_get_pp_allocation(struct dlb2_hw *hw, int cpu, int port_type)
{
+ struct dlb2_pp_thread_data dlb2_thread_data[DLB2_MAX_NUM_DIR_PORTS_V2_5];
struct dlb2_dev *dlb2_dev = container_of(hw, struct dlb2_dev, hw);
- int i, err, ver = DLB2_HW_DEVICE_FROM_PCI_ID(dlb2_dev->pdev);
+ struct dlb2_pp_thread_data cos_cycles[DLB2_NUM_COS_DOMAINS];
+ int ver = DLB2_HW_DEVICE_FROM_PCI_ID(dlb2_dev->pdev);
+ int num_ports_per_sort, num_ports, num_sort, i, err;
bool is_ldb = (port_type == DLB2_LDB_PORT);
- int num_ports = is_ldb ? DLB2_MAX_NUM_LDB_PORTS :
- DLB2_MAX_NUM_DIR_PORTS(ver);
- struct dlb2_pp_thread_data dlb2_thread_data[num_ports];
- int *port_allocations = is_ldb ? hw->ldb_pp_allocations :
- hw->dir_pp_allocations;
- int num_sort = is_ldb ? DLB2_NUM_COS_DOMAINS : 1;
- struct dlb2_pp_thread_data cos_cycles[num_sort];
- int num_ports_per_sort = num_ports / num_sort;
+ int *port_allocations;
pthread_t pthread;
+ if (is_ldb) {
+ port_allocations = hw->ldb_pp_allocations;
+ num_ports = DLB2_MAX_NUM_LDB_PORTS;
+ num_sort = DLB2_NUM_COS_DOMAINS;
+ } else {
+ port_allocations = hw->dir_pp_allocations;
+ num_ports = DLB2_MAX_NUM_DIR_PORTS(ver);
+ num_sort = 1;
+ }
+
+ num_ports_per_sort = num_ports / num_sort;
+
dlb2_dev->enqueue_four = dlb2_movdir64b;
DLB2_LOG_INFO(" for %s: cpu core used in pp profiling: %d\n",
@@ -841,8 +852,7 @@ dlb2_get_pp_allocation(struct dlb2_hw *hw, int cpu, int port_type, int cos_id)
memset(cos_cycles, 0, num_sort * sizeof(struct dlb2_pp_thread_data));
for (i = 0; i < num_ports; i++) {
- int cos = is_ldb ? (i >> DLB2_NUM_COS_DOMAINS) : 0;
-
+ int cos = (i >> DLB2_NUM_COS_DOMAINS) % DLB2_NUM_COS_DOMAINS;
dlb2_thread_data[i].is_ldb = is_ldb;
dlb2_thread_data[i].pp = i;
dlb2_thread_data[i].cycles = 0;
@@ -861,12 +871,17 @@ dlb2_get_pp_allocation(struct dlb2_hw *hw, int cpu, int port_type, int cos_id)
DLB2_LOG_ERR(": thread join failed! err=%d", err);
return;
}
- cos_cycles[cos].cycles += dlb2_thread_data[i].cycles;
+
+ if (is_ldb)
+ cos_cycles[cos].cycles += dlb2_thread_data[i].cycles;
if ((i + 1) % num_ports_per_sort == 0) {
- int index = cos * num_ports_per_sort;
+ int index = 0;
- cos_cycles[cos].pp = index;
+ if (is_ldb) {
+ cos_cycles[cos].pp = cos;
+ index = cos * num_ports_per_sort;
+ }
/*
* For LDB ports first sort with in a cos. Later sort
* the best cos based on total cycles for the cos.
@@ -880,21 +895,23 @@ dlb2_get_pp_allocation(struct dlb2_hw *hw, int cpu, int port_type, int cos_id)
}
/*
- * Re-arrange best ports by cos if default cos is used.
+ * Sort by best cos aggregated over all ports per cos
+ * Note: After DLB2_MAX_NUM_LDB_PORTS sorted cos is stored and so'pp'
+ * is cos_id and not port id.
*/
- if (is_ldb && cos_id == DLB2_COS_DEFAULT)
- qsort(cos_cycles, num_sort,
- sizeof(struct dlb2_pp_thread_data),
+ if (is_ldb) {
+ qsort(cos_cycles, num_sort, sizeof(struct dlb2_pp_thread_data),
dlb2_pp_cycle_comp);
+ for (i = 0; i < DLB2_NUM_COS_DOMAINS; i++)
+ port_allocations[i + DLB2_MAX_NUM_LDB_PORTS] = cos_cycles[i].pp;
+ }
for (i = 0; i < num_ports; i++) {
- int start = is_ldb ? cos_cycles[i / num_ports_per_sort].pp : 0;
- int index = i % num_ports_per_sort;
-
- port_allocations[i] = dlb2_thread_data[start + index].pp;
+ port_allocations[i] = dlb2_thread_data[i].pp;
DLB2_LOG_INFO(": pp %d cycles %d", port_allocations[i],
- dlb2_thread_data[start + index].cycles);
+ dlb2_thread_data[i].cycles);
}
+
}
int
@@ -903,11 +920,10 @@ dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)
const struct dlb2_devargs *args = (const struct dlb2_devargs *)probe_args;
const char *mask = NULL;
int cpu = 0, cnt = 0, cores[RTE_MAX_LCORE];
- int i, cos_id = DLB2_COS_DEFAULT;
+ int i;
if (args) {
mask = (const char *)args->producer_coremask;
- cos_id = args->cos_id;
}
if (mask && rte_eal_parse_coremask(mask, cores)) {
@@ -942,8 +958,8 @@ dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)
if (hw->num_prod_cores)
cpu = hw->prod_core_list[0];
- dlb2_get_pp_allocation(hw, cpu, DLB2_LDB_PORT, cos_id);
- dlb2_get_pp_allocation(hw, cpu, DLB2_DIR_PORT, DLB2_COS_DEFAULT);
+ dlb2_get_pp_allocation(hw, cpu, DLB2_LDB_PORT);
+ dlb2_get_pp_allocation(hw, cpu, DLB2_DIR_PORT);
return 0;
}
@@ -4543,7 +4559,8 @@ dlb2_verify_create_ldb_port_args(struct dlb2_hw *hw,
return -EINVAL;
}
- if (args->cos_id >= DLB2_NUM_COS_DOMAINS) {
+ if (args->cos_id >= DLB2_NUM_COS_DOMAINS &&
+ (args->cos_id != DLB2_COS_DEFAULT || args->cos_strict)) {
resp->status = DLB2_ST_INVALID_COS_ID;
return -EINVAL;
}
@@ -4554,7 +4571,13 @@ dlb2_verify_create_ldb_port_args(struct dlb2_hw *hw,
typeof(*port));
} else {
for (i = 0; i < DLB2_NUM_COS_DOMAINS; i++) {
- id = (args->cos_id + i) % DLB2_NUM_COS_DOMAINS;
+ if (args->cos_id == DLB2_COS_DEFAULT) {
+ /* Allocate from best performing cos */
+ u32 cos_idx = i + DLB2_MAX_NUM_LDB_PORTS;
+ id = hw->ldb_pp_allocations[cos_idx];
+ } else {
+ id = (args->cos_id + i) % DLB2_NUM_COS_DOMAINS;
+ }
port = DLB2_DOM_LIST_HEAD(domain->avail_ldb_ports[id],
typeof(*port));
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/4] event/dlb2: add check valid producer coremask
2022-10-12 23:50 ` [PATCH v2 1/4] event/dlb2: remove cos from port probing Abdullah Sevincer
@ 2022-10-12 23:50 ` Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 3/4] event/dlb2: remove cos from devargs Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 4/4] event/dlb2: fix port cos override calculation Abdullah Sevincer
2 siblings, 0 replies; 5+ messages in thread
From: Abdullah Sevincer @ 2022-10-12 23:50 UTC (permalink / raw)
To: dev; +Cc: jerinj, Abdullah Sevincer
This commit add checks during port probing
for validating producer core masks if
they are a subset of eal coremask. Error
is returned if producer coremask is not a subset
of eal coremask.
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
---
drivers/event/dlb2/pf/base/dlb2_resource.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c
index 3f36acb6a4..dd8390a013 100644
--- a/drivers/event/dlb2/pf/base/dlb2_resource.c
+++ b/drivers/event/dlb2/pf/base/dlb2_resource.c
@@ -918,9 +918,8 @@ int
dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)
{
const struct dlb2_devargs *args = (const struct dlb2_devargs *)probe_args;
- const char *mask = NULL;
- int cpu = 0, cnt = 0, cores[RTE_MAX_LCORE];
- int i;
+ const char *mask = args ? args->producer_coremask : NULL;
+ int cpu = 0, cnt = 0, cores[RTE_MAX_LCORE], i;
if (args) {
mask = (const char *)args->producer_coremask;
@@ -933,16 +932,17 @@ dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)
hw->num_prod_cores = 0;
for (i = 0; i < RTE_MAX_LCORE; i++) {
+ bool is_pcore = (mask && cores[i] != -1);
+
if (rte_lcore_is_enabled(i)) {
- if (mask) {
+ if (is_pcore) {
/*
* Populate the producer cores from parsed
* coremask
*/
- if (cores[i] != -1) {
- hw->prod_core_list[cores[i]] = i;
- hw->num_prod_cores++;
- }
+ hw->prod_core_list[cores[i]] = i;
+ hw->num_prod_cores++;
+
} else if ((++cnt == DLB2_EAL_PROBE_CORE ||
rte_lcore_count() < DLB2_EAL_PROBE_CORE)) {
/*
@@ -952,7 +952,12 @@ dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)
cpu = i;
break;
}
+ } else if (is_pcore) {
+ DLB2_LOG_ERR("Producer coremask(%s) must be a subset of EAL coremask",
+ mask);
+ return -1;
}
+
}
/* Use the first core in producer coremask to probe */
if (hw->num_prod_cores)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 3/4] event/dlb2: remove cos from devargs
2022-10-12 23:50 ` [PATCH v2 1/4] event/dlb2: remove cos from port probing Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 2/4] event/dlb2: add check valid producer coremask Abdullah Sevincer
@ 2022-10-12 23:50 ` Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 4/4] event/dlb2: fix port cos override calculation Abdullah Sevincer
2 siblings, 0 replies; 5+ messages in thread
From: Abdullah Sevincer @ 2022-10-12 23:50 UTC (permalink / raw)
To: dev; +Cc: jerinj, Abdullah Sevincer
This commit removes the cos argument from devargs struct.
Since cos is now per port specific only and supported through
port_cos in dev_args, there is no need to
to have a cos argument in dev_args struct.
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
---
drivers/event/dlb2/dlb2.c | 1 -
drivers/event/dlb2/dlb2_priv.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index b52ce20a4e..b200c9484e 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -4763,7 +4763,6 @@ dlb2_parse_params(const char *params,
DLB2_NUM_DIR_CREDITS,
DEV_ID_ARG,
DLB2_QID_DEPTH_THRESH_ARG,
- DLB2_COS_ARG,
DLB2_POLL_INTERVAL_ARG,
DLB2_SW_CREDIT_QUANTA_ARG,
DLB2_HW_CREDIT_QUANTA_ARG,
diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h
index fca1720504..085dcf9bdc 100644
--- a/drivers/event/dlb2/dlb2_priv.h
+++ b/drivers/event/dlb2/dlb2_priv.h
@@ -40,7 +40,6 @@
#define DLB2_NUM_DIR_CREDITS "num_dir_credits"
#define DEV_ID_ARG "dev_id"
#define DLB2_QID_DEPTH_THRESH_ARG "qid_depth_thresh"
-#define DLB2_COS_ARG "cos"
#define DLB2_POLL_INTERVAL_ARG "poll_interval"
#define DLB2_SW_CREDIT_QUANTA_ARG "sw_credit_quanta"
#define DLB2_HW_CREDIT_QUANTA_ARG "hw_credit_quanta"
@@ -661,7 +660,6 @@ struct dlb2_devargs {
int num_dir_credits_override;
int dev_id;
struct dlb2_qid_depth_thresholds qid_depth_thresholds;
- enum dlb2_cos cos_id;
int poll_interval;
int sw_credit_quanta;
int hw_credit_quanta;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 4/4] event/dlb2: fix port cos override calculation
2022-10-12 23:50 ` [PATCH v2 1/4] event/dlb2: remove cos from port probing Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 2/4] event/dlb2: add check valid producer coremask Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 3/4] event/dlb2: remove cos from devargs Abdullah Sevincer
@ 2022-10-12 23:50 ` Abdullah Sevincer
2022-10-13 6:44 ` Jerin Jacob
2 siblings, 1 reply; 5+ messages in thread
From: Abdullah Sevincer @ 2022-10-12 23:50 UTC (permalink / raw)
To: dev; +Cc: jerinj, Abdullah Sevincer, stable
This commit fixes a calculation error
of total number of ldb ports during port cos
override from dlb2 event structure.
Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS")
Cc: stable@dpdk.org
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
---
drivers/event/dlb2/dlb2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index b200c9484e..02f0e57208 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -848,10 +848,11 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2,
}
cfg->cos_strict = 0; /* Best effort */
- cfg->num_cos_ldb_ports[0] = resources_asked->num_ldb_ports - cos_ports;
+ cfg->num_cos_ldb_ports[0] = dlb2->cos_ports[0];
cfg->num_cos_ldb_ports[1] = dlb2->cos_ports[1];
cfg->num_cos_ldb_ports[2] = dlb2->cos_ports[2];
cfg->num_cos_ldb_ports[3] = dlb2->cos_ports[3];
+ cfg->num_ldb_ports = resources_asked->num_ldb_ports - cos_ports;
if (device_version == DLB2_HW_V2)
cfg->num_ldb_credits = resources_asked->num_ldb_credits;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 4/4] event/dlb2: fix port cos override calculation
2022-10-12 23:50 ` [PATCH v2 4/4] event/dlb2: fix port cos override calculation Abdullah Sevincer
@ 2022-10-13 6:44 ` Jerin Jacob
0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2022-10-13 6:44 UTC (permalink / raw)
To: Abdullah Sevincer; +Cc: dev, jerinj, stable
On Thu, Oct 13, 2022 at 5:21 AM Abdullah Sevincer
<abdullah.sevincer@intel.com> wrote:
>
> This commit fixes a calculation error
> of total number of ldb ports during port cos
> override from dlb2 event structure.
>
> Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
Series applied to dpdk-next-net-eventdev/for-main. Thanks
I have updated the git commit log. Please check changes and try to do
similar for new patches
commit fa8dd9829c9e83154be8b9c8da65b4698e6a898b (HEAD -> for-main)
Author: Abdullah Sevincer <abdullah.sevincer@intel.com>
Date: Wed Oct 12 18:50:37 2022 -0500
event/dlb2: fix port COS override calculation
Fix the calculation error of the total number of LDB ports
during port COS override from dlb2 event structure.
Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS")
Cc: stable@dpdk.org
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
commit 67332a696bef5b92dee0d1479a0895ad149883cd
Author: Abdullah Sevincer <abdullah.sevincer@intel.com>
Date: Wed Oct 12 18:50:36 2022 -0500
event/dlb2: remove COS from devargs
Since COS is now per port specific only and supported through
port_cos in dev_args, there is no need to have a COS
argument in dev_args.
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
commit f83ab599df9fe2c62208d0815715e53117e9958f
Author: Abdullah Sevincer <abdullah.sevincer@intel.com>
Date: Wed Oct 12 18:50:35 2022 -0500
event/dlb2: validate producer coremask
Add checks during port probing for validating producer
core masks if they are a subset of EAL coremask.
Error is returned if producer coremask is not a subset
of EAL coremask.
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
commit 4346d7f5424f4b97ec530ee5320ea931f4179230
Author: Abdullah Sevincer <abdullah.sevincer@intel.com>
Date: Wed Oct 12 18:50:34 2022 -0500
event/dlb2: remove COS from port probing
Remove COS (class of service) from port probing criteria and
apply enhancements for selection of ports from best
COS when default COS (255) is used.
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
> ---
> drivers/event/dlb2/dlb2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index b200c9484e..02f0e57208 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -848,10 +848,11 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2,
> }
>
> cfg->cos_strict = 0; /* Best effort */
> - cfg->num_cos_ldb_ports[0] = resources_asked->num_ldb_ports - cos_ports;
> + cfg->num_cos_ldb_ports[0] = dlb2->cos_ports[0];
> cfg->num_cos_ldb_ports[1] = dlb2->cos_ports[1];
> cfg->num_cos_ldb_ports[2] = dlb2->cos_ports[2];
> cfg->num_cos_ldb_ports[3] = dlb2->cos_ports[3];
> + cfg->num_ldb_ports = resources_asked->num_ldb_ports - cos_ports;
>
> if (device_version == DLB2_HW_V2)
> cfg->num_ldb_credits = resources_asked->num_ldb_credits;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-13 6:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221012143247.3239356-1-abdullah.sevincer@intel.com, shivani.doneria@intel.com>
2022-10-12 23:50 ` [PATCH v2 1/4] event/dlb2: remove cos from port probing Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 2/4] event/dlb2: add check valid producer coremask Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 3/4] event/dlb2: remove cos from devargs Abdullah Sevincer
2022-10-12 23:50 ` [PATCH v2 4/4] event/dlb2: fix port cos override calculation Abdullah Sevincer
2022-10-13 6:44 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).