DPDK patches and discussions
 help / color / mirror / Atom feed
From: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
To: abhishek.maheshwari@intel.com
Cc: dev@dpdk.org, chenbo.xia@intel.com, purna.chandra.mandal@intel.com
Subject: [PATCH] vdpa/ifc/base: wait for queue disable before saving q-state
Date: Tue, 25 Oct 2022 12:53:02 +0530	[thread overview]
Message-ID: <20221025072302.1683505-1-abhishek.maheshwari@intel.com> (raw)

Some ifc hardware require synchronization between disabling a queue and
saving queue-state from LM registers. When queue is disabled from vDPA
driver, ifc device stops executing new virtio-cmds and then updates LM
registers with used/avail index. Before saving the queue-state, vDPA
driver should wait until the queue is disabled from backend.

Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
---
 drivers/vdpa/ifc/base/ifcvf.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c
index f1e1474447..fb51c793a2 100644
--- a/drivers/vdpa/ifc/base/ifcvf.c
+++ b/drivers/vdpa/ifc/base/ifcvf.c
@@ -257,6 +257,7 @@ ifcvf_hw_disable(struct ifcvf_hw *hw)
 	u32 i;
 	struct ifcvf_pci_common_cfg *cfg;
 	u32 ring_state;
+	int q_disable_tries;
 
 	cfg = hw->common_cfg;
 	if (!cfg) {
@@ -275,6 +276,20 @@ ifcvf_hw_disable(struct ifcvf_hw *hw)
 			continue;
 		}
 
+        /* Some ifc hardware require synchronization between disabling a queue
+         * and saving queue-state from LM registers.
+         * When queue is disabled from vDPA driver, ifc device stops executing
+         * new virtio-cmds and then updates LM registers with used/avail index.
+         * Before saving the queue-state, vDPA driver waits until the queue is
+         * disabled from backend.
+		 */
+		q_disable_tries = 10;
+		while (q_disable_tries-- && IFCVF_READ_REG16(&cfg->queue_enable))
+			msec_delay(10);
+
+		if (IFCVF_READ_REG16(&cfg->queue_enable))
+			WARNINGOUT("Failed Q disable: %d. saved state is invalid\n", i);
+
 		if (hw->device_type == IFCVF_BLK)
 			ring_state = *(u32 *)(hw->lm_cfg +
 					IFCVF_LM_RING_STATE_OFFSET +
-- 
2.31.1


             reply	other threads:[~2022-10-25  7:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  7:23 Abhishek Maheshwari [this message]
2022-11-02  3:22 ` [PATCH v2] " Abhishek Maheshwari
2022-11-02  9:54   ` [PATCH v3] " Abhishek Maheshwari
2022-11-02 14:56     ` Pei, Andy
2022-11-03  2:37     ` Xia, Chenbo
2022-11-03  4:36     ` [PATCH v4] " Abhishek Maheshwari
2022-11-03  9:35       ` [PATCH v5] " Abhishek Maheshwari
2022-11-04  2:31         ` Xia, Chenbo
2022-11-04  2:38         ` Mandal, Purna Chandra
2022-11-10  7:02         ` Xia, Chenbo
2022-10-25  7:51 [PATCH] " Abhishek Maheshwari
2022-10-26  5:32 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221025072302.1683505-1-abhishek.maheshwari@intel.com \
    --to=abhishek.maheshwari@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=purna.chandra.mandal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).