From: madhuker.mythri@oracle.com
To: grive@u256.net
Cc: dev@dpdk.org, Madhuker Mythri <madhuker.mythri@oracle.com>
Subject: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id
Date: Wed, 16 Nov 2022 17:41:21 +0530 [thread overview]
Message-ID: <20221116121121.1969-1-madhuker.mythri@oracle.com> (raw)
From: Madhuker Mythri <madhuker.mythri@oracle.com>
Crash occurring while the DPDK secondary processes trying to probe the
tap-device, where tap-device is a sub-device of Fail-safe device.
Some-times we get in-valid sub-devices(with the in-valid port-id's),
due to which the IPC communication does not get response and causes the
communication failures b/w primary/secondary process.
So, need to validate the sub-device(tap) while secondary process probe in
the Fail-safe PMD, to avoid such issues.
Bugzilla Id: 1116
Signed-off-by: Madhuker Mythri <madhuker.mythri@oracle.com>
---
drivers/net/failsafe/failsafe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 32811403b4..51d4440ac7 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -361,6 +361,9 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
if (sdev->devargs.name[0] == '\0')
continue;
+ if (!rte_eth_dev_is_valid_port(PORT_ID(sdev)))
+ continue;
+
/* rebuild devargs to be able to get the bus name. */
ret = rte_devargs_parse(&devargs,
sdev->devargs.name);
--
2.32.0.windows.1
next reply other threads:[~2022-11-16 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 12:11 madhuker.mythri [this message]
2022-12-07 17:21 ` Ferruh Yigit
2023-10-17 16:49 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2022-11-16 9:52 madhuker.mythri
2022-11-16 17:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116121121.1969-1-madhuker.mythri@oracle.com \
--to=madhuker.mythri@oracle.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).