* [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute
2022-12-26 0:37 [PATCH v1 0/2] fix unsupported flow rule transfer attribute Steve Yang
@ 2022-12-26 0:37 ` Steve Yang
2023-01-17 1:26 ` Zhang, Qi Z
2022-12-26 0:37 ` [PATCH v1 2/2] net/ice: " Steve Yang
2022-12-26 1:22 ` [PATCH v1 0/2] " Yang, Qiming
2 siblings, 1 reply; 7+ messages in thread
From: Steve Yang @ 2022-12-26 0:37 UTC (permalink / raw)
To: dev; +Cc: Yuying.Zhang, beilei.xing, qiming.yang, qi.z.zhang, Steve Yang
i40e doesn't support transfer attribute of flow rule,
ignore it when validating rule attributes.
Fixes: 86eb05d6350b ("net/i40e: add flow validate function")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/i40e/i40e_flow.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 65a826d51c..67df77890a 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -1236,6 +1236,14 @@ i40e_flow_parse_attr(const struct rte_flow_attr *attr,
return -rte_errno;
}
+ /* Not supported */
+ if (attr->transfer) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
+ attr, "Not support transfer.");
+ return -rte_errno;
+ }
+
/* Not supported */
if (attr->priority) {
rte_flow_error_set(error, EINVAL,
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute
2022-12-26 0:37 ` [PATCH v1 1/2] net/i40e: " Steve Yang
@ 2023-01-17 1:26 ` Zhang, Qi Z
2023-01-17 1:26 ` Zhang, Qi Z
0 siblings, 1 reply; 7+ messages in thread
From: Zhang, Qi Z @ 2023-01-17 1:26 UTC (permalink / raw)
To: 'Yang, SteveX', dev; +Cc: Zhang, Yuying, Xing, Beilei, Yang, Qiming
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Monday, December 26, 2022 8:37 AM
> To: dev@dpdk.org
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute
>
> i40e doesn't support transfer attribute of flow rule, ignore it when validating
> rule attributes.
>
> Fixes: 86eb05d6350b ("net/i40e: add flow validate function")
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute
2023-01-17 1:26 ` Zhang, Qi Z
@ 2023-01-17 1:26 ` Zhang, Qi Z
0 siblings, 0 replies; 7+ messages in thread
From: Zhang, Qi Z @ 2023-01-17 1:26 UTC (permalink / raw)
To: 'Yang, SteveX', dev; +Cc: Zhang, Yuying, Xing, Beilei, Yang, Qiming
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, January 17, 2023 9:27 AM
> To: 'Yang, SteveX' <stevex.yang@intel.com>; dev@dpdk.org
> Cc: Zhang, Yuying <Yuying.Zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Subject: RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer
> attribute
>
>
>
> > -----Original Message-----
> > From: Yang, SteveX <stevex.yang@intel.com>
> > Sent: Monday, December 26, 2022 8:37 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang,
> > Qi Z <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> > Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer
> > attribute
> >
> > i40e doesn't support transfer attribute of flow rule, ignore it when
> > validating rule attributes.
> >
> > Fixes: 86eb05d6350b ("net/i40e: add flow validate function")
Also added Cc stable.
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 2/2] net/ice: fix unsupported flow rule transfer attribute
2022-12-26 0:37 [PATCH v1 0/2] fix unsupported flow rule transfer attribute Steve Yang
2022-12-26 0:37 ` [PATCH v1 1/2] net/i40e: " Steve Yang
@ 2022-12-26 0:37 ` Steve Yang
2023-01-17 1:29 ` Zhang, Qi Z
2022-12-26 1:22 ` [PATCH v1 0/2] " Yang, Qiming
2 siblings, 1 reply; 7+ messages in thread
From: Steve Yang @ 2022-12-26 0:37 UTC (permalink / raw)
To: dev; +Cc: Yuying.Zhang, beilei.xing, qiming.yang, qi.z.zhang, Steve Yang
ice doesn't support transfer attribute of flow rule,
ignore it when validating rule attributes.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/ice/ice_generic_flow.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index d496c28dec..86a32f8cb1 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -2030,6 +2030,14 @@ ice_flow_valid_attr(struct ice_adapter *ad,
return -rte_errno;
}
+ /* Not supported */
+ if (attr->transfer) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
+ attr, "Not support transfer.");
+ return -rte_errno;
+ }
+
/* Check pipeline mode support to set classification stage */
if (ad->devargs.pipe_mode_support) {
if (attr->priority == 0)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH v1 2/2] net/ice: fix unsupported flow rule transfer attribute
2022-12-26 0:37 ` [PATCH v1 2/2] net/ice: " Steve Yang
@ 2023-01-17 1:29 ` Zhang, Qi Z
0 siblings, 0 replies; 7+ messages in thread
From: Zhang, Qi Z @ 2023-01-17 1:29 UTC (permalink / raw)
To: 'Yang, SteveX', dev; +Cc: Zhang, Yuying, Xing, Beilei, Yang, Qiming
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Monday, December 26, 2022 8:37 AM
> To: dev@dpdk.org
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v1 2/2] net/ice: fix unsupported flow rule transfer attribute
>
> ice doesn't support transfer attribute of flow rule, ignore it when validating
> rule attributes.
>
> Fixes: d76116a4678f ("net/ice: add generic flow API")
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v1 0/2] fix unsupported flow rule transfer attribute
2022-12-26 0:37 [PATCH v1 0/2] fix unsupported flow rule transfer attribute Steve Yang
2022-12-26 0:37 ` [PATCH v1 1/2] net/i40e: " Steve Yang
2022-12-26 0:37 ` [PATCH v1 2/2] net/ice: " Steve Yang
@ 2022-12-26 1:22 ` Yang, Qiming
2 siblings, 0 replies; 7+ messages in thread
From: Yang, Qiming @ 2022-12-26 1:22 UTC (permalink / raw)
To: Yang, SteveX, dev; +Cc: Zhang, Yuying, Xing, Beilei, Zhang, Qi Z
Hi,
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Monday, December 26, 2022 8:37 AM
> To: dev@dpdk.org
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v1 0/2] fix unsupported flow rule transfer attribute
>
> ice & i40e doesn't support transfer attribute of flow rule, ignore it when
> validating rule attributes.
>
> Steve Yang (2):
> net/i40e: fix unsupported flow rule transfer attribute
> net/ice: fix unsupported flow rule transfer attribute
>
> drivers/net/i40e/i40e_flow.c | 8 ++++++++
> drivers/net/ice/ice_generic_flow.c | 8 ++++++++
> 2 files changed, 16 insertions(+)
>
> --
> 2.25.1
Acked-by: Qiming Yang <qiming.yang@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread