DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 0/2] bnxt fixes
@ 2024-03-16  3:54 Ajit Khaparde
  2024-03-16  3:54 ` [PATCH 1/2] net/bnxt: fix number of Tx queues being created Ajit Khaparde
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ajit Khaparde @ 2024-03-16  3:54 UTC (permalink / raw)
  To: dev

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Fixes to the bnxt driver. Please apply.

Ajit Khaparde (1):
  net/bnxt: fix init failures

Kishore Padmanabha (1):
  net/bnxt: fix number of Tx queues being created

 drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
 drivers/net/bnxt/bnxt_reps.c   | 4 ++--
 drivers/net/bnxt/bnxt_vnic.c   | 3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)

-- 
2.39.2 (Apple Git-143)


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] net/bnxt: fix number of Tx queues being created
  2024-03-16  3:54 [PATCH 0/2] bnxt fixes Ajit Khaparde
@ 2024-03-16  3:54 ` Ajit Khaparde
  2024-03-16  3:54 ` [PATCH 2/2] net/bnxt: fix init failures Ajit Khaparde
  2024-03-16 15:17 ` [PATCH 0/2] bnxt fixes Ajit Khaparde
  2 siblings, 0 replies; 4+ messages in thread
From: Ajit Khaparde @ 2024-03-16  3:54 UTC (permalink / raw)
  To: dev; +Cc: Kishore Padmanabha, stable

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>

The number of Tx queues for the representor port is limited by
number of Rx rings instead of Tx rings.

Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_reps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
index edcc27f556..79b3583636 100644
--- a/drivers/net/bnxt/bnxt_reps.c
+++ b/drivers/net/bnxt/bnxt_reps.c
@@ -739,10 +739,10 @@ int bnxt_rep_tx_queue_setup_op(struct rte_eth_dev *eth_dev,
 	struct bnxt_tx_queue *parent_txq, *txq;
 	struct bnxt_vf_rep_tx_queue *vfr_txq;
 
-	if (queue_idx >= rep_bp->rx_nr_rings) {
+	if (queue_idx >= rep_bp->tx_nr_rings) {
 		PMD_DRV_LOG(ERR,
 			    "Cannot create Tx rings %d. %d rings available\n",
-			    queue_idx, rep_bp->rx_nr_rings);
+			    queue_idx, rep_bp->tx_nr_rings);
 		return -EINVAL;
 	}
 
-- 
2.39.2 (Apple Git-143)


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] net/bnxt: fix init failures
  2024-03-16  3:54 [PATCH 0/2] bnxt fixes Ajit Khaparde
  2024-03-16  3:54 ` [PATCH 1/2] net/bnxt: fix number of Tx queues being created Ajit Khaparde
@ 2024-03-16  3:54 ` Ajit Khaparde
  2024-03-16 15:17 ` [PATCH 0/2] bnxt fixes Ajit Khaparde
  2 siblings, 0 replies; 4+ messages in thread
From: Ajit Khaparde @ 2024-03-16  3:54 UTC (permalink / raw)
  To: dev

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

Fix init failures in some cases when contiguous memory may not be
available for cases when a larger chunk of memory may be needed.

Fixes: fe2f715ca580 ("net/bnxt: support backing store v2")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
 drivers/net/bnxt/bnxt_vnic.c   | 3 +--
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ba31ae9286..e63febe782 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4949,8 +4949,7 @@ static int bnxt_alloc_ctx_mem_blk(struct bnxt *bp,
 						rmem->nr_pages * 8,
 						bp->eth_dev->device->numa_node,
 						RTE_MEMZONE_2MB |
-						RTE_MEMZONE_SIZE_HINT_ONLY |
-						RTE_MEMZONE_IOVA_CONTIG,
+						RTE_MEMZONE_SIZE_HINT_ONLY,
 						BNXT_PAGE_SIZE);
 			if (mz == NULL)
 				return -ENOMEM;
@@ -4974,8 +4973,7 @@ static int bnxt_alloc_ctx_mem_blk(struct bnxt *bp,
 						 mem_size,
 						 bp->eth_dev->device->numa_node,
 						 RTE_MEMZONE_1GB |
-						 RTE_MEMZONE_SIZE_HINT_ONLY |
-						 RTE_MEMZONE_IOVA_CONTIG,
+						 RTE_MEMZONE_SIZE_HINT_ONLY,
 						 BNXT_PAGE_SIZE);
 		if (mz == NULL)
 			return -ENOMEM;
diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c
index 76905ebdd1..16373be015 100644
--- a/drivers/net/bnxt/bnxt_vnic.c
+++ b/drivers/net/bnxt/bnxt_vnic.c
@@ -161,8 +161,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp, bool reconfig)
 						 entry_length * bp->max_vnics,
 						 bp->eth_dev->device->numa_node,
 						 RTE_MEMZONE_2MB |
-						 RTE_MEMZONE_SIZE_HINT_ONLY |
-						 RTE_MEMZONE_IOVA_CONTIG,
+						 RTE_MEMZONE_SIZE_HINT_ONLY,
 						 BNXT_PAGE_SIZE);
 		if (mz == NULL) {
 			PMD_DRV_LOG(ERR,
-- 
2.39.2 (Apple Git-143)


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] bnxt fixes
  2024-03-16  3:54 [PATCH 0/2] bnxt fixes Ajit Khaparde
  2024-03-16  3:54 ` [PATCH 1/2] net/bnxt: fix number of Tx queues being created Ajit Khaparde
  2024-03-16  3:54 ` [PATCH 2/2] net/bnxt: fix init failures Ajit Khaparde
@ 2024-03-16 15:17 ` Ajit Khaparde
  2 siblings, 0 replies; 4+ messages in thread
From: Ajit Khaparde @ 2024-03-16 15:17 UTC (permalink / raw)
  To: dev

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

On Fri, Mar 15, 2024 at 9:11 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Fixes to the bnxt driver. Please apply.
Patches merged in dpdk-next-net-brcm. Thanks

>
> Ajit Khaparde (1):
>   net/bnxt: fix init failures
>
> Kishore Padmanabha (1):
>   net/bnxt: fix number of Tx queues being created
>
>  drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
>  drivers/net/bnxt/bnxt_reps.c   | 4 ++--
>  drivers/net/bnxt/bnxt_vnic.c   | 3 +--
>  3 files changed, 5 insertions(+), 8 deletions(-)
>
> --
> 2.39.2 (Apple Git-143)
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-03-16 15:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-16  3:54 [PATCH 0/2] bnxt fixes Ajit Khaparde
2024-03-16  3:54 ` [PATCH 1/2] net/bnxt: fix number of Tx queues being created Ajit Khaparde
2024-03-16  3:54 ` [PATCH 2/2] net/bnxt: fix init failures Ajit Khaparde
2024-03-16 15:17 ` [PATCH 0/2] bnxt fixes Ajit Khaparde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).