DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] rte_errno set to negative value to be fixed
@ 2019-01-21 16:26 Andrew Rybchenko
  2019-01-21 16:40 ` Burakov, Anatoly
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2019-01-21 16:26 UTC (permalink / raw)
  To: dev
  Cc: Liang Ma, Peter Mccarthy, Harry van Haaren, Igor Russkikh,
	Pavel Belous, Jingjing Wu, Wenzhuo Lu, Marcin Wojtas,
	Michal Krawczyk, Guy Tzalik, Evgeny Schemeilin, Qi Zhang,
	Xiao Wang, Beilei Xing, Qiming Yang, Konstantin Ananyev,
	Rasesh Mody, Shahed Shaikh, Yong Wang, Radu Nicolau, Akhil Goyal

Hi all,

there are a number of cases where rte_errno is obviously set to negative 
value. I think it should be fixed.

Regards,
Andrew.

$ git grep 'rte_errno = -E'
drivers/event/opdl/opdl_evdev.c:                rte_errno = -EINVAL;
drivers/event/opdl/opdl_evdev.c:                rte_errno = -EDQUOT;
drivers/event/opdl/opdl_evdev.c:                rte_errno = -EINVAL;
drivers/event/opdl/opdl_evdev.c:                rte_errno = -EINVAL;
drivers/event/opdl/opdl_evdev.c:                rte_errno = -EINVAL;
drivers/event/opdl/opdl_evdev_init.c: rte_errno = -EINVAL;
drivers/event/opdl/opdl_evdev_init.c:                   rte_errno = -EINVAL;
drivers/event/opdl/opdl_evdev_init.c:   rte_errno = -ENOSPC;
drivers/event/opdl/opdl_evdev_init.c:           rte_errno = -ENOSPC;
drivers/event/opdl/opdl_evdev_init.c:   rte_errno = -ENOSPC;
drivers/event/opdl/opdl_evdev_init.c:           rte_errno = -EINVAL;
drivers/event/opdl/opdl_ring.c:         rte_errno = -EINVAL;
drivers/event/sw/sw_evdev.c:                    rte_errno = -EDQUOT;
drivers/event/sw/sw_evdev.c:                    rte_errno = -EDQUOT;
drivers/event/sw/sw_evdev.c:                            rte_errno = -EDQUOT;
drivers/event/sw/sw_evdev.c:                            rte_errno = -EDQUOT;
drivers/net/atlantic/atl_rxtx.c:                        rte_errno = -EINVAL;
drivers/net/atlantic/atl_rxtx.c:                        rte_errno = 
-ENOTSUP;
drivers/net/avf/avf_rxtx.c:                             rte_errno = -EINVAL;
drivers/net/avf/avf_rxtx.c:                     rte_errno = -EINVAL;
drivers/net/avf/avf_rxtx.c:                     rte_errno = -ENOTSUP;
drivers/net/e1000/em_rxtx.c:                    rte_errno = -ENOTSUP;
drivers/net/e1000/igb_rxtx.c:                           rte_errno = -EINVAL;
drivers/net/e1000/igb_rxtx.c:                   rte_errno = -ENOTSUP;
drivers/net/ena/ena_ethdev.c:                   rte_errno = -ENOTSUP;
drivers/net/fm10k/fm10k_rxtx.c:                 rte_errno = -EINVAL;
drivers/net/fm10k/fm10k_rxtx.c:                 rte_errno = -ENOTSUP;
drivers/net/i40e/i40e_rxtx.c:                           rte_errno = -EINVAL;
drivers/net/i40e/i40e_rxtx.c:                   rte_errno = -EINVAL;
drivers/net/i40e/i40e_rxtx.c:                   rte_errno = -ENOTSUP;
drivers/net/i40e/i40e_rxtx.c:                   rte_errno = -EINVAL;
drivers/net/ice/ice_rxtx.c:                     rte_errno = -EINVAL;
drivers/net/ixgbe/ixgbe_rxtx.c:                 rte_errno = -EINVAL;
drivers/net/ixgbe/ixgbe_rxtx.c:                 rte_errno = -ENOTSUP;
drivers/net/qede/qede_rxtx.c:                           rte_errno = -EINVAL;
drivers/net/qede/qede_rxtx.c:                           rte_errno = -EINVAL;
drivers/net/qede/qede_rxtx.c:                           rte_errno = -EINVAL;
drivers/net/qede/qede_rxtx.c:                   rte_errno = -ENOTSUP;
drivers/net/vmxnet3/vmxnet3_rxtx.c:                     rte_errno = -EINVAL;
drivers/net/vmxnet3/vmxnet3_rxtx.c:                     rte_errno = 
-ENOTSUP;
examples/ipsec-secgw/sa.c:              rte_errno = -ENOMEM;
lib/librte_eventdev/rte_event_eth_tx_adapter.h:         rte_errno = -EINVAL;
lib/librte_eventdev/rte_event_eth_tx_adapter.h:         rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.c:             rte_errno = -ENOTSUP;
lib/librte_eventdev/rte_eventdev.c:             rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.c:                     rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.c:             rte_errno = -ENOTSUP;
lib/librte_eventdev/rte_eventdev.c:             rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.c:                     rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.h:             rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.h:             rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.h:             rte_errno = -EINVAL;
lib/librte_eventdev/rte_eventdev.h:             rte_errno = -EINVAL;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] rte_errno set to negative value to be fixed
  2019-01-21 16:26 [dpdk-dev] rte_errno set to negative value to be fixed Andrew Rybchenko
@ 2019-01-21 16:40 ` Burakov, Anatoly
  0 siblings, 0 replies; 2+ messages in thread
From: Burakov, Anatoly @ 2019-01-21 16:40 UTC (permalink / raw)
  To: Andrew Rybchenko, dev
  Cc: Liang Ma, Peter Mccarthy, Harry van Haaren, Igor Russkikh,
	Pavel Belous, Jingjing Wu, Wenzhuo Lu, Marcin Wojtas,
	Michal Krawczyk, Guy Tzalik, Evgeny Schemeilin, Qi Zhang,
	Xiao Wang, Beilei Xing, Qiming Yang, Konstantin Ananyev,
	Rasesh Mody, Shahed Shaikh, Yong Wang, Radu Nicolau, Akhil Goyal

On 21-Jan-19 4:26 PM, Andrew Rybchenko wrote:
> Hi all,
> 
> there are a number of cases where rte_errno is obviously set to negative 
> value. I think it should be fixed.
> 
> Regards,
> Andrew.
> 

+1

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-21 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 16:26 [dpdk-dev] rte_errno set to negative value to be fixed Andrew Rybchenko
2019-01-21 16:40 ` Burakov, Anatoly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).