* Re: [dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1
@ 2015-12-03 18:31 Roberts, Lee A.
2015-12-03 19:06 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Roberts, Lee A. @ 2015-12-03 18:31 UTC (permalink / raw)
To: dev
When compiling DPDK 2.1.0 on RHEL 7.2, errors are encountered in ../librte_eal/linuxapp/kni/ethtool/igb/igb_main.c.
The following changes can be applied relative to dpdk-2.2.0-rc2 to resolve these issues.
- Lee Roberts
[root@dp91 lroberts]# diff -rc dpdk-2.2.0-rc2 dpdk-2.2.0-rc2-rhel7.2
diff -rc dpdk-2.2.0-rc2/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c dpdk-2.2.0-rc2-rhel7.2/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
*** dpdk-2.2.0-rc2/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c 2015-11-25 16:45:50.000000000 -0700
--- dpdk-2.2.0-rc2-rhel7.2/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c 2015-12-03 10:45:17.574014636 -0700
***************
*** 2274,2280 ****
else
mode = BRIDGE_MODE_VEPA;
! #ifdef HAVE_NDO_FDB_ADD_VID
#ifdef HAVE_NDO_BRIDGE_GETLINK_NLFLAGS
#ifdef HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL
return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode, 0, 0,
--- 2274,2280 ----
else
mode = BRIDGE_MODE_VEPA;
! #ifdef HAVE_NDO_DFLT_BRIDGE_ADD_MASK
#ifdef HAVE_NDO_BRIDGE_GETLINK_NLFLAGS
#ifdef HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL
return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode, 0, 0,
***************
*** 2287,2293 ****
#endif /* HAVE_NDO_BRIDGE_GETLINK_NLFLAGS */
#else
return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode);
! #endif /* HAVE_NDO_FDB_ADD_VID */
}
#endif /* HAVE_BRIDGE_ATTRIBS */
#endif /* NTF_SELF */
--- 2287,2293 ----
#endif /* HAVE_NDO_BRIDGE_GETLINK_NLFLAGS */
#else
return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode);
! #endif /* HAVE_NDO_DFLT_BRIDGE_ADD_MASK */
}
#endif /* HAVE_BRIDGE_ATTRIBS */
#endif /* NTF_SELF */
diff -rc dpdk-2.2.0-rc2/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h dpdk-2.2.0-rc2-rhel7.2/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
*** dpdk-2.2.0-rc2/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h 2015-11-25 16:45:50.000000000 -0700
--- dpdk-2.2.0-rc2-rhel7.2/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h 2015-12-03 10:51:09.551371049 -0700
***************
*** 3881,3900 ****
#endif /* < RHEL7 */
#endif /* < 3.14.0 */
! #if ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,16,0) )
#define SET_ETHTOOL_OPS(netdev, ops) ((netdev)->ethtool_ops = (ops))
#define HAVE_VF_MIN_MAX_TXRATE 1
#endif /* >= 3.16.0 */
! #if ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) )
#define HAVE_NDO_FDB_ADD_VID
#endif /* >= 3.19.0 */
! #if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0) )
/* vlan_tx_xx functions got renamed to skb_vlan */
#define vlan_tx_tag_get skb_vlan_tag_get
#define vlan_tx_tag_present skb_vlan_tag_present
#define HAVE_NDO_BRIDGE_SET_DEL_LINK_FLAGS
#endif /* 4.0.0 */
#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0) )
--- 3881,3909 ----
#endif /* < RHEL7 */
#endif /* < 3.14.0 */
! #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,16,0) ) \
! || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
! #undef SET_ETHTOOL_OPS
#define SET_ETHTOOL_OPS(netdev, ops) ((netdev)->ethtool_ops = (ops))
#define HAVE_VF_MIN_MAX_TXRATE 1
#endif /* >= 3.16.0 */
! #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \
! || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
! #define HAVE_NDO_DFLT_BRIDGE_ADD_MASK
! #if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
#define HAVE_NDO_FDB_ADD_VID
+ #endif /* !RHEL 7.2 */
#endif /* >= 3.19.0 */
! #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0) ) \
! || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
/* vlan_tx_xx functions got renamed to skb_vlan */
#define vlan_tx_tag_get skb_vlan_tag_get
#define vlan_tx_tag_present skb_vlan_tag_present
+ #if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
#define HAVE_NDO_BRIDGE_SET_DEL_LINK_FLAGS
+ #endif /* !RHEL 7.2 */
#endif /* 4.0.0 */
#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0) )
[root@dp91 lroberts]#
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1
2015-12-03 18:31 [dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1 Roberts, Lee A.
@ 2015-12-03 19:06 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-12-03 19:06 UTC (permalink / raw)
To: Roberts, Lee A.; +Cc: dev
2015-12-03 18:31, Roberts, Lee A.:
> When compiling DPDK 2.1.0 on RHEL 7.2, errors are encountered in ../librte_eal/linuxapp/kni/ethtool/igb/igb_main.c.
> The following changes can be applied relative to dpdk-2.2.0-rc2 to resolve these issues.
Thanks
Please check how to submit a proper patch for inclusion:
http://dpdk.org/dev#send
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1
@ 2015-11-13 20:09 Serguei Bezverkhi (sbezverk)
0 siblings, 0 replies; 3+ messages in thread
From: Serguei Bezverkhi (sbezverk) @ 2015-11-13 20:09 UTC (permalink / raw)
To: dev
Hello,
When I try to build dpdk 2.1 on rhel 7.2 rc1 I am getting following errors, appreciate if somebody could suggest a workaround of this problem. Thank you, Serguei
CC [M] /root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.o
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c: In function 'igb_ndo_bridge_getlink':
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c:2289:2: error: too few arguments to function 'ndo_dflt_bridge_getlink'
return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode);
^
In file included from /usr/src/kernels/3.10.0-327.el7.x86_64/include/net/dst.h:13:0,
from /usr/src/kernels/3.10.0-327.el7.x86_64/include/net/sock.h:68,
from /usr/src/kernels/3.10.0-327.el7.x86_64/include/linux/tcp.h:23,
from /root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c:34:
/usr/src/kernels/3.10.0-327.el7.x86_64/include/linux/rtnetlink.h:87:12: note: declared here
extern int ndo_dflt_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
^
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c: In function 'igb_xmit_frame_ring':
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c:5503:2: error: implicit declaration of function 'vlan_tx_tag_present' [-Werror=implicit-function-declaration]
if (vlan_tx_tag_present(skb)) {
^
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c:5505:3: error: implicit declaration of function 'vlan_tx_tag_get' [-Werror=implicit-function-declaration]
tx_flags |= (vlan_tx_tag_get(skb) << IGB_TX_FLAGS_VLAN_SHIFT);
^
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c: In function 'igb_ndo_get_vf_config':
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c:9472:5: error: 'struct ifla_vf_info' has no member named 'tx_rate'
ivi->tx_rate = adapter->vf_data[vf].tx_rate;
^
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c: In function 'igb_ndo_bridge_getlink':
/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.c:2291:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1: all warnings being treated as errors
make[10]: *** [/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_main.o] Error 1
make[9]: *** [_module_/root/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni] Error 2
make[8]: *** [sub-make] Error 2
make[7]: *** [rte_kni.ko] Error 2
make[6]: *** [kni] Error 2
make[5]: *** [linuxapp] Error 2
make[4]: *** [librte_eal] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
make: *** [install] Error 2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-03 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-03 18:31 [dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1 Roberts, Lee A.
2015-12-03 19:06 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2015-11-13 20:09 Serguei Bezverkhi (sbezverk)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).