DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: fix compilation for x86_x32-native-linuxapp-gcc
@ 2015-07-30 20:26 Olivier Matz
  2015-08-02 22:25 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Olivier Matz @ 2015-07-30 20:26 UTC (permalink / raw)
  To: dev

Compiling for dpdk x86_x32 gives the following error:

  CC eal_common_timer.o
In file included from /usr/include/sys/sysctl.h:63:0,
                 from dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
/usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is unsupported in x32 kernel"
 # error "sysctl system call is unsupported in x32 kernel"
   ^
dpdk.org/mk/internal/rte.compile-pre.mk:126: recipe for target 'eal_common_timer.o' failed
make[6]: *** [eal_common_timer.o] Error 1

Including sysctl.h was added by mistake when merging bsd and linux EAL
timer code. It can be safely removed in this file, fixing the
compilation.

Fixes: 040cf8a411 ("eal: deduplicate timer functions")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/librte_eal/common/eal_common_timer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
index 255f995..72371b8 100644
--- a/lib/librte_eal/common/eal_common_timer.c
+++ b/lib/librte_eal/common/eal_common_timer.c
@@ -36,7 +36,6 @@
 #include <unistd.h>
 #include <inttypes.h>
 #include <sys/types.h>
-#include <sys/sysctl.h>
 #include <errno.h>
 
 #include <rte_common.h>
-- 
2.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: fix compilation for x86_x32-native-linuxapp-gcc
  2015-07-30 20:26 [dpdk-dev] [PATCH] eal: fix compilation for x86_x32-native-linuxapp-gcc Olivier Matz
@ 2015-08-02 22:25 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-08-02 22:25 UTC (permalink / raw)
  To: Olivier Matz; +Cc: dev

2015-07-30 22:26, Olivier Matz:
> Compiling for dpdk x86_x32 gives the following error:
> 
>   CC eal_common_timer.o
> In file included from /usr/include/sys/sysctl.h:63:0,
>                  from dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
> /usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is unsupported in x32 kernel"
>  # error "sysctl system call is unsupported in x32 kernel"
>    ^
> dpdk.org/mk/internal/rte.compile-pre.mk:126: recipe for target 'eal_common_timer.o' failed
> make[6]: *** [eal_common_timer.o] Error 1
> 
> Including sysctl.h was added by mistake when merging bsd and linux EAL
> timer code. It can be safely removed in this file, fixing the
> compilation.
> 
> Fixes: 040cf8a411 ("eal: deduplicate timer functions")
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-02 22:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-30 20:26 [dpdk-dev] [PATCH] eal: fix compilation for x86_x32-native-linuxapp-gcc Olivier Matz
2015-08-02 22:25 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).