[dpdk-dev] [PATCH] doc: remove ethdev deprecation note for flag name

[dpdk-dev] [PATCH] doc: remove ethdev deprecation note for flag name

[Aman Singh]

Proposed name change of offload flag PKT_RX_EIP_CKSUM_BAD
to PKT_RX_OUTER_IP_CKSUM_BAD has already been done in the
code as per the deprecation note.

Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 -----
 lib/mbuf/rte_mbuf_core.h             | 7 -------
 2 files changed, 12 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 05fc2fdee7..549e9416c4 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -159,11 +159,6 @@ Deprecation Notices
   will be limited to maximum 256 queues.
   Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.
 
-* ethdev: The offload flag ``PKT_RX_EIP_CKSUM_BAD`` will be removed and
-  replaced by the new flag ``PKT_RX_OUTER_IP_CKSUM_BAD``. The new name is more
-  consistent with existing outer header checksum status flag naming, which
-  should help in reducing confusion about its usage.
-
 * i40e: As there are both i40evf and iavf pmd, the functions of them are
   duplicated. And now more and more advanced features are developed on iavf.
   To keep consistent with kernel driver's name
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 9d8e3ddc86..d6f1679944 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -79,13 +79,6 @@ extern "C" {
  */
 #define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5)
 
-/**
- * Deprecated.
- * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
- */
-#define PKT_RX_EIP_CKSUM_BAD \
-	RTE_DEPRECATED(PKT_RX_EIP_CKSUM_BAD) PKT_RX_OUTER_IP_CKSUM_BAD
-
 /**
  * A vlan has been stripped by the hardware and its tci is saved in
  * mbuf->vlan_tci. This can only happen if vlan stripping is enabled
-- 
2.17.1

Re: [dpdk-dev] [PATCH] doc: remove ethdev deprecation note for flag name

[Ferruh Yigit]

On 9/30/2021 8:47 AM, Aman Singh wrote:
> Proposed name change of offload flag PKT_RX_EIP_CKSUM_BAD
> to PKT_RX_OUTER_IP_CKSUM_BAD has already been done in the
> code as per the deprecation note.
> 
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 -----
>  lib/mbuf/rte_mbuf_core.h             | 7 -------

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

But I would do the patch as mbuf patch, instead of doc patch. If you send a new
version with this change please feel free to keep the ack.