[dpdk-dev] [PATCH 0/4] Cleanup last remaining SPDX issues

[dpdk-dev] [PATCH 0/4] Cleanup last remaining SPDX issues

[Stephen Hemminger]

This resolves all the left over warnings and errors reported
by the check-spdx-tag script.

Stephen Hemminger (4):
  common/mlx5: add missing SPDX tag for windows headers
  devtools/check-spdx-tag.sh: ignore JSON files
  doc: add SPDX tag to custom CSS file
  app/test: remove license boilerplate

 app/test/test_timer_racecond.c              | 26 ---------------------
 devtools/check-spdx-tag.sh                  |  2 +-
 doc/guides/custom.css                       |  1 +
 drivers/common/mlx5/windows/mlx5_win_defs.h |  4 ++--
 drivers/common/mlx5/windows/mlx5_win_ext.h  |  4 ++--
 5 files changed, 6 insertions(+), 31 deletions(-)

-- 
2.30.2

[dpdk-dev] [PATCH 1/4] common/mlx5: add missing SPDX tag for windows headers

[Stephen Hemminger]

These files were added without requires SPDX headers.

Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows")
Cc: talshn@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/mlx5/windows/mlx5_win_defs.h | 4 ++--
 drivers/common/mlx5/windows/mlx5_win_ext.h  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/common/mlx5/windows/mlx5_win_defs.h
index 8a1c2c5af94f..47bfc907e7d3 100644
--- a/drivers/common/mlx5/windows/mlx5_win_defs.h
+++ b/drivers/common/mlx5/windows/mlx5_win_defs.h
@@ -1,7 +1,7 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
- *
  */
+
 #ifndef __MLX5_WIN_DEFS_H__
 #define __MLX5_WIN_DEFS_H__
 
diff --git a/drivers/common/mlx5/windows/mlx5_win_ext.h b/drivers/common/mlx5/windows/mlx5_win_ext.h
index 60610df6b250..b5d4484a1366 100644
--- a/drivers/common/mlx5/windows/mlx5_win_ext.h
+++ b/drivers/common/mlx5/windows/mlx5_win_ext.h
@@ -1,7 +1,7 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
- *
  */
+
 #ifndef __MLX5_WIN_ETX_H__
 #define __MLX5_WIN_ETX_H__
 
-- 
2.30.2

Re: [dpdk-dev] [PATCH 1/4] common/mlx5: add missing SPDX tag for windows headers

[Tal Shnaiderman]

> Subject: [PATCH 1/4] common/mlx5: add missing SPDX tag for windows
> headers
> 
> External email: Use caution opening links or attachments
> 
> 
> These files were added without requires SPDX headers.
> 
> Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows")
> Cc: talshn@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/common/mlx5/windows/mlx5_win_defs.h | 4 ++--
> drivers/common/mlx5/windows/mlx5_win_ext.h  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h
> b/drivers/common/mlx5/windows/mlx5_win_defs.h
> index 8a1c2c5af94f..47bfc907e7d3 100644
> --- a/drivers/common/mlx5/windows/mlx5_win_defs.h
> +++ b/drivers/common/mlx5/windows/mlx5_win_defs.h
> @@ -1,7 +1,7 @@
> -/*
> +/* SPDX-License-Identifier: BSD-3-Clause
>   * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
> - *
>   */
> +
>  #ifndef __MLX5_WIN_DEFS_H__
>  #define __MLX5_WIN_DEFS_H__
> 
> diff --git a/drivers/common/mlx5/windows/mlx5_win_ext.h
> b/drivers/common/mlx5/windows/mlx5_win_ext.h
> index 60610df6b250..b5d4484a1366 100644
> --- a/drivers/common/mlx5/windows/mlx5_win_ext.h
> +++ b/drivers/common/mlx5/windows/mlx5_win_ext.h
> @@ -1,7 +1,7 @@
> -/*
> +/* SPDX-License-Identifier: BSD-3-Clause
>   * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
> - *
>   */
> +
>  #ifndef __MLX5_WIN_ETX_H__
>  #define __MLX5_WIN_ETX_H__
> 
> --
> 2.30.2

Thanks Stephen,

Doesn't this patch needs to cc stable as well since those files were added in 21.02?

Acked-by: Tal Shnaiderman <talshn@nvidia.com>

Re: [dpdk-dev] [PATCH 1/4] common/mlx5: add missing SPDX tag for windows headers

[Thomas Monjalon]

> > These files were added without requires SPDX headers.
> > 
> > Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows")
> > Cc: talshn@nvidia.com
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > -/*
> > +/* SPDX-License-Identifier: BSD-3-Clause
> >   * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
> > - *
> >   */
> > +
> >  #ifndef __MLX5_WIN_ETX_H__
> >  #define __MLX5_WIN_ETX_H__
> > 
> > --
> > 2.30.2
> 
> Thanks Stephen,
> 
> Doesn't this patch needs to cc stable as well since those files were added in 21.02?
> 
> Acked-by: Tal Shnaiderman <talshn@nvidia.com>

Yes will add stable while applying.

[dpdk-dev] [PATCH 2/4] devtools/check-spdx-tag.sh: ignore JSON files

[Stephen Hemminger]

The JSON file format does not support comments so there is no good
way to add SPDX license identifier.  This solves false positives
that arrive from the use of JSON in crypto dev tests.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 devtools/check-spdx-tag.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/check-spdx-tag.sh b/devtools/check-spdx-tag.sh
index a0ec1ed5b6da..bc0b6efcf976 100755
--- a/devtools/check-spdx-tag.sh
+++ b/devtools/check-spdx-tag.sh
@@ -26,7 +26,7 @@ check_spdx() {
 	':^license/' ':^config/' ':^buildtools/' \
 	':^*.cocci' ':^*.abignore' \
 	':^*.def' ':^*.map' ':^*.ini' ':^*.data' ':^*.cfg' ':^*.txt' \
-	':^*.svg' ':^*.png'\
+	':^*.svg' ':^*.png' ':^*.json' \
 	> $tmpfile
 
     errors=$(wc -l < $tmpfile)
-- 
2.30.2

[dpdk-dev] [PATCH 3/4] doc: add SPDX tag to custom CSS file

[Stephen Hemminger]

Trivial file, but add SPDX license tag per policy

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 doc/guides/custom.css | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/custom.css b/doc/guides/custom.css
index c87c60611929..a1572eaf9da6 100644
--- a/doc/guides/custom.css
+++ b/doc/guides/custom.css
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
 /* Override readthedocs theme */
 
 /* Spacing before a list item must be bigger than spacing inside the item.
-- 
2.30.2

Re: [dpdk-dev] [PATCH 3/4] doc: add SPDX tag to custom CSS file

[Thomas Monjalon]

16/03/2021 22:00, Stephen Hemminger:
> Trivial file, but add SPDX license tag per policy
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

I wrote this file in 2018. Adding copyright:
Copyright 2018 Mellanox Technologies, Ltd

[dpdk-dev] [PATCH 4/4] app/test: remove license boilerplate

[Stephen Hemminger]

This file has redundant BSD license text that is already
replaces by the use of SPDX license id. Having both is unnecessary
and potentially confusing.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_timer_racecond.c | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/app/test/test_timer_racecond.c b/app/test/test_timer_racecond.c
index 133d3324ee66..bb56ae8324fc 100644
--- a/app/test/test_timer_racecond.c
+++ b/app/test/test_timer_racecond.c
@@ -1,32 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2015 Akamai Technologies.
  * All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "test.h"
-- 
2.30.2

Re: [dpdk-dev] [PATCH 0/4] Cleanup last remaining SPDX issues

[Thomas Monjalon]

16/03/2021 22:00, Stephen Hemminger:
> This resolves all the left over warnings and errors reported
> by the check-spdx-tag script.
> 
> Stephen Hemminger (4):
>   common/mlx5: add missing SPDX tag for windows headers
>   devtools/check-spdx-tag.sh: ignore JSON files
>   doc: add SPDX tag to custom CSS file
>   app/test: remove license boilerplate

Applied with minor changes explained in the thread, thanks.