* [dpdk-dev] [PATCH] mk: fix combined library building
@ 2015-06-09 9:37 Sergio Gonzalez Monroy
2015-06-09 10:33 ` De Lara Guarch, Pablo
2015-06-10 2:48 ` Li Wei
0 siblings, 2 replies; 4+ messages in thread
From: Sergio Gonzalez Monroy @ 2015-06-09 9:37 UTC (permalink / raw)
To: dev
The combined lib was being created after building the lib root dir.
With the new directory hierarchy, it should be created after the
drivers root dir instead.
Fixes: 980ed498eb1dd0 ("drivers: create new directory")
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
mk/rte.sdkbuild.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index 3154457..09bb60a 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -93,7 +93,7 @@ $(ROOTDIRS-y):
@[ -d $(BUILDDIR)/$@ ] || mkdir -p $(BUILDDIR)/$@
@echo "== Build $@"
$(Q)$(MAKE) S=$@ -f $(RTE_SRCDIR)/$@/Makefile -C $(BUILDDIR)/$@ all
- @if [ $@ = lib -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
+ @if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
$(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
fi
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix combined library building
2015-06-09 9:37 [dpdk-dev] [PATCH] mk: fix combined library building Sergio Gonzalez Monroy
@ 2015-06-09 10:33 ` De Lara Guarch, Pablo
2015-06-10 2:48 ` Li Wei
1 sibling, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2015-06-09 10:33 UTC (permalink / raw)
To: Gonzalez Monroy, Sergio, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Tuesday, June 09, 2015 10:37 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix combined library building
>
> The combined lib was being created after building the lib root dir.
> With the new directory hierarchy, it should be created after the
> drivers root dir instead.
>
> Fixes: 980ed498eb1dd0 ("drivers: create new directory")
>
> Signed-off-by: Sergio Gonzalez Monroy
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix combined library building
2015-06-09 9:37 [dpdk-dev] [PATCH] mk: fix combined library building Sergio Gonzalez Monroy
2015-06-09 10:33 ` De Lara Guarch, Pablo
@ 2015-06-10 2:48 ` Li Wei
2015-06-10 10:23 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Li Wei @ 2015-06-10 2:48 UTC (permalink / raw)
To: Sergio Gonzalez Monroy, dev
On 06/09/2015 05:37 PM, Sergio Gonzalez Monroy wrote:
> The combined lib was being created after building the lib root dir.
> With the new directory hierarchy, it should be created after the
> drivers root dir instead.
>
> Fixes: 980ed498eb1dd0 ("drivers: create new directory")
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Tested-by: Li Wei <lw@cn.fujitsu.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix combined library building
2015-06-10 2:48 ` Li Wei
@ 2015-06-10 10:23 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-06-10 10:23 UTC (permalink / raw)
To: Sergio Gonzalez Monroy; +Cc: dev
2015-06-10 10:48, Li Wei:
> On 06/09/2015 05:37 PM, Sergio Gonzalez Monroy wrote:
> > The combined lib was being created after building the lib root dir.
> > With the new directory hierarchy, it should be created after the
> > drivers root dir instead.
> >
> > Fixes: 980ed498eb1dd0 ("drivers: create new directory")
> >
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>
> Tested-by: Li Wei <lw@cn.fujitsu.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-10 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-09 9:37 [dpdk-dev] [PATCH] mk: fix combined library building Sergio Gonzalez Monroy
2015-06-09 10:33 ` De Lara Guarch, Pablo
2015-06-10 2:48 ` Li Wei
2015-06-10 10:23 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).