From: Rasesh Mody <rasesh.mody@qlogic.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Ameen Rahman <ameen.rahman@qlogic.com>,
Harish Patil <harish.patil@qlogic.com>,
Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD
Date: Thu, 24 Mar 2016 01:52:01 +0000 [thread overview]
Message-ID: <2552F74A0BCCBE4DBE2AD218C81B2811086FED07@avmb3.qlogic.org> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B0359F0E37@IRSMSX103.ger.corp.intel.com>
Hi Bruce,
> From: Richardson, Bruce [mailto:bruce.richardson@intel.com]
> Sent: Tuesday, March 22, 2016 4:21 AM
>
> I've had a quick scan over this patchset, and as you've probably seen I've
> made some public comments on it. General comments on the whole
> patchset are:
> * Please run checkpatch on the patchset and clear up as many issues as you
> can. There are a number of typos called out which especially must be fixed.
> Both myself and Thomas always run checkpatch against patches before
> applying them. [I suggest using Thomas's checkpatches.sh script to do the
> checks as it disables many unnecessary warnings from checkpatch]
> * Please put in commit descriptions for all patches bar those doing trivial
> things. The first three patches probably don't need a commit message, but
> the rest do.
* We had run checkpatch script from dpdk on v1 submission, checkpatch.pl from 3.15 kernel and had addressed all the check patch issues.
* However, we got a recommendation "Running checkpatch with --ignore PREFER_KERNEL_TYPES,LINE_SPACING,PARENTHESIS_ALIGNMENT,BIT_MACRO,NETWORKING_BLOCK_COMMENT_STYLE,SPLIT_STRING,COMPARISON_TO_NULL,CONCATENATED_STRING". With v2 we used these ignore options with checkpatch.pl from 4.5 kernel and addressed checkpatch reported errors/warnings/checks. However, the spellcheck was missing from both the submissions.
* With v3 there was no code change(meant for dpdk-next-net)
We'll address spellchecks and other issues that may have been additionally found by latest checkpatch scripts. We'll also add the commit message to make the patches descriptive and submit v4 patch set.
Thanks!
Rasesh
> /Bruce
>
> > -----Original Message-----
> > From: Rasesh Mody [mailto:rasesh.mody@qlogic.com]
> > Sent: Saturday, March 19, 2016 12:53 AM
> > To: thomas.monjalon@6wind.com; Richardson, Bruce
> > <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; ameen.rahman@qlogic.com; harish.patil@qlogic.com;
> > sony.chacko@qlogic.com; Rasesh Mody <rasesh.mody@qlogic.com>
> > Subject: [PATCH v3 00/10] qede: Add qede PMD
> >
> > Submitting v3 patch series for QEDE PMD. There is no code change from
> > v2 series except PMD version change. Earlier we had generated and
> > tested the
> > v2 series against dpdk tree then latest.
> >
> > The v3 series includes:
> > - Patches generated and tested against latest dpdk-next-net
> > - Reworked MAINTAINERS patch to make it apply cleanly
> > - Incorporated Overview.rst update in the documentation patch
> >
> > Please Apply.
> >
> > Thanks!
> > Rasesh
> >
> > Rasesh Mody (10):
> > qede: Add maintainers
> > qede: Add documentation
> > qede: Add license file
> > qede: Add base driver
> > qede: Add core driver
> > qede: Add L2 support
> > qede: Add SRIOV support
> > qede: Add attention support
> > qede: Add DCBX support
> > qede: Enable PMD build
> >
> > MAINTAINERS | 7 +
> > config/common_base | 14 +
> > doc/guides/nics/index.rst | 1 +
> > doc/guides/nics/overview.rst | 78 +-
> > doc/guides/nics/qede.rst | 340 +
> > drivers/net/Makefile | 1 +
> > drivers/net/qede/LICENSE.qede_pmd | 28 +
> > drivers/net/qede/Makefile | 95 +
> > drivers/net/qede/base/bcm_osal.c | 178 +
> > drivers/net/qede/base/bcm_osal.h | 395 +
> > drivers/net/qede/base/common_hsi.h | 714 ++
> > drivers/net/qede/base/ecore.h | 746 ++
> > drivers/net/qede/base/ecore_attn_values.h |13287
> > +++++++++++++++++++++++++++
> > drivers/net/qede/base/ecore_chain.h | 724 ++
> > drivers/net/qede/base/ecore_cxt.c | 1961 ++++
> > drivers/net/qede/base/ecore_cxt.h | 157 +
> > drivers/net/qede/base/ecore_cxt_api.h | 79 +
> > drivers/net/qede/base/ecore_dcbx.c | 887 ++
> > drivers/net/qede/base/ecore_dcbx.h | 55 +
> > drivers/net/qede/base/ecore_dcbx_api.h | 160 +
> > drivers/net/qede/base/ecore_dev.c | 3578 ++++++++
> > drivers/net/qede/base/ecore_dev_api.h | 497 +
> > drivers/net/qede/base/ecore_gtt_reg_addr.h | 42 +
> > drivers/net/qede/base/ecore_gtt_values.h | 33 +
> > drivers/net/qede/base/ecore_hsi_common.h | 1912 ++++
> > drivers/net/qede/base/ecore_hsi_eth.h | 1912 ++++
> > drivers/net/qede/base/ecore_hsi_tools.h | 1081 +++
> > drivers/net/qede/base/ecore_hw.c | 992 ++
> > drivers/net/qede/base/ecore_hw.h | 269 +
> > drivers/net/qede/base/ecore_hw_defs.h | 49 +
> > drivers/net/qede/base/ecore_init_fw_funcs.c | 1275 +++
> > drivers/net/qede/base/ecore_init_fw_funcs.h | 263 +
> > drivers/net/qede/base/ecore_init_ops.c | 599 ++
> > drivers/net/qede/base/ecore_init_ops.h | 103 +
> > drivers/net/qede/base/ecore_int.c | 2225 +++++
> > drivers/net/qede/base/ecore_int.h | 234 +
> > drivers/net/qede/base/ecore_int_api.h | 277 +
> > drivers/net/qede/base/ecore_iov_api.h | 933 ++
> > drivers/net/qede/base/ecore_iro.h | 115 +
> > drivers/net/qede/base/ecore_iro_values.h | 59 +
> > drivers/net/qede/base/ecore_l2.c | 1798 ++++
> > drivers/net/qede/base/ecore_l2.h | 151 +
> > drivers/net/qede/base/ecore_l2_api.h | 401 +
> > drivers/net/qede/base/ecore_mcp.c | 1928 ++++
> > drivers/net/qede/base/ecore_mcp.h | 304 +
> > drivers/net/qede/base/ecore_mcp_api.h | 611 ++
> > drivers/net/qede/base/ecore_proto_if.h | 28 +
> > drivers/net/qede/base/ecore_rt_defs.h | 446 +
> > drivers/net/qede/base/ecore_sp_api.h | 42 +
> > drivers/net/qede/base/ecore_sp_commands.c | 525 ++
> > drivers/net/qede/base/ecore_sp_commands.h | 137 +
> > drivers/net/qede/base/ecore_spq.c | 944 ++
> > drivers/net/qede/base/ecore_spq.h | 284 +
> > drivers/net/qede/base/ecore_sriov.c | 3422 +++++++
> > drivers/net/qede/base/ecore_sriov.h | 390 +
> > drivers/net/qede/base/ecore_status.h | 30 +
> > drivers/net/qede/base/ecore_utils.h | 31 +
> > drivers/net/qede/base/ecore_vf.c | 1322 +++
> > drivers/net/qede/base/ecore_vf.h | 415 +
> > drivers/net/qede/base/ecore_vf_api.h | 186 +
> > drivers/net/qede/base/ecore_vfpf_if.h | 590 ++
> > drivers/net/qede/base/eth_common.h | 526 ++
> > drivers/net/qede/base/mcp_public.h | 1195 +++
> > drivers/net/qede/base/nvm_cfg.h | 919 ++
> > drivers/net/qede/base/reg_addr.h | 1107 +++
> > drivers/net/qede/qede_eth_if.c | 456 +
> > drivers/net/qede/qede_eth_if.h | 176 +
> > drivers/net/qede/qede_ethdev.c | 986 ++
> > drivers/net/qede/qede_ethdev.h | 157 +
> > drivers/net/qede/qede_if.h | 164 +
> > drivers/net/qede/qede_logs.h | 93 +
> > drivers/net/qede/qede_main.c | 601 ++
> > drivers/net/qede/qede_rxtx.c | 1364 +++
> > drivers/net/qede/qede_rxtx.h | 187 +
> > drivers/net/qede/rte_pmd_qede_version.map | 4 +
> > mk/rte.app.mk | 2 +
> > scripts/test-build.sh | 1 +
> > 77 files changed, 58239 insertions(+), 39 deletions(-) create mode
> > 100644 doc/guides/nics/qede.rst create mode 100644
> > drivers/net/qede/LICENSE.qede_pmd create mode 100644
> > drivers/net/qede/Makefile create mode 100644
> > drivers/net/qede/base/bcm_osal.c create mode 100644
> > drivers/net/qede/base/bcm_osal.h create mode 100644
> > drivers/net/qede/base/common_hsi.h
> > create mode 100644 drivers/net/qede/base/ecore.h create mode 100644
> > drivers/net/qede/base/ecore_attn_values.h
> > create mode 100644 drivers/net/qede/base/ecore_chain.h
> > create mode 100644 drivers/net/qede/base/ecore_cxt.c create mode
> > 100644 drivers/net/qede/base/ecore_cxt.h create mode 100644
> > drivers/net/qede/base/ecore_cxt_api.h
> > create mode 100644 drivers/net/qede/base/ecore_dcbx.c
> > create mode 100644 drivers/net/qede/base/ecore_dcbx.h
> > create mode 100644 drivers/net/qede/base/ecore_dcbx_api.h
> > create mode 100644 drivers/net/qede/base/ecore_dev.c create mode
> > 100644 drivers/net/qede/base/ecore_dev_api.h
> > create mode 100644 drivers/net/qede/base/ecore_gtt_reg_addr.h
> > create mode 100644 drivers/net/qede/base/ecore_gtt_values.h
> > create mode 100644 drivers/net/qede/base/ecore_hsi_common.h
> > create mode 100644 drivers/net/qede/base/ecore_hsi_eth.h
> > create mode 100644 drivers/net/qede/base/ecore_hsi_tools.h
> > create mode 100644 drivers/net/qede/base/ecore_hw.c create mode
> > 100644 drivers/net/qede/base/ecore_hw.h create mode 100644
> > drivers/net/qede/base/ecore_hw_defs.h
> > create mode 100644 drivers/net/qede/base/ecore_init_fw_funcs.c
> > create mode 100644 drivers/net/qede/base/ecore_init_fw_funcs.h
> > create mode 100644 drivers/net/qede/base/ecore_init_ops.c
> > create mode 100644 drivers/net/qede/base/ecore_init_ops.h
> > create mode 100644 drivers/net/qede/base/ecore_int.c create mode
> > 100644 drivers/net/qede/base/ecore_int.h create mode 100644
> > drivers/net/qede/base/ecore_int_api.h
> > create mode 100644 drivers/net/qede/base/ecore_iov_api.h
> > create mode 100644 drivers/net/qede/base/ecore_iro.h create mode
> > 100644 drivers/net/qede/base/ecore_iro_values.h
> > create mode 100644 drivers/net/qede/base/ecore_l2.c create mode
> > 100644 drivers/net/qede/base/ecore_l2.h create mode 100644
> > drivers/net/qede/base/ecore_l2_api.h
> > create mode 100644 drivers/net/qede/base/ecore_mcp.c create mode
> > 100644 drivers/net/qede/base/ecore_mcp.h create mode 100644
> > drivers/net/qede/base/ecore_mcp_api.h
> > create mode 100644 drivers/net/qede/base/ecore_proto_if.h
> > create mode 100644 drivers/net/qede/base/ecore_rt_defs.h
> > create mode 100644 drivers/net/qede/base/ecore_sp_api.h
> > create mode 100644 drivers/net/qede/base/ecore_sp_commands.c
> > create mode 100644 drivers/net/qede/base/ecore_sp_commands.h
> > create mode 100644 drivers/net/qede/base/ecore_spq.c create mode
> > 100644 drivers/net/qede/base/ecore_spq.h create mode 100644
> > drivers/net/qede/base/ecore_sriov.c
> > create mode 100644 drivers/net/qede/base/ecore_sriov.h
> > create mode 100644 drivers/net/qede/base/ecore_status.h
> > create mode 100644 drivers/net/qede/base/ecore_utils.h
> > create mode 100644 drivers/net/qede/base/ecore_vf.c create mode
> > 100644 drivers/net/qede/base/ecore_vf.h create mode 100644
> > drivers/net/qede/base/ecore_vf_api.h
> > create mode 100644 drivers/net/qede/base/ecore_vfpf_if.h
> > create mode 100644 drivers/net/qede/base/eth_common.h
> > create mode 100644 drivers/net/qede/base/mcp_public.h
> > create mode 100644 drivers/net/qede/base/nvm_cfg.h create mode
> > 100644 drivers/net/qede/base/reg_addr.h create mode 100644
> > drivers/net/qede/qede_eth_if.c create mode 100644
> > drivers/net/qede/qede_eth_if.h create mode 100644
> > drivers/net/qede/qede_ethdev.c create mode 100644
> > drivers/net/qede/qede_ethdev.h create mode 100644
> > drivers/net/qede/qede_if.h create mode 100644
> > drivers/net/qede/qede_logs.h create mode 100644
> > drivers/net/qede/qede_main.c create mode 100644
> > drivers/net/qede/qede_rxtx.c create mode 100644
> > drivers/net/qede/qede_rxtx.h create mode 100644
> > drivers/net/qede/rte_pmd_qede_version.map
> >
> > --
> > 1.7.10.3
prev parent reply other threads:[~2016-03-24 1:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 0:53 Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 01/10] qede: Add maintainers Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 02/10] qede: Add documentation Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 03/10] qede: Add license file Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 04/10] qede: Add base driver Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 05/10] qede: Add core driver Rasesh Mody
2016-03-21 17:32 ` Stephen Hemminger
2016-03-22 1:14 ` Rasesh Mody
2016-03-22 10:55 ` Bruce Richardson
2016-03-22 11:03 ` Bruce Richardson
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 06/10] qede: Add L2 support Rasesh Mody
2016-03-22 11:04 ` Bruce Richardson
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 07/10] qede: Add SRIOV support Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 08/10] qede: Add attention support Rasesh Mody
2016-03-22 11:07 ` Bruce Richardson
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 09/10] qede: Add DCBX support Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 10/10] qede: Enable PMD build Rasesh Mody
2016-03-22 11:21 ` Bruce Richardson
2016-03-22 11:21 ` [dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD Richardson, Bruce
2016-03-22 11:30 ` Bruce Richardson
2016-03-29 20:52 ` Rasesh Mody
2016-03-30 12:34 ` Bruce Richardson
2016-03-24 1:52 ` Rasesh Mody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2552F74A0BCCBE4DBE2AD218C81B2811086FED07@avmb3.qlogic.org \
--to=rasesh.mody@qlogic.com \
--cc=ameen.rahman@qlogic.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).