* Re: [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library
@ 2019-01-02 13:01 Ananyev, Konstantin
2019-01-02 14:29 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Ananyev, Konstantin @ 2019-01-02 13:01 UTC (permalink / raw)
To: Akhil Goyal, dev
Hi Akhil,
> Hi Konstantin,
>
> I just got results on running the ipsec-secgw on NXP hardware.
Thanks for doing that.
We don't have NXP HW, so would need more help from you.
>
> with -l option, I got a seg fault while running traffic. gdb suggest
> that pkt_func is not filled up and is NULL.
> #1 0x00000000004689bc in rte_ipsec_pkt_crypto_prepare (ss=0x17ad82d80,
> mb=0xffffffffe498, cop=0xffffffffdfc0, num=1)
> at
> /home/akhil/netperf/dpdk_up/dpdk-next-crypto/arm64-dpaa-linuxapp-gcc/include/rte_ipsec.h:115
> (gdb) p /x *ss
> $1 = {sa = 0x17ad7ea40, type = 0x3, {crypto = {ses = 0x165a4e900},
> security = {ses = 0x165a4e900, ctx = 0x0, ol_flags = 0x0}}, pkt_func = {
> prepare = 0x0, process = 0x0}}
>
I guess I understand the reason:
right now rte_ipsec_session_prepare() expects that
for all modes except RTE_SECURITY_ACTION_TYPE_NONE
security.ctx to be not NULL.
Which as I understand is not necessary for lookaside-proto.
Could you try the fix below?
If it would work as expected, I'll include these changes into v6?
Konstantin
---
examples/ipsec-secgw/ipsec_process.c | 24 ++++++++++++++++++++----
lib/librte_ipsec/ses.c | 11 +++++++++--
2 files changed, 29 insertions(+), 6 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c
index 7ab378f6a..e403c461a 100644
--- a/examples/ipsec-secgw/ipsec_process.c
+++ b/examples/ipsec-secgw/ipsec_process.c
@@ -87,19 +87,36 @@ enqueue_cop_bulk(struct cdev_qp *cqp, struct rte_crypto_op *cop[], uint32_t num)
}
static inline int
-fill_ipsec_session(struct rte_ipsec_session *ss, const struct ipsec_sa *sa)
+fill_ipsec_session(struct rte_ipsec_session *ss, struct ipsec_ctx *ctx,
+ struct ipsec_sa *sa)
{
+ int32_t rc;
+
/* setup crypto section */
if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE) {
+ if (sa->crypto_session == NULL) {
+ rc = create_session(ctx, sa);
+ if (rc != 0)
+ return rc;
+ }
ss->crypto.ses = sa->crypto_session;
/* setup session action type */
} else {
+ if (sa->sec_session == NULL) {
+ rc = create_session(ctx, sa);
+ if (rc != 0)
+ return rc;
+ }
ss->security.ses = sa->sec_session;
ss->security.ctx = sa->security_ctx;
ss->security.ol_flags = sa->ol_flags;
}
- return rte_ipsec_session_prepare(ss);
+ rc = rte_ipsec_session_prepare(ss);
+ if (rc != 0)
+ memset(ss, 0, sizeof(*ss));
+
+ return rc;
}
/*
@@ -209,8 +226,7 @@ ipsec_process(struct ipsec_ctx *ctx, struct ipsec_traffic *trf)
/* no valid HW session for that SA, try to create one */
if (ips->crypto.ses == NULL &&
- (create_session(ctx, sa) != 0 ||
- fill_ipsec_session(ips, sa) != 0))
+ fill_ipsec_session(ips, ctx, sa) != 0)
k = 0;
/* process packets inline */
diff --git a/lib/librte_ipsec/ses.c b/lib/librte_ipsec/ses.c
index 562c1423e..11580970e 100644
--- a/lib/librte_ipsec/ses.c
+++ b/lib/librte_ipsec/ses.c
@@ -14,8 +14,15 @@ session_check(struct rte_ipsec_session *ss)
if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE) {
if (ss->crypto.ses == NULL)
return -EINVAL;
- } else if (ss->security.ses == NULL || ss->security.ctx == NULL)
- return -EINVAL;
+ } else {
+ if (ss->security.ses == NULL)
+ return -EINVAL;
+ if ((ss->type == RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO ||
+ ss->type ==
+ RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL) &&
+ ss->security.ctx == NULL)
+ return -EINVAL;
+ }
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library
2019-01-02 13:01 [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library Ananyev, Konstantin
@ 2019-01-02 14:29 ` Akhil Goyal
2019-01-02 15:11 ` Ananyev, Konstantin
0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2019-01-02 14:29 UTC (permalink / raw)
To: Ananyev, Konstantin, dev
On 1/2/2019 6:31 PM, Ananyev, Konstantin wrote:
> Hi Akhil,
>
>> Hi Konstantin,
>>
>> I just got results on running the ipsec-secgw on NXP hardware.
> Thanks for doing that.
> We don't have NXP HW, so would need more help from you.
>
>> with -l option, I got a seg fault while running traffic. gdb suggest
>> that pkt_func is not filled up and is NULL.
>> #1 0x00000000004689bc in rte_ipsec_pkt_crypto_prepare (ss=0x17ad82d80,
>> mb=0xffffffffe498, cop=0xffffffffdfc0, num=1)
>> at
>> /home/akhil/netperf/dpdk_up/dpdk-next-crypto/arm64-dpaa-linuxapp-gcc/include/rte_ipsec.h:115
>> (gdb) p /x *ss
>> $1 = {sa = 0x17ad7ea40, type = 0x3, {crypto = {ses = 0x165a4e900},
>> security = {ses = 0x165a4e900, ctx = 0x0, ol_flags = 0x0}}, pkt_func = {
>> prepare = 0x0, process = 0x0}}
>>
> I guess I understand the reason:
> right now rte_ipsec_session_prepare() expects that
> for all modes except RTE_SECURITY_ACTION_TYPE_NONE
> security.ctx to be not NULL.
> Which as I understand is not necessary for lookaside-proto.
> Could you try the fix below?
> If it would work as expected, I'll include these changes into v6?
It did not crash this time with the below fix but the performance is
very very poor(~95% drop) if I use -l option with lookaside mode.
I have not analyzed the issue yet. Will be doing it on Friday.
> Konstantin
>
> ---
> examples/ipsec-secgw/ipsec_process.c | 24 ++++++++++++++++++++----
> lib/librte_ipsec/ses.c | 11 +++++++++--
> 2 files changed, 29 insertions(+), 6 deletions(-)
>
> diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c
> index 7ab378f6a..e403c461a 100644
> --- a/examples/ipsec-secgw/ipsec_process.c
> +++ b/examples/ipsec-secgw/ipsec_process.c
> @@ -87,19 +87,36 @@ enqueue_cop_bulk(struct cdev_qp *cqp, struct rte_crypto_op *cop[], uint32_t num)
> }
>
> static inline int
> -fill_ipsec_session(struct rte_ipsec_session *ss, const struct ipsec_sa *sa)
> +fill_ipsec_session(struct rte_ipsec_session *ss, struct ipsec_ctx *ctx,
> + struct ipsec_sa *sa)
> {
> + int32_t rc;
> +
> /* setup crypto section */
> if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE) {
> + if (sa->crypto_session == NULL) {
> + rc = create_session(ctx, sa);
> + if (rc != 0)
> + return rc;
> + }
> ss->crypto.ses = sa->crypto_session;
> /* setup session action type */
> } else {
> + if (sa->sec_session == NULL) {
> + rc = create_session(ctx, sa);
> + if (rc != 0)
> + return rc;
> + }
> ss->security.ses = sa->sec_session;
> ss->security.ctx = sa->security_ctx;
> ss->security.ol_flags = sa->ol_flags;
> }
>
> - return rte_ipsec_session_prepare(ss);
> + rc = rte_ipsec_session_prepare(ss);
> + if (rc != 0)
> + memset(ss, 0, sizeof(*ss));
> +
> + return rc;
> }
>
> /*
> @@ -209,8 +226,7 @@ ipsec_process(struct ipsec_ctx *ctx, struct ipsec_traffic *trf)
>
> /* no valid HW session for that SA, try to create one */
> if (ips->crypto.ses == NULL &&
> - (create_session(ctx, sa) != 0 ||
> - fill_ipsec_session(ips, sa) != 0))
> + fill_ipsec_session(ips, ctx, sa) != 0)
> k = 0;
>
> /* process packets inline */
> diff --git a/lib/librte_ipsec/ses.c b/lib/librte_ipsec/ses.c
> index 562c1423e..11580970e 100644
> --- a/lib/librte_ipsec/ses.c
> +++ b/lib/librte_ipsec/ses.c
> @@ -14,8 +14,15 @@ session_check(struct rte_ipsec_session *ss)
> if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE) {
> if (ss->crypto.ses == NULL)
> return -EINVAL;
> - } else if (ss->security.ses == NULL || ss->security.ctx == NULL)
> - return -EINVAL;
> + } else {
> + if (ss->security.ses == NULL)
> + return -EINVAL;
> + if ((ss->type == RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO ||
> + ss->type ==
> + RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL) &&
> + ss->security.ctx == NULL)
> + return -EINVAL;
> + }
>
> return 0;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library
2019-01-02 14:29 ` Akhil Goyal
@ 2019-01-02 15:11 ` Ananyev, Konstantin
0 siblings, 0 replies; 5+ messages in thread
From: Ananyev, Konstantin @ 2019-01-02 15:11 UTC (permalink / raw)
To: Akhil Goyal, dev
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, January 2, 2019 2:29 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library
>
>
>
> On 1/2/2019 6:31 PM, Ananyev, Konstantin wrote:
> > Hi Akhil,
> >
> >> Hi Konstantin,
> >>
> >> I just got results on running the ipsec-secgw on NXP hardware.
> > Thanks for doing that.
> > We don't have NXP HW, so would need more help from you.
> >
> >> with -l option, I got a seg fault while running traffic. gdb suggest
> >> that pkt_func is not filled up and is NULL.
> >> #1 0x00000000004689bc in rte_ipsec_pkt_crypto_prepare (ss=0x17ad82d80,
> >> mb=0xffffffffe498, cop=0xffffffffdfc0, num=1)
> >> at
> >> /home/akhil/netperf/dpdk_up/dpdk-next-crypto/arm64-dpaa-linuxapp-gcc/include/rte_ipsec.h:115
> >> (gdb) p /x *ss
> >> $1 = {sa = 0x17ad7ea40, type = 0x3, {crypto = {ses = 0x165a4e900},
> >> security = {ses = 0x165a4e900, ctx = 0x0, ol_flags = 0x0}}, pkt_func = {
> >> prepare = 0x0, process = 0x0}}
> >>
> > I guess I understand the reason:
> > right now rte_ipsec_session_prepare() expects that
> > for all modes except RTE_SECURITY_ACTION_TYPE_NONE
> > security.ctx to be not NULL.
> > Which as I understand is not necessary for lookaside-proto.
> > Could you try the fix below?
> > If it would work as expected, I'll include these changes into v6?
> It did not crash this time with the below fix but the performance is
> very very poor(~95% drop) if I use -l option with lookaside mode.
> I have not analyzed the issue yet. Will be doing it on Friday.
Did you run it with your previous change applied?
With drain_crypto_queues() moved under 'if (unlikely(diff_tsc > drain_tsc))'
condition?
If so, that could be the reason for such slowdown, see my other mail
regarding it.
Can you try to revert it (yes it would mean 5% drop for legacy mode)
and try again ((yes it would mean 5% drop for legacy mode,
but we can deal with it later)?
Konstantin
> >
> > ---
> > examples/ipsec-secgw/ipsec_process.c | 24 ++++++++++++++++++++----
> > lib/librte_ipsec/ses.c | 11 +++++++++--
> > 2 files changed, 29 insertions(+), 6 deletions(-)
> >
> > diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c
> > index 7ab378f6a..e403c461a 100644
> > --- a/examples/ipsec-secgw/ipsec_process.c
> > +++ b/examples/ipsec-secgw/ipsec_process.c
> > @@ -87,19 +87,36 @@ enqueue_cop_bulk(struct cdev_qp *cqp, struct rte_crypto_op *cop[], uint32_t num)
> > }
> >
> > static inline int
> > -fill_ipsec_session(struct rte_ipsec_session *ss, const struct ipsec_sa *sa)
> > +fill_ipsec_session(struct rte_ipsec_session *ss, struct ipsec_ctx *ctx,
> > + struct ipsec_sa *sa)
> > {
> > + int32_t rc;
> > +
> > /* setup crypto section */
> > if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE) {
> > + if (sa->crypto_session == NULL) {
> > + rc = create_session(ctx, sa);
> > + if (rc != 0)
> > + return rc;
> > + }
> > ss->crypto.ses = sa->crypto_session;
> > /* setup session action type */
> > } else {
> > + if (sa->sec_session == NULL) {
> > + rc = create_session(ctx, sa);
> > + if (rc != 0)
> > + return rc;
> > + }
> > ss->security.ses = sa->sec_session;
> > ss->security.ctx = sa->security_ctx;
> > ss->security.ol_flags = sa->ol_flags;
> > }
> >
> > - return rte_ipsec_session_prepare(ss);
> > + rc = rte_ipsec_session_prepare(ss);
> > + if (rc != 0)
> > + memset(ss, 0, sizeof(*ss));
> > +
> > + return rc;
> > }
> >
> > /*
> > @@ -209,8 +226,7 @@ ipsec_process(struct ipsec_ctx *ctx, struct ipsec_traffic *trf)
> >
> > /* no valid HW session for that SA, try to create one */
> > if (ips->crypto.ses == NULL &&
> > - (create_session(ctx, sa) != 0 ||
> > - fill_ipsec_session(ips, sa) != 0))
> > + fill_ipsec_session(ips, ctx, sa) != 0)
> > k = 0;
> >
> > /* process packets inline */
> > diff --git a/lib/librte_ipsec/ses.c b/lib/librte_ipsec/ses.c
> > index 562c1423e..11580970e 100644
> > --- a/lib/librte_ipsec/ses.c
> > +++ b/lib/librte_ipsec/ses.c
> > @@ -14,8 +14,15 @@ session_check(struct rte_ipsec_session *ss)
> > if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE) {
> > if (ss->crypto.ses == NULL)
> > return -EINVAL;
> > - } else if (ss->security.ses == NULL || ss->security.ctx == NULL)
> > - return -EINVAL;
> > + } else {
> > + if (ss->security.ses == NULL)
> > + return -EINVAL;
> > + if ((ss->type == RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO ||
> > + ss->type ==
> > + RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL) &&
> > + ss->security.ctx == NULL)
> > + return -EINVAL;
> > + }
> >
> > return 0;
> > }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library
2018-12-28 15:33 ` [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library Konstantin Ananyev
@ 2019-01-02 8:48 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2019-01-02 8:48 UTC (permalink / raw)
To: Konstantin Ananyev, dev
Hi Konstantin,
I just got results on running the ipsec-secgw on NXP hardware.
it seems there is a drop of around 10% for lookaside proto with normal
command(i.e. without -l option)
with -l option, I got a seg fault while running traffic. gdb suggest
that pkt_func is not filled up and is NULL.
#1 0x00000000004689bc in rte_ipsec_pkt_crypto_prepare (ss=0x17ad82d80,
mb=0xffffffffe498, cop=0xffffffffdfc0, num=1)
at
/home/akhil/netperf/dpdk_up/dpdk-next-crypto/arm64-dpaa-linuxapp-gcc/include/rte_ipsec.h:115
(gdb) p /x *ss
$1 = {sa = 0x17ad7ea40, type = 0x3, {crypto = {ses = 0x165a4e900},
security = {ses = 0x165a4e900, ctx = 0x0, ol_flags = 0x0}}, pkt_func = {
prepare = 0x0, process = 0x0}}
On 12/28/2018 9:03 PM, Konstantin Ananyev wrote:
> This patch series depends on the patch series:
>
> ipsec: new library for IPsec data-path processing
> http://patches.dpdk.org/patch/49332/
> http://patches.dpdk.org/patch/49333/
> http://patches.dpdk.org/patch/49334/
> http://patches.dpdk.org/patch/49335/
> http://patches.dpdk.org/patch/49336/
> http://patches.dpdk.org/patch/49337/
> http://patches.dpdk.org/patch/49338/
> http://patches.dpdk.org/patch/49339/
> http://patches.dpdk.org/patch/49340/
> http://patches.dpdk.org/patch/49341/
>
> to be applied first.
>
> v4 -> v5
> - Address Akhil comments:
> documentation update
> spell checks spacing etc.
> introduce rxoffload/txoffload parameters
> single SA for ipv6
> update Makefile
>
> v3 -> v4
> - fix few issues with the test scripts
> - update docs
>
> v2 -> v3
> - add IPv6 cases into test scripts
> - fixes for IPv6 support
> - fixes for inline-crypto support
> - some code restructuring
>
> v1 -> v2
> - Several bug fixes
>
> That series contians few bug-fixes and changes to make ipsec-secgw
> to utilize librte_ipsec library:
> - changes in the related data structures.
> - changes in the initialization code.
> - changes in the data-path code.
> - new command-line parameters to enable librte_ipsec codepath
> and related features.
> - test scripts to help automate ipsec-secgw functional testing.
>
> Note that right now by default current (non-librte_ipsec) code-path
> will be used. User has to run application with new command-line option
> ('-l')
> to enable new codepath.
> The main reason for that:
> - current librte_ipsec doesn't support all ipsec algorithms
> and features that the app does.
> - allow users to run both versions in parallel for some time
> to figure out any functional or performance degradation with the
> new code.
>
> Test scripts were run with the following crypto devices:
> - aesni_mb
> - aesni_gcm
> - qat
>
> Konstantin Ananyev (10):
> examples/ipsec-secgw: allow user to disable some RX/TX offloads
> examples/ipsec-secgw: allow to specify neighbour mac address
> examples/ipsec-secgw: fix crypto-op might never get dequeued
> examples/ipsec-secgw: fix outbound codepath for single SA
> examples/ipsec-secgw: make local variables static
> examples/ipsec-secgw: fix inbound SA checking
> examples/ipsec-secgw: make app to use ipsec library
> examples/ipsec-secgw: make data-path to use ipsec library
> examples/ipsec-secgw: add scripts for functional test
> doc: update ipsec-secgw guide and relelase notes
>
> doc/guides/rel_notes/release_19_02.rst | 14 +
> doc/guides/sample_app_ug/ipsec_secgw.rst | 159 +++++-
> examples/ipsec-secgw/Makefile | 5 +-
> examples/ipsec-secgw/ipsec-secgw.c | 480 ++++++++++++++----
> examples/ipsec-secgw/ipsec.c | 62 ++-
> examples/ipsec-secgw/ipsec.h | 67 +++
> examples/ipsec-secgw/ipsec_process.c | 341 +++++++++++++
> examples/ipsec-secgw/meson.build | 6 +-
> examples/ipsec-secgw/parser.c | 91 ++++
> examples/ipsec-secgw/parser.h | 8 +-
> examples/ipsec-secgw/sa.c | 263 +++++++++-
> examples/ipsec-secgw/sp4.c | 35 +-
> examples/ipsec-secgw/sp6.c | 35 +-
> examples/ipsec-secgw/test/common_defs.sh | 153 ++++++
> examples/ipsec-secgw/test/data_rxtx.sh | 62 +++
> examples/ipsec-secgw/test/linux_test4.sh | 63 +++
> examples/ipsec-secgw/test/linux_test6.sh | 64 +++
> examples/ipsec-secgw/test/run_test.sh | 80 +++
> .../test/trs_aescbc_sha1_common_defs.sh | 69 +++
> .../ipsec-secgw/test/trs_aescbc_sha1_defs.sh | 67 +++
> .../test/trs_aescbc_sha1_esn_atom_defs.sh | 5 +
> .../test/trs_aescbc_sha1_esn_defs.sh | 66 +++
> .../test/trs_aescbc_sha1_old_defs.sh | 5 +
> .../test/trs_aesgcm_common_defs.sh | 60 +++
> examples/ipsec-secgw/test/trs_aesgcm_defs.sh | 66 +++
> .../test/trs_aesgcm_esn_atom_defs.sh | 5 +
> .../ipsec-secgw/test/trs_aesgcm_esn_defs.sh | 66 +++
> .../ipsec-secgw/test/trs_aesgcm_old_defs.sh | 5 +
> .../test/tun_aescbc_sha1_common_defs.sh | 68 +++
> .../ipsec-secgw/test/tun_aescbc_sha1_defs.sh | 70 +++
> .../test/tun_aescbc_sha1_esn_atom_defs.sh | 5 +
> .../test/tun_aescbc_sha1_esn_defs.sh | 70 +++
> .../test/tun_aescbc_sha1_old_defs.sh | 5 +
> .../test/tun_aesgcm_common_defs.sh | 60 +++
> examples/ipsec-secgw/test/tun_aesgcm_defs.sh | 70 +++
> .../test/tun_aesgcm_esn_atom_defs.sh | 5 +
> .../ipsec-secgw/test/tun_aesgcm_esn_defs.sh | 70 +++
> .../ipsec-secgw/test/tun_aesgcm_old_defs.sh | 5 +
> 38 files changed, 2685 insertions(+), 145 deletions(-)
> create mode 100644 examples/ipsec-secgw/ipsec_process.c
> create mode 100644 examples/ipsec-secgw/test/common_defs.sh
> create mode 100644 examples/ipsec-secgw/test/data_rxtx.sh
> create mode 100644 examples/ipsec-secgw/test/linux_test4.sh
> create mode 100644 examples/ipsec-secgw/test/linux_test6.sh
> create mode 100644 examples/ipsec-secgw/test/run_test.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_common_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_esn_atom_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_esn_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_common_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_esn_atom_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_esn_defs.sh
> create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_common_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_esn_atom_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_esn_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_common_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_esn_atom_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_esn_defs.sh
> create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library
2018-12-14 16:40 [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads Konstantin Ananyev
@ 2018-12-28 15:33 ` Konstantin Ananyev
2019-01-02 8:48 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ananyev @ 2018-12-28 15:33 UTC (permalink / raw)
To: dev, dev; +Cc: akhil.goyal, Konstantin Ananyev
This patch series depends on the patch series:
ipsec: new library for IPsec data-path processing
http://patches.dpdk.org/patch/49332/
http://patches.dpdk.org/patch/49333/
http://patches.dpdk.org/patch/49334/
http://patches.dpdk.org/patch/49335/
http://patches.dpdk.org/patch/49336/
http://patches.dpdk.org/patch/49337/
http://patches.dpdk.org/patch/49338/
http://patches.dpdk.org/patch/49339/
http://patches.dpdk.org/patch/49340/
http://patches.dpdk.org/patch/49341/
to be applied first.
v4 -> v5
- Address Akhil comments:
documentation update
spell checks spacing etc.
introduce rxoffload/txoffload parameters
single SA for ipv6
update Makefile
v3 -> v4
- fix few issues with the test scripts
- update docs
v2 -> v3
- add IPv6 cases into test scripts
- fixes for IPv6 support
- fixes for inline-crypto support
- some code restructuring
v1 -> v2
- Several bug fixes
That series contians few bug-fixes and changes to make ipsec-secgw
to utilize librte_ipsec library:
- changes in the related data structures.
- changes in the initialization code.
- changes in the data-path code.
- new command-line parameters to enable librte_ipsec codepath
and related features.
- test scripts to help automate ipsec-secgw functional testing.
Note that right now by default current (non-librte_ipsec) code-path
will be used. User has to run application with new command-line option
('-l')
to enable new codepath.
The main reason for that:
- current librte_ipsec doesn't support all ipsec algorithms
and features that the app does.
- allow users to run both versions in parallel for some time
to figure out any functional or performance degradation with the
new code.
Test scripts were run with the following crypto devices:
- aesni_mb
- aesni_gcm
- qat
Konstantin Ananyev (10):
examples/ipsec-secgw: allow user to disable some RX/TX offloads
examples/ipsec-secgw: allow to specify neighbour mac address
examples/ipsec-secgw: fix crypto-op might never get dequeued
examples/ipsec-secgw: fix outbound codepath for single SA
examples/ipsec-secgw: make local variables static
examples/ipsec-secgw: fix inbound SA checking
examples/ipsec-secgw: make app to use ipsec library
examples/ipsec-secgw: make data-path to use ipsec library
examples/ipsec-secgw: add scripts for functional test
doc: update ipsec-secgw guide and relelase notes
doc/guides/rel_notes/release_19_02.rst | 14 +
doc/guides/sample_app_ug/ipsec_secgw.rst | 159 +++++-
examples/ipsec-secgw/Makefile | 5 +-
examples/ipsec-secgw/ipsec-secgw.c | 480 ++++++++++++++----
examples/ipsec-secgw/ipsec.c | 62 ++-
examples/ipsec-secgw/ipsec.h | 67 +++
examples/ipsec-secgw/ipsec_process.c | 341 +++++++++++++
examples/ipsec-secgw/meson.build | 6 +-
examples/ipsec-secgw/parser.c | 91 ++++
examples/ipsec-secgw/parser.h | 8 +-
examples/ipsec-secgw/sa.c | 263 +++++++++-
examples/ipsec-secgw/sp4.c | 35 +-
examples/ipsec-secgw/sp6.c | 35 +-
examples/ipsec-secgw/test/common_defs.sh | 153 ++++++
examples/ipsec-secgw/test/data_rxtx.sh | 62 +++
examples/ipsec-secgw/test/linux_test4.sh | 63 +++
examples/ipsec-secgw/test/linux_test6.sh | 64 +++
examples/ipsec-secgw/test/run_test.sh | 80 +++
.../test/trs_aescbc_sha1_common_defs.sh | 69 +++
.../ipsec-secgw/test/trs_aescbc_sha1_defs.sh | 67 +++
.../test/trs_aescbc_sha1_esn_atom_defs.sh | 5 +
.../test/trs_aescbc_sha1_esn_defs.sh | 66 +++
.../test/trs_aescbc_sha1_old_defs.sh | 5 +
.../test/trs_aesgcm_common_defs.sh | 60 +++
examples/ipsec-secgw/test/trs_aesgcm_defs.sh | 66 +++
.../test/trs_aesgcm_esn_atom_defs.sh | 5 +
.../ipsec-secgw/test/trs_aesgcm_esn_defs.sh | 66 +++
.../ipsec-secgw/test/trs_aesgcm_old_defs.sh | 5 +
.../test/tun_aescbc_sha1_common_defs.sh | 68 +++
.../ipsec-secgw/test/tun_aescbc_sha1_defs.sh | 70 +++
.../test/tun_aescbc_sha1_esn_atom_defs.sh | 5 +
.../test/tun_aescbc_sha1_esn_defs.sh | 70 +++
.../test/tun_aescbc_sha1_old_defs.sh | 5 +
.../test/tun_aesgcm_common_defs.sh | 60 +++
examples/ipsec-secgw/test/tun_aesgcm_defs.sh | 70 +++
.../test/tun_aesgcm_esn_atom_defs.sh | 5 +
.../ipsec-secgw/test/tun_aesgcm_esn_defs.sh | 70 +++
.../ipsec-secgw/test/tun_aesgcm_old_defs.sh | 5 +
38 files changed, 2685 insertions(+), 145 deletions(-)
create mode 100644 examples/ipsec-secgw/ipsec_process.c
create mode 100644 examples/ipsec-secgw/test/common_defs.sh
create mode 100644 examples/ipsec-secgw/test/data_rxtx.sh
create mode 100644 examples/ipsec-secgw/test/linux_test4.sh
create mode 100644 examples/ipsec-secgw/test/linux_test6.sh
create mode 100644 examples/ipsec-secgw/test/run_test.sh
create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_common_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_esn_atom_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_esn_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_common_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_esn_atom_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_esn_defs.sh
create mode 100644 examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_common_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_esn_atom_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_esn_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_common_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_esn_atom_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_esn_defs.sh
create mode 100644 examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-02 15:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-02 13:01 [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library Ananyev, Konstantin
2019-01-02 14:29 ` Akhil Goyal
2019-01-02 15:11 ` Ananyev, Konstantin
-- strict thread matches above, loose matches on Subject: below --
2018-12-14 16:40 [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads Konstantin Ananyev
2018-12-28 15:33 ` [dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library Konstantin Ananyev
2019-01-02 8:48 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).