From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/bpf: fix compilation issue
Date: Wed, 31 Jul 2019 07:26:26 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580168A5FDA7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <10104652.MOWmfaWtsW@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, July 30, 2019 6:53 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; olivier.matz@6wind.com
> Subject: Re: [dpdk-stable] [PATCH] examples/bpf: fix compilation issue
>
> 30/07/2019 12:19, Konstantin Ananyev:
> > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are
> > failing to compile with latest dpdk.org master.
> > The reason is changes in some core DPDK header files, that causes
> > now inclusion of x86 specific headers.
> > To overcome the issue, minimize inclusion of DPDK header files
> > into BPF source code.
> >
> > Bugzilla ID: 321
> >
> > Fixes: 9dfc06c26a8b ("test/bpf: add samples")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Michel Machado <michel@digirati.com.br>
> > Suggested-by: Michel Machado <michel@digirati.com.br>
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
> > examples/bpf/mbuf.h | 24 ++++++++++++++++++++++--
> > 1 file changed, 22 insertions(+), 2 deletions(-)
>
> I think that's really a bad idea to have this file.
> The BPF applications are supposed to update their own copy of mbuf?
Right now, yes (same as KNI).
> Please could you try to include rte_mbuf.h
> instead of duplicating the mbuf layout?
I don't think it is possible without some rework on rte_mbuf.h itself.
I thought about that, but for that we'll probably need to put just
struct rte_mbuf definition into a separate file (rte_mbuf_core.h or so)
and might be some related definitions into rte_common.h or so.
Then re_mbuf.h will include rte_mbuf_core.h while bpf (and might be KNI?)
can include just rte_mbuf_core.h without any extra arch specific headers.
Another alternative probably to define bpf as a separate arch
(though don't know how big effort it will be).
I planned to try something like that, but then totally forgot.
And now it is too late, we are at RC4 already .
Konstantin
next prev parent reply other threads:[~2019-07-31 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 10:19 [dpdk-dev] " Konstantin Ananyev
2019-07-30 17:53 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-07-31 7:26 ` Ananyev, Konstantin [this message]
2019-08-06 10:32 ` Thomas Monjalon
2019-07-31 3:16 ` [dpdk-dev] " Varghese, Vipin
2019-07-31 7:04 ` Ananyev, Konstantin
2019-07-31 8:20 ` Varghese, Vipin
2019-07-31 8:22 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580168A5FDA7@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).