Re: [dpdk-dev] [PATCH v2 0/3] enhance TX checksum command and csum forwarding engine

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Tuesday, December 09, 2014 1:18 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 0/3] enhance TX checksum command and csum forwarding engine
> 
> In the current codes, the "tx_checksum set (ip|udp|tcp|sctp|vxlan) (hw|sw) (port-id)" command is not easy to understand and
> extend, so the patch set enhances the tx_checksum command and reworks csum forwarding engine due to the change of
> tx_checksum command.
> The main changes of the tx_checksum command are listed below,
> 
> 1> add "tx_checksum set tunnel (hw|sw|none) (port-id)" command
> 
> The command is used to set/clear tunnel flag that is used to tell the NIC that the packetg is a tunneing packet and application want
> hardware TX checksum offload for outer layer, or inner layer, or both.
> 
> The 'none' option means that user treat tunneling packet as ordinary packet when using the csum forward engine.
> for example, let say we have a tunnel packet:
> eth_hdr_out/ipv4_hdr_out/udp_hdr_out/vxlan_hdr/ehtr_hdr_in/ipv4_hdr_in/tcp_hdr_in. one of several scenarios:
> 
> 1) User requests HW offload for ipv4_hdr_out  checksum, and doesn't care is it a tunnelled packet or not. So he sets:
> 
> tx_checksum set tunnel none 0
> 
> tx_checksum set ip hw 0
> 
> So for such case we should set tx_tunnel to 'none'.
> 
> 2> add "tx_checksum set outer-ip (hw|sw) (port-id)" command
> 
> The command is used to set/clear outer IP flag that is used to tell the NIC that application want hardware offload for outer layer.
> 
> 3> remove the 'vxlan' option from the  "tx_checksum set (ip|udp|tcp|sctp|vxlan) (hw|sw) (port-id)" command
> 
> The command is used to set IP, UDP, TCP and SCTP TX checksum flag. In the case of tunneling packet, the IP, UDP, TCP and SCTP flags
> always concern inner layer.
> 
> Moreover, replace the TESTPMD_TX_OFFLOAD_VXLAN_CKSUM flag with TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM flag and add the
> TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM and TESTPMD_TX_OFFLOAD_NON_TUNNEL_CKSUM flag in test-pmd application.
> 
> v2 change:
>      redefine the 'none' behaviour for "tx_checksum set tunnel (hw|sw|none) (port-id)" command.
> 
> Jijiang Liu (3):
>   add outer IP offload capability in librte_ether.
>   add outer IP checksum capability in i40e PMD
>   testpmd command lines of the tx_checksum and csum forwarding rework
> 
>  app/test-pmd/cmdline.c            |  201 +++++++++++++++++++++++++++++++++++--
>  app/test-pmd/csumonly.c           |   35 ++++---
>  app/test-pmd/testpmd.h            |    6 +-
>  lib/librte_ether/rte_ethdev.h     |    1 +
>  lib/librte_pmd_i40e/i40e_ethdev.c |    3 +-
>  5 files changed, 218 insertions(+), 28 deletions(-)
> 

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> --
> 1.7.7.6