DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information
Date: Fri, 24 Jul 2015 09:05:10 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836A671C4@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1441832.QYmNKRXLMA@xps13>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, July 23, 2015 5:17 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information
> 
> 2015-07-23 10:52, Ananyev, Konstantin:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > Konstantin Ananyev <konstantin.ananyev@intel.com> wrote:
> > > > Add the ability for the upper layer to query RX/TX queue information.
> [...]
> > > Since all this data should be rxconf already, Is it possible
> > > to do a generic version of this and not have to change every driver.
> >
> > I don't think it is possible to implement these two functions at rte_etdev level only.
> > At least not with current ethdev/PMD implementation:
> > -  Inside struct rte_eth_dev_info we have only: 'struct rte_eth_rxconf default_rxconf;'.
> > We don't have rxconf here for each configured rx queue.
> > That information is maintained by PMD and inside PMD, different devices have different format for queue structure.
> > - rte_eth_rxq_info contains not only rxconf but some extra information: mempool in use by that queue,
> >  min/max possible number of descriptors.
> >  Also my intention was that in future that structure would be extended to provide some RT info about queue:
> >  (number of free/used descriptors from SW point of view, etc).
> 
> Isn't it what rte_eth_rx_queue_count() provides?

Not exactly.
rte_eth_rx_queue_count() actually scans HW descriptors to check their status.
I was thinking about returning just a snapshot of SW state: how many free/used RXDs are from PMD perspective
(just by collecting info from *_rx_queue structure, without reading actual HW registers/descriptors).
Anyway, right now it is not implemented - it is just a thought for future expansion.
Konstantin


> Maybe we should deprecate it in favor of rte_eth_rx_queue_info_get().

  reply	other threads:[~2015-07-24  9:05 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 12:19 [dpdk-dev] [PATCHv3 0/5] " Konstantin Ananyev
2015-07-20 12:19 ` [dpdk-dev] [PATCHv3 1/5] " Konstantin Ananyev
2015-07-22 16:50   ` Zhang, Helin
2015-07-22 17:00     ` Ananyev, Konstantin
2015-07-22 20:45       ` Thomas Monjalon
2015-07-22 18:28   ` [dpdk-dev] [PATCHv4 0/5] " Konstantin Ananyev
2015-07-23 12:48     ` Thomas Monjalon
2015-07-22 18:28   ` [dpdk-dev] [PATCHv4 1/5] " Konstantin Ananyev
2015-07-22 19:48     ` Stephen Hemminger
2015-07-23 10:52       ` Ananyev, Konstantin
2015-07-23 16:17         ` Thomas Monjalon
2015-07-24  9:05           ` Ananyev, Konstantin [this message]
2015-07-23 16:26     ` Thomas Monjalon
2015-07-24  9:15       ` Ananyev, Konstantin
2015-07-24  9:24         ` Thomas Monjalon
2015-07-24 10:50           ` Ananyev, Konstantin
2015-07-24 12:40             ` Thomas Monjalon
2015-07-22 18:28   ` [dpdk-dev] [PATCHv4 2/5] i40e: add support for eth_(rxq|txq)_info_get Konstantin Ananyev
2015-07-22 18:28   ` [dpdk-dev] [PATCHv4 3/5] ixgbe: " Konstantin Ananyev
2015-07-22 18:28   ` [dpdk-dev] [PATCHv4 4/5] e1000: " Konstantin Ananyev
2015-07-22 18:28   ` [dpdk-dev] [PATCHv4 5/5] testpmd: add new command to display RX/TX queue information Konstantin Ananyev
2015-07-20 12:19 ` [dpdk-dev] [PATCHv3 2/5] i40e: add support for eth_(rxq|txq)_info_get Konstantin Ananyev
2015-07-22 17:02   ` Zhang, Helin
2015-07-20 12:19 ` [dpdk-dev] [PATCHv3 3/5] ixgbe: " Konstantin Ananyev
2015-07-22 17:03   ` Zhang, Helin
2015-07-20 12:19 ` [dpdk-dev] [PATCHv3 4/5] e1000: " Konstantin Ananyev
2015-07-22 17:04   ` Zhang, Helin
2015-07-20 12:19 ` [dpdk-dev] [PATCHv3 5/5] testpmd: add new command to display RX/TX queue information Konstantin Ananyev
2015-07-22 17:16   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB97725836A671C4@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).