From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address.
Date: Wed, 9 Mar 2016 13:17:13 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B1A457@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1457457027-21419-4-git-send-email-bernard.iremonger@intel.com>
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Tuesday, March 08, 2016 5:10 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin; Lu, Wenzhuo; Wu, Jingjing; Iremonger, Bernard
> Subject: [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address.
>
> Call the ixgbevf_remove_mac_addr() function in the ixgbevf_dev_close()
> function to ensure that the VF traffic goes to the PF after stop,
> close and detach of the VF.
>
> Fixes: af75078fece3 ("first public release")
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 759177a..96b42f8 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3911,8 +3911,12 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)
>
> ixgbe_dev_free_queues(dev);
>
> - /* reprogram the RAR[0] in case user changed it. */
> - ixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV);
> + /**
> + * Remove the VF MAC address ro ensure
> + * that the VF traffic goes to the PF
> + * after stop, close and detach of the VF
> + **/
> + ixgbevf_remove_mac_addr(dev, 0);
> }
>
> static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.6.3
next prev parent reply other threads:[~2016-03-09 13:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:19 [dpdk-dev] [PATCH 0/3] ixgbe fixes Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 3/3] ixgbe: allow use of zero MAC address with VF Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 0/3 v2] ixgbe fixes Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 1/3 v2] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 2/3 v2] ixgbe: add more information to the error message Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 3/3 v2] ixgbe: fix setting of VF MAC address Bernard Iremonger
2016-02-29 17:03 ` [dpdk-dev] [PATCH 0/3 v2] ixgbe fixes Ananyev, Konstantin
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 0/3] " Bernard Iremonger
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 3/3] ixgbe: fix dev_close to remove VF MAC address Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 0/3] ixgbe fixes Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address Bernard Iremonger
2016-03-09 13:17 ` Ananyev, Konstantin [this message]
2016-03-11 17:19 ` [dpdk-dev] [PATCH v4 0/3] ixgbe fixes Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B1A457@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).