From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Liu, Yong" <yong.liu@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segments as free
Date: Thu, 10 May 2018 17:03:24 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258AEDC56D7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <88ac531b5b13288971edcee16785c8cc612bdfe0.1525342009.git.anatoly.burakov@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Thursday, May 3, 2018 11:11 AM
> To: dev@dpdk.org
> Cc: Liu, Yong <yong.liu@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segments as free
>
> Currently, page deallocation might fail if allocator cannot get page
> fd, which will leave VA space still mapped, and will also not mark
> page as free.
>
> Fix page deallocation function to always unmap space before trying
> to get rid of the page itself, and always mark page as free even if
> page deallocation failed.
>
> Fixes: a5ff05d60fc5 ("mem: support unmapping pages at runtime")
> Fixes: 1a7dc2252f28 ("mem: revert to using flock and add per-segment lockfiles")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2018-05-10 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:11 [dpdk-dev] [PATCH 1/3] mem: fix index for unmapping segments on failure Anatoly Burakov
2018-05-03 10:11 ` [dpdk-dev] [PATCH 2/3] memalloc: fix wrong return value on freeing segment on fail Anatoly Burakov
2018-05-10 16:03 ` Ananyev, Konstantin
2018-05-03 10:11 ` [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segments as free Anatoly Burakov
2018-05-10 17:03 ` Ananyev, Konstantin [this message]
2018-05-04 8:13 ` [dpdk-dev] [PATCH 1/3] mem: fix index for unmapping segments on failure Liu, Yong
2018-05-10 17:07 ` Ananyev, Konstantin
2018-05-14 1:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258AEDC56D7@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).