[dpdk-dev] [PATCH] crypto/libcrypto: fix init function names

[dpdk-dev] [PATCH] crypto/libcrypto: fix init function names

[Pablo de Lara]

All init/uninit function names in the virtual devices have been renamed,
so they finish with probe or remove, so to keep consistency,
same thing should be done in this PMD.

Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/crypto/libcrypto/rte_libcrypto_pmd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/libcrypto/rte_libcrypto_pmd.c b/drivers/crypto/libcrypto/rte_libcrypto_pmd.c
index 535fb57..b2c571d 100644
--- a/drivers/crypto/libcrypto/rte_libcrypto_pmd.c
+++ b/drivers/crypto/libcrypto/rte_libcrypto_pmd.c
@@ -42,7 +42,7 @@
 
 #include "rte_libcrypto_pmd_private.h"
 
-static int cryptodev_libcrypto_uninit(const char *name);
+static int cryptodev_libcrypto_remove(const char *name);
 
 /*----------------------------------------------------------------------------*/
 
@@ -1008,13 +1008,13 @@ cryptodev_libcrypto_create(const char *name,
 init_error:
 	LIBCRYPTO_LOG_ERR("driver %s: cryptodev_libcrypto_create failed", name);
 
-	cryptodev_libcrypto_uninit(crypto_dev_name);
+	cryptodev_libcrypto_remove(crypto_dev_name);
 	return -EFAULT;
 }
 
 /** Initialise LIBCRYPTO crypto device */
 static int
-cryptodev_libcrypto_init(const char *name,
+cryptodev_libcrypto_probe(const char *name,
 		const char *input_args)
 {
 	struct rte_crypto_vdev_init_params init_params = {
@@ -1037,7 +1037,7 @@ cryptodev_libcrypto_init(const char *name,
 
 /** Uninitialise LIBCRYPTO crypto device */
 static int
-cryptodev_libcrypto_uninit(const char *name)
+cryptodev_libcrypto_remove(const char *name)
 {
 	if (name == NULL)
 		return -EINVAL;
@@ -1050,8 +1050,8 @@ cryptodev_libcrypto_uninit(const char *name)
 }
 
 static struct rte_vdev_driver cryptodev_libcrypto_pmd_drv = {
-	.probe = cryptodev_libcrypto_init,
-	.remove = cryptodev_libcrypto_uninit
+	.probe = cryptodev_libcrypto_probe,
+	.remove = cryptodev_libcrypto_remove
 };
 
 DRIVER_REGISTER_VDEV(CRYPTODEV_NAME_LIBCRYPTO_PMD, cryptodev_libcrypto_pmd_drv);
-- 
2.7.4

Re: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Tuesday, October 11, 2016 2:15 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names
> 
> All init/uninit function names in the virtual devices have been renamed, so
> they finish with probe or remove, so to keep consistency, same thing should be
> done in this PMD.
> 
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, October 13, 2016 10:56 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: RE: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Tuesday, October 11, 2016 2:15 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names
> >
> > All init/uninit function names in the virtual devices have been renamed, so
> > they finish with probe or remove, so to keep consistency, same thing should
> be
> > done in this PMD.
> >
> > Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.

Pablo