DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] dpdk: fix a crash during rte_table_hash_key16_ext overload
@ 2015-03-03 14:16 miroslaw.walukiewicz
  2015-03-23 13:33 ` Dumitrescu, Cristian
  0 siblings, 1 reply; 3+ messages in thread
From: miroslaw.walukiewicz @ 2015-03-03 14:16 UTC (permalink / raw)
  To: dev

From: Miroslaw Walukiewicz <miroslaw.walukiewicz@intel.com>

The hash_key16_ext table allocates a cache entries to support
table overload cases.

The crash can occur when cache entry is free after use. The problem
is with computing the index of the free cache entry.

The patch fixes a problem.

Signed-off-by: Mirek Walukiewicz <miroslaw.walukiewicz@intel.com>
---
 lib/librte_table/rte_table_hash_key16.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c
index ee5f639..e0c99bd 100644
--- a/lib/librte_table/rte_table_hash_key16.c
+++ b/lib/librte_table/rte_table_hash_key16.c
@@ -535,9 +535,8 @@ rte_table_hash_entry_delete_key16_ext(
 
 					memset(bucket, 0,
 						sizeof(struct rte_bucket_4_16));
-					bucket_index = (bucket -
-						((struct rte_bucket_4_16 *)
-						f->memory)) - f->n_buckets;
+					bucket_index = (((uint8_t *)bucket - 
+						(uint8_t *)f->memory)/f->bucket_size) - f->n_buckets;
 					f->stack[f->stack_pos++] = bucket_index;
 				}
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] dpdk: fix a crash during rte_table_hash_key16_ext overload
  2015-03-03 14:16 [dpdk-dev] [PATCH] dpdk: fix a crash during rte_table_hash_key16_ext overload miroslaw.walukiewicz
@ 2015-03-23 13:33 ` Dumitrescu, Cristian
  2015-03-27 11:17   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2015-03-23 13:33 UTC (permalink / raw)
  To: Walukiewicz, Miroslaw, dev; +Cc: Nemeth, Balazs



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> miroslaw.walukiewicz@intel.com
> Sent: Tuesday, March 3, 2015 2:16 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] dpdk: fix a crash during
> rte_table_hash_key16_ext overload
> 
> From: Miroslaw Walukiewicz <miroslaw.walukiewicz@intel.com>
> 
> The hash_key16_ext table allocates a cache entries to support
> table overload cases.
> 
> The crash can occur when cache entry is free after use. The problem
> is with computing the index of the free cache entry.
> 
> The patch fixes a problem.
> 
> Signed-off-by: Mirek Walukiewicz <miroslaw.walukiewicz@intel.com>
> ---
>  lib/librte_table/rte_table_hash_key16.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_table/rte_table_hash_key16.c
> b/lib/librte_table/rte_table_hash_key16.c
> index ee5f639..e0c99bd 100644
> --- a/lib/librte_table/rte_table_hash_key16.c
> +++ b/lib/librte_table/rte_table_hash_key16.c
> @@ -535,9 +535,8 @@ rte_table_hash_entry_delete_key16_ext(
> 
>  					memset(bucket, 0,
>  						sizeof(struct
> rte_bucket_4_16));
> -					bucket_index = (bucket -
> -						((struct rte_bucket_4_16 *)
> -						f->memory)) - f->n_buckets;
> +					bucket_index = (((uint8_t *)bucket -
> +						(uint8_t *)f->memory)/f-
> >bucket_size) - f->n_buckets;
>  					f->stack[f->stack_pos++] =
> bucket_index;
>  				}
> 

Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Mirek, identical issue is found at identical place in rte_table_hash_key8.c and rte_table_hash_key32.c, would you please submit the same fix for those as well?

Thanks,
Cristian


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] dpdk: fix a crash during rte_table_hash_key16_ext overload
  2015-03-23 13:33 ` Dumitrescu, Cristian
@ 2015-03-27 11:17   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-27 11:17 UTC (permalink / raw)
  To: Walukiewicz, Miroslaw; +Cc: dev, Nemeth, Balazs

> > The hash_key16_ext table allocates a cache entries to support
> > table overload cases.
> > 
> > The crash can occur when cache entry is free after use. The problem
> > is with computing the index of the free cache entry.
> > 
> > The patch fixes a problem.
> > 
> > Signed-off-by: Mirek Walukiewicz <miroslaw.walukiewicz@intel.com>
> 
> Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

> Mirek, identical issue is found at identical place in rte_table_hash_key8.c
> and rte_table_hash_key32.c, would you please submit the same fix for those as well?

Merged (Maciej's patch)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-27 11:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 14:16 [dpdk-dev] [PATCH] dpdk: fix a crash during rte_table_hash_key16_ext overload miroslaw.walukiewicz
2015-03-23 13:33 ` Dumitrescu, Cristian
2015-03-27 11:17   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).