[dpdk-dev] [PATCH] examples/ip_pipeline: fix memory leak

[dpdk-dev] [PATCH] examples/ip_pipeline: fix memory leak

[Jasvinder Singh]

Close the file stream before returning from the function to avoid
memory leak.

Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command")
Coverty Issue: 272605

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/ip_pipeline/cli.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 199a31f..20fbefb 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -4158,6 +4158,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table,
 
 		if (parse_tokenize_string(line, tokens, &n_tokens)) {
 			*line_number = l;
+			fclose(f);
 			return -EINVAL;
 		}
 
@@ -4172,6 +4173,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table,
 			(tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) ||
 			(strlen(tokens[2]) != 1)) {
 			*line_number = l;
+			fclose(f);
 			return -EINVAL;
 		}
 
@@ -4193,6 +4195,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table,
 
 		default:
 			*line_number = l;
+			fclose(f);
 			return -EINVAL;
 		}
 
-- 
2.9.3

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix memory leak

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, April 16, 2018 5:03 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix memory leak
> 
> Close the file stream before returning from the function to avoid
> memory leak.
> 
> Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update
> command")
> Coverty Issue: 272605
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/ip_pipeline/cli.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 199a31f..20fbefb 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -4158,6 +4158,7 @@ load_dscp_table(struct
> rte_table_action_dscp_table *dscp_table,
> 
>  		if (parse_tokenize_string(line, tokens, &n_tokens)) {
>  			*line_number = l;
> +			fclose(f);
>  			return -EINVAL;
>  		}
> 
> @@ -4172,6 +4173,7 @@ load_dscp_table(struct
> rte_table_action_dscp_table *dscp_table,
>  			(tc_queue_id >=
> RTE_TABLE_ACTION_TC_QUEUE_MAX) ||
>  			(strlen(tokens[2]) != 1)) {
>  			*line_number = l;
> +			fclose(f);
>  			return -EINVAL;
>  		}
> 
> @@ -4193,6 +4195,7 @@ load_dscp_table(struct
> rte_table_action_dscp_table *dscp_table,
> 
>  		default:
>  			*line_number = l;
> +			fclose(f);
>  			return -EINVAL;
>  		}
> 
> --
> 2.9.3

Acked-by: Cristian.Dumitrescu <cristian.dumitrescu@intel.com>

Applied to next-pipeline tree, thanks!