[PATCH v2 0/3] doc/hns3: update the features for hns3

[PATCH v2 0/3] doc/hns3: update the features for hns3

[Huisong Li]

This series fix some feature description and update features for hns3.

Hope this series merge into 23.11.

---
 v2: patch [2/3] add fixes tag of each feature to track the relevant code
     commit.

Huisong Li (3):
  doc/hns3: fix compilation option about max queue number
  doc/hns3: update the features for hns3
  doc/hns3: fix the usage description for RSS flow

 doc/guides/nics/hns3.rst | 55 ++++++++++++++++++++++++++++------------
 1 file changed, 39 insertions(+), 16 deletions(-)

-- 
2.33.0

[PATCH v2 1/3] doc/hns3: fix compilation option about max queue number

[Huisong Li]

This patch fixes the description of compilation option about setting max
queue number. The maximum queue number of HIP09 and HIP10 is determined by
the RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF and the value the firmware report.

Fixes: 21938cf4e43e ("doc: add build config option in hns3 guide")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index ee774639d3..7eac1b3c92 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -69,7 +69,8 @@ The following options can be modified in the ``config/rte_config.h`` file.
 
 - ``RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF`` (default ``256``)
 
-  Number of MAX queues reserved for PF.
+  Number of MAX queues reserved for PF on HIP09 and HIP10. The MAX queue
+  number is also determined by the value the firmware report.
 
 Runtime Configuration
 ~~~~~~~~~~~~~~~~~~~~~
-- 
2.33.0

[PATCH v2 2/3] doc/hns3: update the features for hns3

[Huisong Li]

Update the features for hns3.

- "Basic stats" and "Extended stats" supported by
Fixes: 8839c5e202f3 ("net/hns3: support device stats")

- "Traffic Management API" supported by
Fixes: c09c7847d892 ("net/hns3: support traffic management")

- "Speed capabilities" supported by
Fixes: 09e0de1f411b ("net/hns3: report speed capability for PF")

- "Link Auto-negotiation" supported by
Fixes: bdaf190f8235 ("net/hns3: support link speed autoneg for PF")

- "Link flow control" supported by
Fixes: 62e3ccc2b94c ("net/hns3: support flow control")

- "Dump private info from device" supported by
Fixes: 1a03c659cb9d ("net/hns3: dump device basic info")

- "FW version" supported by
Fixes: 1f5ca0b460cd ("net/hns3: support some device operations")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 7eac1b3c92..11d0c04884 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -30,7 +30,6 @@ Features of the HNS3 PMD are:
 - DCB
 - Scattered and gather for TX and RX
 - Vector Poll mode driver
-- Dump register
 - SR-IOV VF
 - Multi-process
 - MAC/VLAN filter
@@ -38,6 +37,15 @@ Features of the HNS3 PMD are:
 - NUMA support
 - Generic flow API
 - IEEE1588/802.1AS timestamping
+- Basic stats
+- Extended stats
+- Traffic Management API
+- Speed capabilities
+- Link Auto-negotiation
+- Link flow control
+- Dump register
+- Dump private info from device
+- FW version
 
 Prerequisites
 -------------
-- 
2.33.0

[PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow

[Huisong Li]

The hns3 driver supports for creating rule base on input tuple, hash key,
queues and hash algorithm. But hash key, queues and hash algorithm are the
global configuration for hardware which will affect other rules. The rule
just setting input tuple is completely independent.

Fixes: 63a0f65c9572 ("doc: add more description in hns3 guide")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 42 ++++++++++++++++++++++++++--------------
 1 file changed, 28 insertions(+), 14 deletions(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 11d0c04884..e260b301a8 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -239,36 +239,50 @@ Generic flow API
 
 - ``RSS Flow``
 
-  RSS Flow supports to set hash input set, hash function, enable hash
-  and configure queues.
-  For example:
-  Configure queues as queue 0, 1, 2, 3.
+  RSS Flow supports for creating rule base on input tuple, hash key, queues
+  and hash algorithm. But hash key, queues and hash algorithm are the global
+  configuration for hardware which will affect other rules. The rule just
+  setting input tuple is completely independent.
+
+  Run ``testpmd``:
 
   .. code-block:: console
 
-    testpmd> flow create 0 ingress pattern end actions rss types end \
-      queues 0 1 2 3 end / end
+    dpdk-testpmd -a 0000:7d:00.0 -l 10-18 -- -i --rxq=8 --txq=8
+
+  All IP packets can be distributed to 8 queues.
 
-  Enable hash and set input set for IPv4-TCP.
+  Set ipv4-tcp packet is distributed to 8 queues based on L3/L4 SRC only.
 
   .. code-block:: console
 
-    testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end \
-      actions rss types ipv4-tcp l3-src-only end queues end / end
+    testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions \
+             rss types ipv4-tcp l4-src-only l3-src-only end queues end / end
 
-  Set symmetric hash enable for flow type IPv4-TCP.
+  Disable ipv4 packet RSS hash.
 
   .. code-block:: console
 
-    testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end \
-      actions rss types ipv4-tcp end queues end func symmetric_toeplitz / end
+    testpmd> flow create 0 ingress pattern eth / ipv4 / end actions rss \
+             types none end queues end / end
 
-  Set hash function as simple xor.
+  Set hash function as symmetric toeplitz.
 
   .. code-block:: console
 
     testpmd> flow create 0 ingress pattern end actions rss types end \
-      queues end func simple_xor / end
+             queues end func symmetric_toeplitz / end
+
+  In this case, all packets that enabled RSS are hashed using symmetric
+  toeplitz algorithm.
+
+  Flush all RSS rules
+
+  .. code-block:: console
+
+    testpmd> flow flush 0
+
+  The RSS configurations of hardwre is back to the one ethdev ops set.
 
 Statistics
 ----------
-- 
2.33.0

RE: [PATCH v2 1/3] doc/hns3: fix compilation option about max queue number

[haijie]

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]


Acked-by: Jie Hai <haijie1@huawei.com<mailto:haijie1@huawei.com>>


________________________________

Hai Jie
Email：haijie1@huawei.com<mailto:haijie1@huawei.com>

发件人： lihuisong (C)<lihuisong@huawei.com<mailto:lihuisong@huawei.com>>
收件人： dev<dev@dpdk.org<mailto:dev@dpdk.org>>;ferruh.yigit<ferruh.yigit@amd.com<mailto:ferruh.yigit@amd.com>>;haijie<haijie1@huawei.com<mailto:haijie1@huawei.com>>;Zhuangyuzeng (Yisen)<yisen.zhuang@huawei.com<mailto:yisen.zhuang@huawei.com>>;humin (Q)<humin29@huawei.com<mailto:humin29@huawei.com>>
抄送： liuyonglong<liuyonglong@huawei.com<mailto:liuyonglong@huawei.com>>;lihuisong (C)<lihuisong@huawei.com<mailto:lihuisong@huawei.com>>
主题： [PATCH v2 1/3] doc/hns3: fix compilation option about max queue number
时间： 2023-11-20 19:13:58

This patch fixes the description of compilation option about setting max
queue number. The maximum queue number of HIP09 and HIP10 is determined by
the RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF and the value the firmware report.

Fixes: 21938cf4e43e ("doc: add build config option in hns3 guide")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index ee774639d3..7eac1b3c92 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -69,7 +69,8 @@ The following options can be modified in the ``config/rte_config.h`` file.

 - ``RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF`` (default ``256``)

-  Number of MAX queues reserved for PF.
+  Number of MAX queues reserved for PF on HIP09 and HIP10. The MAX queue
+  number is also determined by the value the firmware report.

 Runtime Configuration
 ~~~~~~~~~~~~~~~~~~~~~
--
2.33.0


[-- Attachment #2: Type: text/html, Size: 3297 bytes --]

RE: [PATCH v2 2/3] doc/hns3: update the features for hns3

[haijie]

[-- Attachment #1: Type: text/plain, Size: 2838 bytes --]


Acked-by: Jie Hai <haijie1@huawei.com<mailto:haijie1@huawei.com>>



________________________________

Hai Jie
Email：haijie1@huawei.com<mailto:haijie1@huawei.com>

发件人： lihuisong (C)<lihuisong@huawei.com<mailto:lihuisong@huawei.com>>
收件人： dev<dev@dpdk.org<mailto:dev@dpdk.org>>;ferruh.yigit<ferruh.yigit@amd.com<mailto:ferruh.yigit@amd.com>>;haijie<haijie1@huawei.com<mailto:haijie1@huawei.com>>;Zhuangyuzeng (Yisen)<yisen.zhuang@huawei.com<mailto:yisen.zhuang@huawei.com>>;Ferruh Yigit<ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>;humin (Q)<humin29@huawei.com<mailto:humin29@huawei.com>>;Hao Chen<chenh@yusur.tech<mailto:chenh@yusur.tech>>;Chunsong Feng<fengchunsong@huawei.com<mailto:fengchunsong@huawei.com>>;Fengchengwen<fengchengwen@huawei.com<mailto:fengchengwen@huawei.com>>;Lijun Ou<oulijun@huawei.com<mailto:oulijun@huawei.com>>;Wei Hu (Xavier)<xavier.huwei@huawei.com<mailto:xavier.huwei@huawei.com>>
抄送： liuyonglong<liuyonglong@huawei.com<mailto:liuyonglong@huawei.com>>;lihuisong (C)<lihuisong@huawei.com<mailto:lihuisong@huawei.com>>
主题： [PATCH v2 2/3] doc/hns3: update the features for hns3
时间： 2023-11-20 19:13:59

Update the features for hns3.

- "Basic stats" and "Extended stats" supported by
Fixes: 8839c5e202f3 ("net/hns3: support device stats")

- "Traffic Management API" supported by
Fixes: c09c7847d892 ("net/hns3: support traffic management")

- "Speed capabilities" supported by
Fixes: 09e0de1f411b ("net/hns3: report speed capability for PF")

- "Link Auto-negotiation" supported by
Fixes: bdaf190f8235 ("net/hns3: support link speed autoneg for PF")

- "Link flow control" supported by
Fixes: 62e3ccc2b94c ("net/hns3: support flow control")

- "Dump private info from device" supported by
Fixes: 1a03c659cb9d ("net/hns3: dump device basic info")

- "FW version" supported by
Fixes: 1f5ca0b460cd ("net/hns3: support some device operations")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 7eac1b3c92..11d0c04884 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -30,7 +30,6 @@ Features of the HNS3 PMD are:
 - DCB
 - Scattered and gather for TX and RX
 - Vector Poll mode driver
-- Dump register
 - SR-IOV VF
 - Multi-process
 - MAC/VLAN filter
@@ -38,6 +37,15 @@ Features of the HNS3 PMD are:
 - NUMA support
 - Generic flow API
 - IEEE1588/802.1AS timestamping
+- Basic stats
+- Extended stats
+- Traffic Management API
+- Speed capabilities
+- Link Auto-negotiation
+- Link flow control
+- Dump register
+- Dump private info from device
+- FW version

 Prerequisites
 -------------
--
2.33.0


[-- Attachment #2: Type: text/html, Size: 4762 bytes --]

RE: [PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow

[haijie]

[-- Attachment #1: Type: text/plain, Size: 3739 bytes --]


Acked-by: Jie Hai <haijie1@huawei.com<mailto:haijie1@huawei.com>>



________________________________

Hai Jie
Email：haijie1@huawei.com<mailto:haijie1@huawei.com>

发件人： lihuisong (C)<lihuisong@huawei.com<mailto:lihuisong@huawei.com>>
收件人： dev<dev@dpdk.org<mailto:dev@dpdk.org>>;ferruh.yigit<ferruh.yigit@amd.com<mailto:ferruh.yigit@amd.com>>;haijie<haijie1@huawei.com<mailto:haijie1@huawei.com>>;Zhuangyuzeng (Yisen)<yisen.zhuang@huawei.com<mailto:yisen.zhuang@huawei.com>>;humin (Q)<humin29@huawei.com<mailto:humin29@huawei.com>>
抄送： liuyonglong<liuyonglong@huawei.com<mailto:liuyonglong@huawei.com>>;lihuisong (C)<lihuisong@huawei.com<mailto:lihuisong@huawei.com>>
主题： [PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow
时间： 2023-11-20 19:13:59

The hns3 driver supports for creating rule base on input tuple, hash key,
queues and hash algorithm. But hash key, queues and hash algorithm are the
global configuration for hardware which will affect other rules. The rule
just setting input tuple is completely independent.

Fixes: 63a0f65c9572 ("doc: add more description in hns3 guide")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 42 ++++++++++++++++++++++++++--------------
 1 file changed, 28 insertions(+), 14 deletions(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 11d0c04884..e260b301a8 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -239,36 +239,50 @@ Generic flow API

 - ``RSS Flow``

-  RSS Flow supports to set hash input set, hash function, enable hash
-  and configure queues.
-  For example:
-  Configure queues as queue 0, 1, 2, 3.
+  RSS Flow supports for creating rule base on input tuple, hash key, queues
+  and hash algorithm. But hash key, queues and hash algorithm are the global
+  configuration for hardware which will affect other rules. The rule just
+  setting input tuple is completely independent.
+
+  Run ``testpmd``:

   .. code-block:: console

-    testpmd> flow create 0 ingress pattern end actions rss types end \
-      queues 0 1 2 3 end / end
+    dpdk-testpmd -a 0000:7d:00.0 -l 10-18 -- -i --rxq=8 --txq=8
+
+  All IP packets can be distributed to 8 queues.

-  Enable hash and set input set for IPv4-TCP.
+  Set ipv4-tcp packet is distributed to 8 queues based on L3/L4 SRC only.

   .. code-block:: console

-    testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end \
-      actions rss types ipv4-tcp l3-src-only end queues end / end
+    testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions \
+             rss types ipv4-tcp l4-src-only l3-src-only end queues end / end

-  Set symmetric hash enable for flow type IPv4-TCP.
+  Disable ipv4 packet RSS hash.

   .. code-block:: console

-    testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end \
-      actions rss types ipv4-tcp end queues end func symmetric_toeplitz / end
+    testpmd> flow create 0 ingress pattern eth / ipv4 / end actions rss \
+             types none end queues end / end

-  Set hash function as simple xor.
+  Set hash function as symmetric toeplitz.

   .. code-block:: console

     testpmd> flow create 0 ingress pattern end actions rss types end \
-      queues end func simple_xor / end
+             queues end func symmetric_toeplitz / end
+
+  In this case, all packets that enabled RSS are hashed using symmetric
+  toeplitz algorithm.
+
+  Flush all RSS rules
+
+  .. code-block:: console
+
+    testpmd> flow flush 0
+
+  The RSS configurations of hardwre is back to the one ethdev ops set.

 Statistics
 ----------
--
2.33.0


[-- Attachment #2: Type: text/html, Size: 6256 bytes --]

Re: [PATCH v2 0/3] doc/hns3: update the features for hns3

[Ferruh Yigit]

> On 11/20/2023 11:14 AM, Huisong Li wrote:
>> This series fix some feature description and update features for hns3.
>> 
>> Hope this series merge into 23.11.
>> 
>> ---
>>  v2: patch [2/3] add fixes tag of each feature to track the relevant code
>>      commit.
>> 
>> Huisong Li (3):
>>   doc/hns3: fix compilation option about max queue number
>>   doc/hns3: update the features for hns3
>>   doc/hns3: fix the usage description for RSS flow
>>  
>
> Acked-by: Jie Hai <haijie1@huawei.com>
>

Series applied to dpdk-next-net/main, thanks.