From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix packet inline on Tx queue wraparound
Date: Mon, 11 Mar 2019 19:58:02 +0000 [thread overview]
Message-ID: <44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com> (raw)
In-Reply-To: <20190310081410.94830-1-shahafs@mellanox.com>
> On Mar 10, 2019, at 12:14 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>
> Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE
> starts on the end of the ring and ends on the beginning, is not
> supported and blocked by the data path logic.
>
> However, in case of TSO, an extra inline header is required before
> inlining. This inline header is not taken into account when checking if
> there is enough room left for the required inline size.
> On some corner cases were
> (ring_tailroom - inline header) < inline size < ring_tailroom ,
> this can lead to WQE being written outsize of the ring buffer.
>
> Fixing it by always assuming the worse case that inline of packet will
> require the inline header.
>
> Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
> drivers/net/mlx5/mlx5_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index baa4079c14..38ce0e29a2 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -693,7 +693,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
> RTE_CACHE_LINE_SIZE);
> copy_b = (addr_end > addr) ?
> RTE_MIN((addr_end - addr), length) : 0;
> - if (copy_b && ((end - (uintptr_t)raw) > copy_b)) {
> + if (copy_b && ((end - (uintptr_t)raw) >
> + (copy_b + sizeof(inl)))) {
> /*
> * One Dseg remains in the current WQE. To
> * keep the computation positive, it is
> --
> 2.12.0
>
next prev parent reply other threads:[~2019-03-11 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 8:14 Shahaf Shuler
2019-03-11 19:58 ` Yongseok Koh [this message]
2019-03-14 9:08 ` Shahaf Shuler
2019-03-14 9:08 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).