* [PATCH] test/dma: fix api testuite teardown
@ 2024-03-11 15:25 Kevin Laatz
2024-03-12 1:29 ` fengchengwen
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Laatz @ 2024-03-11 15:25 UTC (permalink / raw)
To: dev; +Cc: fengchengwen, bruce.richardson, gmuthukrishn, Kevin Laatz
The API testsuite previously only used the dmadev skeleton. Now that real
devices are being used for the API tests, the DMA stats need to be reset
during testsuite teardown to ensure a known, clean state before continuing.
Fixes: 14b477ed1740 ("test/dma: use unit test framework")
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
app/test/test_dmadev_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_api.c
index a130e74b51..d40c05cfbf 100644
--- a/app/test/test_dmadev_api.c
+++ b/app/test/test_dmadev_api.c
@@ -82,6 +82,7 @@ testsuite_teardown(void)
dst = NULL;
/* Ensure the dmadev is stopped. */
rte_dma_stop(test_dev_id);
+ rte_dma_stats_reset(test_dev_id, RTE_DMA_ALL_VCHAN);
rte_log_set_level_pattern("lib.dmadev", RTE_LOG_INFO);
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test/dma: fix api testuite teardown
2024-03-11 15:25 [PATCH] test/dma: fix api testuite teardown Kevin Laatz
@ 2024-03-12 1:29 ` fengchengwen
2024-03-15 12:34 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: fengchengwen @ 2024-03-12 1:29 UTC (permalink / raw)
To: Kevin Laatz, dev; +Cc: bruce.richardson, gmuthukrishn
It's not a bugfix, but a best practice for test (clean state before continuing).
The other is LGTM,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/3/11 23:25, Kevin Laatz wrote:
> The API testsuite previously only used the dmadev skeleton. Now that real
> devices are being used for the API tests, the DMA stats need to be reset
> during testsuite teardown to ensure a known, clean state before continuing.
>
> Fixes: 14b477ed1740 ("test/dma: use unit test framework")
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> app/test/test_dmadev_api.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_api.c
> index a130e74b51..d40c05cfbf 100644
> --- a/app/test/test_dmadev_api.c
> +++ b/app/test/test_dmadev_api.c
> @@ -82,6 +82,7 @@ testsuite_teardown(void)
> dst = NULL;
> /* Ensure the dmadev is stopped. */
> rte_dma_stop(test_dev_id);
> + rte_dma_stats_reset(test_dev_id, RTE_DMA_ALL_VCHAN);
>
> rte_log_set_level_pattern("lib.dmadev", RTE_LOG_INFO);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test/dma: fix api testuite teardown
2024-03-12 1:29 ` fengchengwen
@ 2024-03-15 12:34 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2024-03-15 12:34 UTC (permalink / raw)
To: Kevin Laatz; +Cc: dev, bruce.richardson, gmuthukrishn, fengchengwen
12/03/2024 02:29, fengchengwen:
> It's not a bugfix, but a best practice for test (clean state before continuing).
>
> The other is LGTM,
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
>
> On 2024/3/11 23:25, Kevin Laatz wrote:
> > The API testsuite previously only used the dmadev skeleton. Now that real
> > devices are being used for the API tests, the DMA stats need to be reset
> > during testsuite teardown to ensure a known, clean state before continuing.
> >
> > Fixes: 14b477ed1740 ("test/dma: use unit test framework")
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-15 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 15:25 [PATCH] test/dma: fix api testuite teardown Kevin Laatz
2024-03-12 1:29 ` fengchengwen
2024-03-15 12:34 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).