* [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx
@ 2018-08-17 14:30 Jerin Jacob
2018-08-17 16:11 ` santosh
[not found] ` <219360be-5bf0-6009-d118-3983270412b3@caviumnetworks.com>
0 siblings, 2 replies; 3+ messages in thread
From: Jerin Jacob @ 2018-08-17 14:30 UTC (permalink / raw)
To: dev; +Cc: santosh.shukla, ferruh.yigit, vikas.aggarwal, Jerin Jacob, stable
LMTST does not guarantee packet content get synced with L2C when
HW access the packet for transmitting.
Adding coherent IO write barrier will make sure HW sees the correct
packet if its modified.
Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function")
Cc: stable@dpdk.org
Reported-by: Vikas Aggarwal <vikas.aggarwal@caviumnetworks.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/octeontx/octeontx_rxtx.c b/drivers/net/octeontx/octeontx_rxtx.c
index a9149b4e1..f861313e6 100644
--- a/drivers/net/octeontx/octeontx_rxtx.c
+++ b/drivers/net/octeontx/octeontx_rxtx.c
@@ -63,6 +63,7 @@ octeontx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
count = 0;
+ rte_cio_wmb();
while (count < nb_pkts) {
res = __octeontx_xmit_pkts(dq->lmtline_va, dq->ioreg_va,
dq->fc_status_va,
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx
2018-08-17 14:30 [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx Jerin Jacob
@ 2018-08-17 16:11 ` santosh
[not found] ` <219360be-5bf0-6009-d118-3983270412b3@caviumnetworks.com>
1 sibling, 0 replies; 3+ messages in thread
From: santosh @ 2018-08-17 16:11 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: ferruh.yigit, vikas.aggarwal, stable
On Friday 17 August 2018 08:00 PM, Jerin Jacob wrote:
> LMTST does not guarantee packet content get synced with L2C when
> HW access the packet for transmitting.
>
> Adding coherent IO write barrier will make sure HW sees the correct
> packet if its modified.
>
> Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function")
> Cc: stable@dpdk.org
>
> Reported-by: Vikas Aggarwal <vikas.aggarwal@caviumnetworks.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
Acked-by: Santosh Shukla <Santosh.Shukla@caviumnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx
[not found] ` <219360be-5bf0-6009-d118-3983270412b3@caviumnetworks.com>
@ 2018-08-23 16:28 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-08-23 16:28 UTC (permalink / raw)
To: santosh, Jerin Jacob, dev; +Cc: santosh.shukla, vikas.aggarwal, stable
On 8/17/2018 5:06 PM, santosh wrote:
>
> On Friday 17 August 2018 08:00 PM, Jerin Jacob wrote:
>> LMTST does not guarantee packet content get synced with L2C when
>> HW access the packet for transmitting.
>>
>> Adding coherent IO write barrier will make sure HW sees the correct
>> packet if its modified.
>>
>> Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Vikas Aggarwal <vikas.aggarwal@caviumnetworks.com>
>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> ---
>
> Acked-by: Santosh Shukla <Santosh.Shukla@caviumnetworks.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-23 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 14:30 [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx Jerin Jacob
2018-08-17 16:11 ` santosh
[not found] ` <219360be-5bf0-6009-d118-3983270412b3@caviumnetworks.com>
2018-08-23 16:28 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).