* [PATCH] net/dpaa2: change threshold value @ 2023-05-08 10:41 Tianli Lai 2023-05-15 8:16 ` Sachin Saxena (OSS) 0 siblings, 1 reply; 6+ messages in thread From: Tianli Lai @ 2023-05-08 10:41 UTC (permalink / raw) To: dev; +Cc: Hemant Agrawal, Sachin Saxena this threshold value can be changed with function argument nb_rx_desc. Signed-off-by: Tianli Lai <laitianli@tom.com> --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 679f33ae1a..ad892ded4a 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, dpaa2_q->cgid, &taildrop); } else { /*enabling per rx queue congestion control */ - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; + taildrop.threshold = nb_rx_desc * 1024; taildrop.units = DPNI_CONGESTION_UNIT_BYTES; taildrop.oal = CONG_RX_OAL; DPAA2_PMD_DEBUG("Enabling Byte based Drop on queue= %d", -- 2.27.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/dpaa2: change threshold value 2023-05-08 10:41 [PATCH] net/dpaa2: change threshold value Tianli Lai @ 2023-05-15 8:16 ` Sachin Saxena (OSS) 2023-06-09 14:20 ` Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Sachin Saxena (OSS) @ 2023-05-15 8:16 UTC (permalink / raw) To: Tianli Lai, dev; +Cc: Hemant Agrawal, Sachin Saxena On 5/8/2023 4:11 PM, Tianli Lai wrote: > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > this threshold value can be changed with function argument nb_rx_desc. > > Signed-off-by: Tianli Lai <laitianli@tom.com> > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index 679f33ae1a..ad892ded4a 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, > dpaa2_q->cgid, &taildrop); > } else { > /*enabling per rx queue congestion control */ > - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; > + taildrop.threshold = nb_rx_desc * 1024; > taildrop.units = DPNI_CONGESTION_UNIT_BYTES; > taildrop.oal = CONG_RX_OAL; > DPAA2_PMD_DEBUG("Enabling Byte based Drop on queue= %d", > -- > 2.27.0 > Hi Tianli, The number of bytes based tail drop threshold value "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we concluded this value after multiple benchmark experiments in past. Although, number of frame based threshold value is "nb_rx_desc" based only. We will further review this suggestion and get back. -- Thanks, Sachin Saxena (NXP) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/dpaa2: change threshold value 2023-05-15 8:16 ` Sachin Saxena (OSS) @ 2023-06-09 14:20 ` Ferruh Yigit 2023-09-29 13:50 ` Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2023-06-09 14:20 UTC (permalink / raw) To: Sachin Saxena (OSS), Tianli Lai, dev; +Cc: Hemant Agrawal, Sachin Saxena On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote: > On 5/8/2023 4:11 PM, Tianli Lai wrote: >> Caution: This is an external email. Please take care when clicking >> links or opening attachments. When in doubt, report the message using >> the 'Report this email' button >> >> >> this threshold value can be changed with function argument nb_rx_desc. >> >> Signed-off-by: Tianli Lai <laitianli@tom.com> >> --- >> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c >> b/drivers/net/dpaa2/dpaa2_ethdev.c >> index 679f33ae1a..ad892ded4a 100644 >> --- a/drivers/net/dpaa2/dpaa2_ethdev.c >> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c >> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, >> dpaa2_q->cgid, >> &taildrop); >> } else { >> /*enabling per rx queue congestion control */ >> - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; >> + taildrop.threshold = nb_rx_desc * 1024; >> taildrop.units = DPNI_CONGESTION_UNIT_BYTES; >> taildrop.oal = CONG_RX_OAL; >> DPAA2_PMD_DEBUG("Enabling Byte based Drop on >> queue= %d", >> -- >> 2.27.0 >> > Hi Tianli, > > The number of bytes based tail drop threshold value > "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we > concluded this value after multiple benchmark experiments in past. > Although, number of frame based threshold value is "nb_rx_desc" based only. > We will further review this suggestion and get back. > Hi Sachin, What is the status of this patch? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/dpaa2: change threshold value 2023-06-09 14:20 ` Ferruh Yigit @ 2023-09-29 13:50 ` Ferruh Yigit 2023-11-02 21:06 ` Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2023-09-29 13:50 UTC (permalink / raw) To: Sachin Saxena (OSS), Hemant Agrawal, Sachin Saxena; +Cc: dev, Tianli Lai On 6/9/2023 3:20 PM, Ferruh Yigit wrote: > On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote: >> On 5/8/2023 4:11 PM, Tianli Lai wrote: >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> this threshold value can be changed with function argument nb_rx_desc. >>> >>> Signed-off-by: Tianli Lai <laitianli@tom.com> >>> --- >>> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c >>> b/drivers/net/dpaa2/dpaa2_ethdev.c >>> index 679f33ae1a..ad892ded4a 100644 >>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c >>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c >>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, >>> dpaa2_q->cgid, >>> &taildrop); >>> } else { >>> /*enabling per rx queue congestion control */ >>> - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; >>> + taildrop.threshold = nb_rx_desc * 1024; >>> taildrop.units = DPNI_CONGESTION_UNIT_BYTES; >>> taildrop.oal = CONG_RX_OAL; >>> DPAA2_PMD_DEBUG("Enabling Byte based Drop on >>> queue= %d", >>> -- >>> 2.27.0 >>> >> Hi Tianli, >> >> The number of bytes based tail drop threshold value >> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we >> concluded this value after multiple benchmark experiments in past. >> Although, number of frame based threshold value is "nb_rx_desc" based only. >> We will further review this suggestion and get back. >> > > Hi Sachin, What is the status of this patch? > Ping ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/dpaa2: change threshold value 2023-09-29 13:50 ` Ferruh Yigit @ 2023-11-02 21:06 ` Ferruh Yigit 2023-11-03 15:58 ` Hemant Agrawal 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2023-11-02 21:06 UTC (permalink / raw) To: Sachin Saxena (OSS), Hemant Agrawal, Sachin Saxena; +Cc: dev, Tianli Lai On 9/29/2023 2:50 PM, Ferruh Yigit wrote: > On 6/9/2023 3:20 PM, Ferruh Yigit wrote: >> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote: >>> On 5/8/2023 4:11 PM, Tianli Lai wrote: >>>> Caution: This is an external email. Please take care when clicking >>>> links or opening attachments. When in doubt, report the message using >>>> the 'Report this email' button >>>> >>>> >>>> this threshold value can be changed with function argument nb_rx_desc. >>>> >>>> Signed-off-by: Tianli Lai <laitianli@tom.com> >>>> --- >>>> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c >>>> b/drivers/net/dpaa2/dpaa2_ethdev.c >>>> index 679f33ae1a..ad892ded4a 100644 >>>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c >>>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c >>>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, >>>> dpaa2_q->cgid, >>>> &taildrop); >>>> } else { >>>> /*enabling per rx queue congestion control */ >>>> - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; >>>> + taildrop.threshold = nb_rx_desc * 1024; >>>> taildrop.units = DPNI_CONGESTION_UNIT_BYTES; >>>> taildrop.oal = CONG_RX_OAL; >>>> DPAA2_PMD_DEBUG("Enabling Byte based Drop on >>>> queue= %d", >>>> -- >>>> 2.27.0 >>>> >>> Hi Tianli, >>> >>> The number of bytes based tail drop threshold value >>> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we >>> concluded this value after multiple benchmark experiments in past. >>> Although, number of frame based threshold value is "nb_rx_desc" based only. >>> We will further review this suggestion and get back. >>> >> >> Hi Sachin, What is the status of this patch? >> > > Ping > Hi Sachin, Hemant, If you believe current threshold value is more optimized value, please reject this patch, instead of letting it stuck around. Or @Tianli if you have more arguments to prove this is better value, can you please share them to help maintainers? ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/dpaa2: change threshold value 2023-11-02 21:06 ` Ferruh Yigit @ 2023-11-03 15:58 ` Hemant Agrawal 0 siblings, 0 replies; 6+ messages in thread From: Hemant Agrawal @ 2023-11-03 15:58 UTC (permalink / raw) To: Ferruh Yigit, Sachin Saxena (OSS), Sachin Saxena; +Cc: dev, Tianli Lai > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@amd.com> > Sent: Friday, November 3, 2023 2:36 AM > To: Sachin Saxena (OSS) <sachin.saxena@oss.nxp.com>; Hemant Agrawal > <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com> > Cc: dev@dpdk.org; Tianli Lai <laitianli@tom.com> > Subject: Re: [PATCH] net/dpaa2: change threshold value > Importance: High > > On 9/29/2023 2:50 PM, Ferruh Yigit wrote: > > On 6/9/2023 3:20 PM, Ferruh Yigit wrote: > >> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote: > >>> On 5/8/2023 4:11 PM, Tianli Lai wrote: > >>>> Caution: This is an external email. Please take care when clicking > >>>> links or opening attachments. When in doubt, report the message > >>>> using the 'Report this email' button > >>>> > >>>> > >>>> this threshold value can be changed with function argument > nb_rx_desc. > >>>> > >>>> Signed-off-by: Tianli Lai <laitianli@tom.com> > >>>> --- > >>>> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c > >>>> b/drivers/net/dpaa2/dpaa2_ethdev.c > >>>> index 679f33ae1a..ad892ded4a 100644 > >>>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c > >>>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > >>>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct > rte_eth_dev > >>>> *dev, > >>>> dpaa2_q->cgid, > >>>> &taildrop); > >>>> } else { > >>>> /*enabling per rx queue congestion control > >>>> */ > >>>> - taildrop.threshold = > >>>> CONG_THRESHOLD_RX_BYTES_Q; > >>>> + taildrop.threshold = nb_rx_desc * 1024; > >>>> taildrop.units = > >>>> DPNI_CONGESTION_UNIT_BYTES; > >>>> taildrop.oal = CONG_RX_OAL; > >>>> DPAA2_PMD_DEBUG("Enabling Byte based Drop > >>>> on queue= %d", > >>>> -- > >>>> 2.27.0 > >>>> > >>> Hi Tianli, > >>> > >>> The number of bytes based tail drop threshold value > >>> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 > >>> platform. we concluded this value after multiple benchmark > experiments in past. > >>> Although, number of frame based threshold value is "nb_rx_desc" > based only. > >>> We will further review this suggestion and get back. > >>> > >> > >> Hi Sachin, What is the status of this patch? > >> > > > > Ping > > > > Hi Sachin, Hemant, > > If you believe current threshold value is more optimized value, please reject > this patch, instead of letting it stuck around. [Hemant] Yes, NACK for us for now. > Or @Tianli if you have more arguments to prove this is better value, can you > please share them to help maintainers? ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-03 15:58 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-08 10:41 [PATCH] net/dpaa2: change threshold value Tianli Lai 2023-05-15 8:16 ` Sachin Saxena (OSS) 2023-06-09 14:20 ` Ferruh Yigit 2023-09-29 13:50 ` Ferruh Yigit 2023-11-02 21:06 ` Ferruh Yigit 2023-11-03 15:58 ` Hemant Agrawal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).