[dpdk-dev] arch check in example dpdk_qat

[dpdk-dev] arch check in example dpdk_qat

[Thomas Monjalon]

When reading examples/dpdk_qat/Makefile, we can see this check:

    ifneq ($(CONFIG_RTE_ARCH),"x86_64")
        ifneq ($(LBITS),i686)
        $(error The RTE_TARGET chosen is not compatible with this environment \
        (x86_64), for this application. Please change the definition of the \
        RTE_TARGET environment variable, or run the application on a 32-bit OS)
        endif
    endif

Is it on purpose to limit the 32-bit support to i686 only?
Instead of the message "run the application on a 32-bit OS", should it be
"on an i686 OS"?

Re: [dpdk-dev] arch check in example dpdk_qat

[De Lara Guarch, Pablo]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, March 23, 2016 11:04 AM
> To: Richardson, Bruce; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: arch check in example dpdk_qat
> 
> When reading examples/dpdk_qat/Makefile, we can see this check:
> 
>     ifneq ($(CONFIG_RTE_ARCH),"x86_64")
>         ifneq ($(LBITS),i686)
>         $(error The RTE_TARGET chosen is not compatible with this environment
> \
>         (x86_64), for this application. Please change the definition of the \
>         RTE_TARGET environment variable, or run the application on a 32-bit
> OS)
>         endif
>     endif
> 
> Is it on purpose to limit the 32-bit support to i686 only?
> Instead of the message "run the application on a 32-bit OS", should it be
> "on an i686 OS"?

i686 OS looks fine to me. Basically, when this app was made, the only 32-bit target was i686,
and the app needs the QAT driver to be running in 32 bits, if DPDK target is 32-bit.

Thanks,
Pablo

Re: [dpdk-dev] arch check in example dpdk_qat

[Thomas Monjalon]

2016-03-24 10:50, De Lara Guarch, Pablo:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > When reading examples/dpdk_qat/Makefile, we can see this check:
> > 
> >     ifneq ($(CONFIG_RTE_ARCH),"x86_64")
> >         ifneq ($(LBITS),i686)
> >         $(error The RTE_TARGET chosen is not compatible with this environment
> > \
> >         (x86_64), for this application. Please change the definition of the \
> >         RTE_TARGET environment variable, or run the application on a 32-bit
> > OS)
> >         endif
> >     endif
> > 
> > Is it on purpose to limit the 32-bit support to i686 only?
> > Instead of the message "run the application on a 32-bit OS", should it be
> > "on an i686 OS"?
> 
> i686 OS looks fine to me. Basically, when this app was made, the only 32-bit target was i686,

What about i386, i486, i586 builds ?

> and the app needs the QAT driver to be running in 32 bits, if DPDK target is 32-bit.

Re: [dpdk-dev] arch check in example dpdk_qat

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, March 24, 2016 11:01 AM
> To: De Lara Guarch, Pablo
> Cc: Richardson, Bruce; dev@dpdk.org
> Subject: Re: arch check in example dpdk_qat
> 
> 2016-03-24 10:50, De Lara Guarch, Pablo:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > When reading examples/dpdk_qat/Makefile, we can see this check:
> > >
> > >     ifneq ($(CONFIG_RTE_ARCH),"x86_64")
> > >         ifneq ($(LBITS),i686)
> > >         $(error The RTE_TARGET chosen is not compatible with this
> environment
> > > \
> > >         (x86_64), for this application. Please change the definition of the \
> > >         RTE_TARGET environment variable, or run the application on a 32-bit
> > > OS)
> > >         endif
> > >     endif
> > >
> > > Is it on purpose to limit the 32-bit support to i686 only?
> > > Instead of the message "run the application on a 32-bit OS", should it be
> > > "on an i686 OS"?
> >
> > i686 OS looks fine to me. Basically, when this app was made, the only 32-bit
> target was i686,
> 
> What about i386, i486, i586 builds ?

We only support i686, no other 32-bit architectures.
> 
> > and the app needs the QAT driver to be running in 32 bits, if DPDK target is
> 32-bit.

Re: [dpdk-dev] arch check in example dpdk_qat

[Thomas Monjalon]

2016-03-24 11:58, De Lara Guarch, Pablo:
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Thursday, March 24, 2016 11:01 AM
> > To: De Lara Guarch, Pablo
> > Cc: Richardson, Bruce; dev@dpdk.org
> > Subject: Re: arch check in example dpdk_qat
> > 
> > 2016-03-24 10:50, De Lara Guarch, Pablo:
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > When reading examples/dpdk_qat/Makefile, we can see this check:
> > > >
> > > >     ifneq ($(CONFIG_RTE_ARCH),"x86_64")
> > > >         ifneq ($(LBITS),i686)
> > > >         $(error The RTE_TARGET chosen is not compatible with this
> > environment
> > > > \
> > > >         (x86_64), for this application. Please change the definition of the \
> > > >         RTE_TARGET environment variable, or run the application on a 32-bit
> > > > OS)
> > > >         endif
> > > >     endif
> > > >
> > > > Is it on purpose to limit the 32-bit support to i686 only?
> > > > Instead of the message "run the application on a 32-bit OS", should it be
> > > > "on an i686 OS"?
> > >
> > > i686 OS looks fine to me. Basically, when this app was made, the only 32-bit
> > target was i686,
> > 
> > What about i386, i486, i586 builds ?
> 
> We only support i686, no other 32-bit architectures.

So we need a small patch :)