Re: [PATCH V6 0/8] app/testpmd: fix RSS and flow type

[Ferruh Yigit <ferruh.yigit@xilinx.com>]

On 6/29/2022 9:34 AM, Huisong Li wrote:
> This patchset fix RSS related code and remove duplicated flow type to
> string table.
> 
> ---
> v6:
>   - add a release note for renaming testpmd RSS type 'ether'.
>   - revert "unknown offload xxx" print.
> 
> v5:
>   - resolve a warning in testpmd_funcs.rst file
> 
> v4:
>   - delete 'rss_offload_table[]' and use 'rss_type_table[]'
>   - add an 'char_num_per_line' parameter to control RSS types display.
>   - add 2/7, 3/7 and 6/7 patch.
> 
> v3:
>   - add 'rss_offload_table[]' to display supported RSS offload.
>   - add patch 3/4 and 4/4.
> 
> v2:
>   - resovle compilation failure when disable i40e and ixgbe.
> 
> Ferruh Yigit (2):
>    app/testpmd: compact RSS types output in some commands
>    app/testpmd: remove duplicated flow type to string table
> 
> Huisong Li (6):
>    app/testpmd: fix supported RSS offload display
>    app/testpmd: unify the name of L2 payload offload
>    doc: testpmd rename RSS type ether to L2 payload
>    app/testpmd: refactor config all RSS command
>    app/testpmd: unify RSS types display
>    app/testpmd: reorder elements in RSS type table array
> 

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

Series applied to dpdk-next-net/main, thanks.

Doc patch merged with relevant patch while merging.


Thanks for the cleanup. Addition to some internal cleanup/refactoring, 
output improved as following [1].

The output is "Supported RSS offload flow types", so it is the 
capability of the device, not current configuration.
Do you think does it make sense to add "Configured RSS offload types" too?
@Aman, @Yuying, what do you think?




[1] RSS related part of "show port info all"

new:
Supported RSS offload flow types:
   ipv4  ipv4-frag  ipv4-tcp  ipv4-udp  ipv4-other  ipv6
   ipv6-frag  ipv6-tcp  ipv6-udp  ipv6-other  ipv6-ex
   ipv6-tcp-ex  ipv6-udp-ex  esp  l4-dst-only  l4-src-only
   l3-dst-only  l3-src-only

old:
Supported RSS offload flow types:
   ipv4
   ipv4-frag
   ipv4-tcp
   ipv4-udp
   ipv4-other
   ipv6
   ipv6-frag
   ipv6-tcp
   ipv6-udp
   ipv6-other
   ipv6-ex
   ipv6-tcp-ex
   ipv6-udp-ex
   user defined 27
   user defined 60
   user defined 61
   user defined 62
   user defined 63