DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] i40e: Fix a vlan bug
@ 2014-12-04  9:50 Chen Jing D(Mark)
  2014-12-04 10:18 ` Qiu, Michael
  0 siblings, 1 reply; 11+ messages in thread
From: Chen Jing D(Mark) @ 2014-12-04  9:50 UTC (permalink / raw)
  To: dev

From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>

i40e uses an bitmap array to store those vlan tags that are set by
application. In function i40e_set_vlan_filter, it stores vlan tag
to wrong place. This change will fix it.

Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 87e750a..cebc21d 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -4163,8 +4163,8 @@ i40e_find_vlan_filter(struct i40e_vsi *vsi,
 {
 	uint32_t vid_idx, vid_bit;
 
-	vid_idx = (uint32_t) ((vlan_id >> 5) & 0x7F);
-	vid_bit = (uint32_t) (1 << (vlan_id & 0x1F));
+	vid_idx = (uint32_t)(vlan_id / I40E_UINT32_BIT_SIZE);
+	vid_bit = (uint32_t)(1 << (vlan_id % I40E_UINT32_BIT_SIZE));
 
 	if (vsi->vfta[vid_idx] & vid_bit)
 		return 1;
@@ -4178,14 +4178,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi,
 {
 	uint32_t vid_idx, vid_bit;
 
-#define UINT32_BIT_MASK      0x1F
-#define VALID_VLAN_BIT_MASK  0xFFF
 	/* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the
 	 *  element first, then find the bits it belongs to
 	 */
-	vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >>
-		  sizeof(uint32_t));
-	vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK));
+	vid_idx = (uint32_t)(vlan_id / I40E_UINT32_BIT_SIZE);
+	vid_bit = (uint32_t)(1 << (vlan_id % I40E_UINT32_BIT_SIZE));
 
 	if (on)
 		vsi->vfta[vid_idx] |= vid_bit;
-- 
1.7.7.6

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-12-05  9:19 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-04  9:50 [dpdk-dev] [PATCH] i40e: Fix a vlan bug Chen Jing D(Mark)
2014-12-04 10:18 ` Qiu, Michael
2014-12-04 10:25   ` Chen, Jing D
2014-12-04 10:25   ` Thomas Monjalon
2014-12-04 10:30     ` Chen, Jing D
2014-12-04 10:38       ` Thomas Monjalon
2014-12-04 14:29         ` Chen, Jing D
2014-12-04 15:32           ` Thomas Monjalon
2014-12-05  4:56             ` Xie, Huawei
2014-12-05  9:18               ` Thomas Monjalon
2014-12-05  8:38             ` Chen, Jing D

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).