From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix uninitialized scalar variable
Date: Mon, 23 Apr 2018 09:04:12 +0000 [thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D333469BC@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20180420143921.73335-1-roy.fan.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Friday, April 20, 2018 3:39 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH v2] examples/ip_pipeline: fix uninitialized scalar variable
>
> Coverity issue: 272575
> Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> - removed unecessary link.c update
>
> examples/ip_pipeline/cli.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index
> 199a31ff8..ec150ce4e 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -138,6 +138,8 @@ cmd_link(char **tokens,
> struct link *link;
> char *name;
>
> + memset(&p, 0, sizeof(p));
> +
> if ((n_tokens < 13) || (n_tokens > 14 + LINK_RXQ_RSS_MAX)) {
> snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
> return;
> --
> 2.13.6
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
next prev parent reply other threads:[~2018-04-23 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 10:47 [dpdk-dev] [PATCH] " Fan Zhang
2018-04-20 14:39 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2018-04-23 9:04 ` Singh, Jasvinder [this message]
2018-05-08 14:28 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBAA185211B4429112C315DA58FF6D333469BC@IRSMSX101.ger.corp.intel.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).