DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Removing more mbuf fields
@ 2020-11-04 23:42 Stephen Hemminger
  2020-11-05  7:20 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2020-11-04 23:42 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

Thanks for the work cleaning out some of the cruft in the mbuf to make space
for dynamic fields.

Are you going to breakup the hash union in mbuf?
There is some bits to be gained there for dynamic fields.

  - Flow director should be deprecated/gone/killed so hash.fdir can disappear.

  - QoS scheduling hash.sched should be a dynamic field.

  - Eventdev hash.tx_adapter.txq should be a dynamic field as  well.

  - hash.usr field is obviously an dynamic field candidate.

That leaves only hash.rss which is smaller (32 instead of 64 bits in union)
and should stay.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] Removing more mbuf fields
  2020-11-04 23:42 [dpdk-dev] Removing more mbuf fields Stephen Hemminger
@ 2020-11-05  7:20 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-11-05  7:20 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

05/11/2020 00:42, Stephen Hemminger:
> Thanks for the work cleaning out some of the cruft in the mbuf to make space
> for dynamic fields.
> 
> Are you going to breakup the hash union in mbuf?
> There is some bits to be gained there for dynamic fields.
> 
>   - Flow director should be deprecated/gone/killed so hash.fdir can disappear.
> 
>   - QoS scheduling hash.sched should be a dynamic field.
> 
>   - Eventdev hash.tx_adapter.txq should be a dynamic field as  well.
> 
>   - hash.usr field is obviously an dynamic field candidate.
> 
> That leaves only hash.rss which is smaller (32 instead of 64 bits in union)
> and should stay.

Yes such dynamic fields can be used during next year,
so we are prepared to remove more fields in 21.11 next year.
I hope such cleanup can be contributing by multiple volunteers.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-05  7:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 23:42 [dpdk-dev] Removing more mbuf fields Stephen Hemminger
2020-11-05  7:20 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git