* [dpdk-dev] [PATCH] eal: fix Windows build
@ 2020-04-21 15:05 talshn
2020-04-21 22:47 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: talshn @ 2020-04-21 15:05 UTC (permalink / raw)
To: dev; +Cc: thomas, Tal Shnaiderman
From: Tal Shnaiderman <talshn@mellanox.com>
Windows headers pthread.h and fnmatch.h
uses rte_common types
The error is: error: unknown type name '__rte_unused'
The fix adds the missing includes.
Bugzilla ID: 458
Fixes: f2fc83b40f06 ("replace unused attributes")
Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
---
Depends-on: patch-68444
(eal/windows: do not expose private EAL facilities)
---
lib/librte_eal/windows/include/fnmatch.h | 2 ++
lib/librte_eal/windows/include/pthread.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/lib/librte_eal/windows/include/fnmatch.h b/lib/librte_eal/windows/include/fnmatch.h
index 41b574312..d0159f07a 100644
--- a/lib/librte_eal/windows/include/fnmatch.h
+++ b/lib/librte_eal/windows/include/fnmatch.h
@@ -14,6 +14,8 @@
extern "C" {
#endif
+#include <rte_common.h>
+
#define FNM_NOMATCH 1
/**
diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h
index 7c0caaf07..0bbed5c3b 100644
--- a/lib/librte_eal/windows/include/pthread.h
+++ b/lib/librte_eal/windows/include/pthread.h
@@ -17,6 +17,7 @@ extern "C" {
#endif
#include <windows.h>
+#include <rte_common.h>
#define PTHREAD_BARRIER_SERIAL_THREAD TRUE
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix Windows build
2020-04-21 15:05 [dpdk-dev] [PATCH] eal: fix Windows build talshn
@ 2020-04-21 22:47 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-04-21 22:47 UTC (permalink / raw)
To: Tal Shnaiderman; +Cc: dev
21/04/2020 17:05, talshn@mellanox.com:
> From: Tal Shnaiderman <talshn@mellanox.com>
>
> Windows headers pthread.h and fnmatch.h
> uses rte_common types
>
> The error is: error: unknown type name '__rte_unused'
>
> The fix adds the missing includes.
>
> Bugzilla ID: 458
> Fixes: f2fc83b40f06 ("replace unused attributes")
>
> Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
> ---
> Depends-on: patch-68444
> (eal/windows: do not expose private EAL facilities)
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-21 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 15:05 [dpdk-dev] [PATCH] eal: fix Windows build talshn
2020-04-21 22:47 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).