From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: David Marchand <david.marchand@redhat.com>, Thomas Monjalon <thomas@monjalon.net> Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH] devtools: test different build types Date: Fri, 23 Jul 2021 23:26:46 +0300 Message-ID: <61d96f4e-7a98-50dd-5ab9-8f75460907a7@oktetlabs.ru> (raw) In-Reply-To: <CAJFAV8zs0YtUwbg=gpDw_fao2hUU7FZmxPQkdGDLeY_n47mmzA@mail.gmail.com> On 5/21/21 6:03 PM, David Marchand wrote: > On Mon, Apr 12, 2021 at 11:54 PM Thomas Monjalon <thomas@monjalon.net> wrote: >> @@ -213,9 +218,10 @@ for c in gcc clang ; do >> abicheck=ABI > > init of buildtype var is missing here. +1 > Rest lgtm. > >> else >> abicheck=skipABI # save time and disk space >> + buildtype='--buildtype=minsize' >> fi >> export CC="$CCACHE $c" >> - build build-$c-$s $c $abicheck --default-library=$s >> + build build-$c-$s $c $abicheck $buildtype --default-library=$s >> unset CC >> done >> done > > with review notes applied: Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
next prev parent reply other threads:[~2021-07-23 20:26 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-12 21:53 Thomas Monjalon 2021-05-21 15:03 ` David Marchand 2021-07-23 20:26 ` Andrew Rybchenko [this message] 2021-08-02 22:45 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 0/5] more build tests Thomas Monjalon 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 1/5] net/qede: fix minsize build Thomas Monjalon 2021-08-09 5:15 ` [dpdk-dev] [EXT] " Devendra Singh Rawat 2021-08-09 7:11 ` Rasesh Mody 2021-09-15 15:16 ` David Marchand 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 2/5] regex/mlx5: " Thomas Monjalon 2021-08-11 8:48 ` Ruifeng Wang 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 3/5] vdpa/mlx5: " Thomas Monjalon 2021-08-09 6:43 ` Matan Azrad 2021-08-11 8:48 ` Ruifeng Wang 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 4/5] test/crypto: " Thomas Monjalon 2021-08-11 8:48 ` Ruifeng Wang 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 5/5] devtools: test different build types Thomas Monjalon 2021-09-15 20:27 ` [dpdk-dev] [PATCH v3 0/5] more build tests Ferruh Yigit 2021-09-16 7:05 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=61d96f4e-7a98-50dd-5ab9-8f75460907a7@oktetlabs.ru \ --to=andrew.rybchenko@oktetlabs.ru \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git