From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
Cc: <oss-drivers@corigine.com>, <niklas.soderlund@corigine.com>,
Heinrich Kuhn <heinrich.kuhn@corigine.com>
Subject: Re: [PATCH v8 04/12] net/nfp: add initial flower firmware support
Date: Thu, 8 Sep 2022 17:24:49 +0100 [thread overview]
Message-ID: <62c7afa8-9ab9-3491-fd66-fbd0cd60eccf@xilinx.com> (raw)
In-Reply-To: <1662626702-17254-5-git-send-email-chaoyong.he@corigine.com>
On 9/8/2022 9:44 AM, Chaoyong He wrote:
> Adds the basic probing infrastructure to support the flower firmware.
>
> Adds the basic infrastructure needed by the flower firmware to operate.
> The firmware requires threads to service both the PF vNIC and the ctrl
> vNIC. The PF is responsible for handling any fallback traffic and the
> ctrl vNIC is used to communicate various control messages to and
> from the smartNIC. rte_services are used to facilitate this logic.
>
> Adds the cpp service, used for some user tools.
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> doc/guides/rel_notes/release_22_11.rst | 3 ++
Can you please update driver documentation too,
'doc/guides/nics/nfp.rst', to document these new features?
Please update it gradually in each relevant patch, as you are already
doing for release notes updates.
> drivers/net/nfp/flower/nfp_flower.c | 59 +++++++++++++++++++++++
> drivers/net/nfp/flower/nfp_flower.h | 18 +++++++
> drivers/net/nfp/meson.build | 1 +
> drivers/net/nfp/nfp_common.h | 1 +
> drivers/net/nfp/nfp_cpp_bridge.c | 87 +++++++++++++++++++++++++++++-----
> drivers/net/nfp/nfp_cpp_bridge.h | 6 ++-
> drivers/net/nfp/nfp_ethdev.c | 28 ++++++++++-
> 8 files changed, 187 insertions(+), 16 deletions(-)
> create mode 100644 drivers/net/nfp/flower/nfp_flower.c
> create mode 100644 drivers/net/nfp/flower/nfp_flower.h
>
> diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
> index f601617..bb170e3 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -55,6 +55,9 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> + * **Updated Netronome nfp driver.**
This is still in the section comment, need to fix the indentation to
move it out of comment.
And please put an empty line after this line.
Please compile and verify the documentation updates.
> + Added the support of flower firmware.
> + Added the flower service infrastructure.
In output these lines are joined, if the intentions is have them as
bullets, need to add '*' prefix, like:
```
* **Updated Netronome nfp driver.**
* Added the support of flower firmware.
* Added the flower service infrastructure.
* Added the control message interactive channels between PMD and
firmware.
* Added the support of representor port.
```
next prev parent reply other threads:[~2022-09-08 16:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 8:44 [PATCH v8 00/12] preparation for the rte_flow offload of nfp PMD Chaoyong He
2022-09-08 8:44 ` [PATCH v8 01/12] net/nfp: move app specific attributes to own struct Chaoyong He
2022-09-08 16:24 ` Ferruh Yigit
2022-09-09 1:49 ` Chaoyong He
2022-09-09 5:43 ` Chaoyong He
2022-09-09 12:13 ` Ferruh Yigit
2022-09-08 8:44 ` [PATCH v8 02/12] net/nfp: simplify initialization and remove dead code Chaoyong He
2022-09-08 8:44 ` [PATCH v8 03/12] net/nfp: move app specific init logic to own function Chaoyong He
2022-09-08 8:44 ` [PATCH v8 04/12] net/nfp: add initial flower firmware support Chaoyong He
2022-09-08 16:24 ` Ferruh Yigit [this message]
2022-09-08 8:44 ` [PATCH v8 05/12] net/nfp: add flower PF setup logic Chaoyong He
2022-09-08 16:24 ` Ferruh Yigit
2022-09-09 2:36 ` Chaoyong He
2022-09-09 12:13 ` Ferruh Yigit
2022-09-14 9:20 ` Thomas Monjalon
2022-09-09 12:19 ` Ferruh Yigit
2022-09-13 6:51 ` Chaoyong He
2022-09-13 9:08 ` Ferruh Yigit
2022-09-14 1:23 ` Chaoyong He
2022-09-14 9:25 ` Thomas Monjalon
2022-09-08 8:44 ` [PATCH v8 06/12] net/nfp: add flower PF related routines Chaoyong He
2022-09-08 8:44 ` [PATCH v8 07/12] net/nfp: add flower ctrl VNIC related logics Chaoyong He
2022-09-08 8:44 ` [PATCH v8 08/12] net/nfp: move common rxtx function for flower use Chaoyong He
2022-09-08 8:44 ` [PATCH v8 09/12] net/nfp: add flower ctrl VNIC rxtx logic Chaoyong He
2022-09-08 8:45 ` [PATCH v8 10/12] net/nfp: add flower representor framework Chaoyong He
2022-09-08 8:45 ` [PATCH v8 11/12] net/nfp: move rxtx function to header file Chaoyong He
2022-09-08 8:45 ` [PATCH v8 12/12] net/nfp: add flower PF rxtx logic Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c7afa8-9ab9-3491-fd66-fbd0cd60eccf@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).