DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] build: use platform option for generic and native
Date: Wed, 21 Apr 2021 08:37:31 +0000	[thread overview]
Message-ID: <639b2b78f1f5487288dfd75f8a4f20f5@pantheon.tech> (raw)
In-Reply-To: <2390486.fr9dUZ1WAT@thomas>



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, April 20, 2021 10:36 AM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: david.marchand@redhat.com; bruce.richardson@intel.com;
> Honnappa.Nagarahalli@arm.com; Ruifeng.Wang@arm.com; dev@dpdk.org
> Subject: Re: [PATCH v5] build: use platform option for generic and native
> 
> 20/04/2021 10:16, Juraj Linkeš:
> > > option('platform', type: 'string', value: '',
> > > -	description: 'use configuration for a particular platform (such as a SoC).')
> > > +option('platform', type: 'string', value: 'generic',
> > > +	description: 'Platform to build, either "native", "generic" or an
> > > +Arm SoC. Please refer to the Linux build guide for more
> > > +information.')
> >
> > The other thing we need to discuss is the fact that we're changing the behavior
> in this patch from machine=native to platform=generic (and the implied
> cpu_instruction_set=genetic which equals to machine=generic). We need more
> feedback on this - Thomas, David? Should we include more people? The reason
> for this change is we want the build without any meson options (specified on
> cmdline) to be usable on as many different machines of the same architecture
> (this is my understanding form the discussion with Bruce), which is the generic
> platform. We could preserve the current behavior by setting the default to
> native, so we just need more discussion.
> 
> I don't understand why you need to change the behaviour.

Well, we don't *need* to change the behavior - I don't mind it either way. We've come to this point after discussing the change with Bruce. I believe Bruce mentioned the intention of the build without any meson cmdline options was to produce a build usable on most machines that match the build architecture and the generic build fits better (native build being more tailored to the build machine as opposed to the generic build).

I don't want to speak for Bruce though, so it'd be the best if he gave his thoughts on the matter.

> If we change the behaviour, it must be done carefully after a deprecation notice
> and an agreement of the Technical Board.
> 
> 

Ok, one thing we could do is preserve the behavior in this patch and go through this process with a separate change.

  reply	other threads:[~2021-04-21  8:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 15:47 [dpdk-dev] [RFC PATCH v1] build: add platform meson option Juraj Linkeš
2020-11-26 16:02 ` Bruce Richardson
2020-11-27  8:31   ` Juraj Linkeš
2020-11-27 14:07     ` Bruce Richardson
2020-12-23 11:23       ` Juraj Linkeš
2021-01-04 11:52 ` [dpdk-dev] [RFC PATCH v2] " Juraj Linkeš
2021-01-04 11:59   ` Juraj Linkeš
2021-01-05 22:17     ` David Christensen
2021-01-06 14:42       ` Bruce Richardson
2021-02-19  9:11         ` Juraj Linkeš
2021-02-22 21:25           ` David Christensen
2021-02-23  8:45             ` Juraj Linkeš
2021-02-23  9:43               ` Bruce Richardson
2021-02-25 12:51                 ` Juraj Linkeš
2021-02-25 12:54                   ` Bruce Richardson
2021-02-25 12:57                     ` Juraj Linkeš
2021-03-29 11:03   ` [dpdk-dev] [PATCH v3] " Juraj Linkeš
2021-03-29 12:50     ` [dpdk-dev] [PATCH v4] " Juraj Linkeš
2021-03-31 12:16       ` Juraj Linkeš
2021-03-31 12:19         ` Juraj Linkeš
2021-03-31 12:39         ` Bruce Richardson
2021-04-15 13:32           ` Juraj Linkeš
2021-04-15 13:51             ` Bruce Richardson
2021-04-20  8:08       ` [dpdk-dev] [PATCH v5] build: use platform option for generic and native Juraj Linkeš
2021-04-20  8:16         ` Juraj Linkeš
2021-04-20  8:36           ` Thomas Monjalon
2021-04-21  8:37             ` Juraj Linkeš [this message]
2021-04-22  8:34               ` Wang, Yinan
2021-06-30 13:09         ` [dpdk-dev] [PATCH v6] build: use platform for generic and native builds Juraj Linkeš
2021-07-06  9:44           ` [dpdk-dev] [PATCH v7] " Juraj Linkeš
2021-07-07 13:59             ` Bruce Richardson
2021-07-09 12:30               ` Thomas Monjalon
2021-07-09 13:55                 ` Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=639b2b78f1f5487288dfd75f8a4f20f5@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).