DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1] app/testpmd : return if no packets in GRO heavy weight mode
@ 2024-02-25  6:16 Kumara Parameshwaran
  2024-02-26 10:43 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Kumara Parameshwaran @ 2024-02-25  6:16 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Kumara Parameshwaran, stable

If there are no packets flushed in GRO heavy weight mode,
return false as this fall through code would return true
indicating that packets are available

Fixes: 461c287ab553 ("app/testpmd: fix GRO packets flush on timeout")
Cc: stable@dpdk.org

Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
---
 app/test-pmd/csumonly.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index d73f08b2c6..6711dda42e 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -1142,6 +1142,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
 						gro_pkts_num);
 				fs->gro_times = 0;
 			}
+			if (nb_rx == 0)
+				return false;
 		}
 
 		pkts_ip_csum_recalc(pkts_burst, nb_rx, tx_offloads);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] app/testpmd : return if no packets in GRO heavy weight mode
  2024-02-25  6:16 [PATCH v1] app/testpmd : return if no packets in GRO heavy weight mode Kumara Parameshwaran
@ 2024-02-26 10:43 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-02-26 10:43 UTC (permalink / raw)
  To: Kumara Parameshwaran; +Cc: dev, stable

On 2/25/2024 6:16 AM, Kumara Parameshwaran wrote:
> If there are no packets flushed in GRO heavy weight mode,
> return false as this fall through code would return true
> indicating that packets are available
> 
> Fixes: 461c287ab553 ("app/testpmd: fix GRO packets flush on timeout")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> 
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-26 10:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-25  6:16 [PATCH v1] app/testpmd : return if no packets in GRO heavy weight mode Kumara Parameshwaran
2024-02-26 10:43 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).