From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: niklas.soderlund@corigine.com,
Heinrich Kuhn <heinrich.kuhn@corigine.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic
Date: Thu, 23 Jun 2022 15:36:29 +0300 [thread overview]
Message-ID: <74bd95f5-8011-079f-eda1-a5db5fcfb09b@oktetlabs.ru> (raw)
In-Reply-To: <1655807588-7320-10-git-send-email-chaoyong.he@corigine.com>
On 6/21/22 13:33, Chaoyong He wrote:
> Add a Rx and Tx function for the control vNIC. The logic is mostly
> identical to the normal Rx and Tx functionality of the NFP PMD.
>
> This commit also makes use of the ctrl vNIC service logic to
> service the ctrl vNIC Rx path.
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
[snip]
> + /* Flower ctrl vNIC only has a single tx queue */
> + txq = ctrl_dev->data->tx_queues[0];
> + if (unlikely(txq == NULL)) {
> + /*
> + * DPDK just checks the queue is lower than max queues
> + * enabled. But the queue needs to be configured
> + */
> + rte_panic("ctrl dev TX Bad queue");
checkpatches.sh warnings about it [1]. Please, rework code to
avoid usage of rte_panic().
> + }
> +
> + txds = &txq->txds[txq->wr_p];
> + txds->vals[0] = 0;
> + txds->vals[1] = 0;
> + txds->vals[2] = 0;
> + txds->vals[3] = 0;
> +
> + if (nfp_net_nfd3_txq_full(txq))
> + nfp_net_tx_free_bufs(txq);
> +
> + free_descs = nfp_net_nfd3_free_tx_desc(txq);
> + if (unlikely(free_descs == 0))
> + rte_panic("ctrl dev no free descs");
same here
[snip]
[1] http://mails.dpdk.org/archives/test-report/2022-June/290999.html
next prev parent reply other threads:[~2022-06-23 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 10:32 [PATCH v2 00/12] preparation for the rte_flow offload of nfp PMD Chaoyong He
2022-06-21 10:32 ` [PATCH v2 01/12] net/nfp: move app specific attributes to own struct Chaoyong He
2022-06-21 10:32 ` [PATCH v2 02/12] net/nfp: simplify initialization and remove dead code Chaoyong He
2022-06-21 10:32 ` [PATCH v2 03/12] net/nfp: move app specific init logic to own function Chaoyong He
2022-06-21 10:33 ` [PATCH v2 04/12] net/nfp: add initial flower firmware support Chaoyong He
2022-06-21 10:33 ` [PATCH v2 05/12] net/nfp: add flower PF setup and mempool init logic Chaoyong He
2022-06-21 10:33 ` [PATCH v2 06/12] net/nfp: add flower PF related routines Chaoyong He
2022-06-21 10:33 ` [PATCH v2 07/12] net/nfp: add flower ctrl VNIC related logics Chaoyong He
2022-06-21 10:33 ` [PATCH v2 08/12] net/nfp: move common rxtx function for flower use Chaoyong He
2022-06-21 10:33 ` [PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic Chaoyong He
2022-06-23 12:36 ` Andrew Rybchenko [this message]
2022-06-21 10:33 ` [PATCH v2 10/12] net/nfp: add flower representor framework Chaoyong He
2022-06-21 10:33 ` [PATCH v2 11/12] net/nfp: move rxtx function to header file Chaoyong He
2022-06-21 10:33 ` [PATCH v2 12/12] net/nfp: add flower PF rxtx logic Chaoyong He
2022-06-23 12:36 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74bd95f5-8011-079f-eda1-a5db5fcfb09b@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=heinrich.kuhn@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).